Skip to content

Conversation

@himsharma01
Copy link
Contributor

@himsharma01 himsharma01 commented Nov 20, 2024

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Nov 20, 2024
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himsharma01, you need to correct some of the screen images.

@himsharma01
Copy link
Contributor Author

Thanks for review @jpipkin1 , I have updated the PR with same.

Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the screen images, @himsharma01. It looks good now.

@himsharma01 himsharma01 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 9ab79b2 Nov 22, 2024
6 checks passed
@himsharma01 himsharma01 deleted the lb-cloudtrail branch November 22, 2024 10:48
himanshu219 pushed a commit that referenced this pull request Nov 30, 2024
* Updated docs for cloudTrail dashboard

* Updated screenshots| fer docs

* minor formatting

* adding images

* minor fix

---------

Co-authored-by: Jagadisha V <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants