Skip to content

DOCS-604 - Test Wistia video embedding #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2024
Merged

DOCS-604 - Test Wistia video embedding #4874

merged 2 commits into from
Dec 20, 2024

Conversation

@jpipkin1
Copy link
Collaborator

@jpipkin1 jpipkin1 commented Dec 12, 2024

Purpose of this pull request

This pull request tests embedding a video from Wistia into this article: https://help.sumologic.com/docs/cse/administration/mitre-coverage/

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

DOCS-604

@jpipkin1 jpipkin1 added the doc:minor edit Small fixes including typos and formatting label Dec 12, 2024
@jpipkin1 jpipkin1 self-assigned this Dec 12, 2024
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 12, 2024
kimsauce
kimsauce reviewed Dec 13, 2024
View reviewed changes
kimsauce
kimsauce requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to code

@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Dec 16, 2024

Thanks, @kimsauce! Your new code works great.

@jpipkin1 jpipkin1 enabled auto-merge December 16, 2024 15:26
@jpipkin1 jpipkin1 requested a review from kimsauce December 19, 2024 15:14
@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Dec 19, 2024

@kimsauce, could you take another look?

kimsauce
kimsauce approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@jpipkin1 jpipkin1 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 50c18bb Dec 20, 2024
7 checks passed
@jpipkin1 jpipkin1 deleted the test-wistia-video-embedding branch December 20, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimsauce kimsauce kimsauce approved these changes

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@jpipkin1 jpipkin1

Labels

cla-signed Contributor approved, listed in .clabot file doc:minor edit Small fixes including typos and formatting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpipkin1 @kimsauce