Skip to content

Conversation

@sachin-sumologic
Copy link
Collaborator

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Mar 26, 2025
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachin-sumologic, the build test for this PR is failing because there is no /reuse/apps/app-install-sc-k8s.md file. Correct the problem before submitting for review again. I placed this PR into draft mode since it is still a work in progress.

To find this sort of problem in the future, build locally first to make sure the PR is ready to review.

@jpipkin1 jpipkin1 marked this pull request as draft March 26, 2025 14:41
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachin-sumologic , please move your /reuse files into the /reuse/apps folder.

Screenshot 2025-04-02 at 11 29 30 PM

Copy link
Collaborator

@sumoanema sumoanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimsauce kimsauce self-requested a review April 30, 2025 16:58
@kimsauce kimsauce requested a review from jpipkin1 April 30, 2025 16:58
@sachin-sumologic sachin-sumologic added this pull request to the merge queue Apr 30, 2025
Merged via the queue into SumoLogic:main with commit 2581470 Apr 30, 2025
5 checks passed
@sachin-sumologic sachin-sumologic deleted the docks-enhancements-v1-v2-migration branch April 30, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants