Skip to content

DOCS-1187 - Fix sumo-square image in admonitions #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

DOCS-1187 - Fix sumo-square image in admonitions #5900

wants to merge 4 commits into from

Conversation

@jpipkin1
Copy link
Collaborator

@jpipkin1 jpipkin1 commented Oct 9, 2025

Purpose of this pull request

This pull request fixes the sumo-square image in admonitions for the site move.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

DOCS-1187

@jpipkin1 jpipkin1 self-assigned this Oct 9, 2025
@jpipkin1 jpipkin1 added the doc:update Revisions and updates to content label Oct 9, 2025
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 9, 2025
@jpipkin1 jpipkin1 marked this pull request as ready for review October 9, 2025 19:21
@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Oct 9, 2025 •
edited
Loading

@kimsauce, I couldn't get the sumo-square svg to render properly. So I replaced it with the info svg. We'll have to adjust it after the site move. (See comment in ticket DOCS-1187.)

@kimsauce
Copy link
Collaborator

kimsauce commented Oct 9, 2025

If you change the svg, you have to change the css, too, because this is a custom icon (Docusaurus does the others -- info, note, tip, etc). If you look at it in dark mode, the image gets washed out.

Would you consider swapping out the :::sumo with :::note or :::tip temporarily?

@jpipkin1 jpipkin1 requested review from a team as code owners October 9, 2025 20:07
@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Oct 9, 2025

Thanks, @kimsauce for your expertise! I replaced :::sumo with :::note.

@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Oct 9, 2025 •
edited
Loading

By the way, @kimsauce, it just occurred to me that the sumo admonition is broken because there is no useBaseUrl statement in the index.js file. Would that fix the problem?

@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Oct 9, 2025

Closing this PR. I'll create a new PR that instead imports the useBaseUrl statement to resolve the problem.

@jpipkin1 jpipkin1 closed this Oct 9, 2025
@jpipkin1 jpipkin1 mentioned this pull request Oct 9, 2025
Merged
4 tasks
@kimsauce kimsauce deleted the docs-1187-sumo-admonition branch October 22, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@jpipkin1 jpipkin1

Labels

cla-signed Contributor approved, listed in .clabot file doc:update Revisions and updates to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpipkin1 @kimsauce