Skip to content

Commit 288fb19

Browse files
Merge pull request #245 from SumoLogic/remove_rce_traces
Removed rce, xray and inventory references
2 parents ad16842 + 4e105ed commit 288fb19

File tree

15 files changed

+9
-207
lines changed

15 files changed

+9
-207
lines changed

aws-observability-terraform/examples/sourcemodule/overrideSources/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
| <a name="input_collect_elb"></a> [collect\_elb](#input\_collect\_elb) | Create a Sumo Logic ALB Logs Source.<br/> You have the following options:<br/> true - to ingest load balancer logs into Sumo Logic. Creates a Sumo Logic Log Source that collects application load balancer logs from an existing bucket or a new bucket.<br/> If true, please configure \"elb\_source\_details\" with configuration information including the bucket name and path expression to ingest load balancer logs.<br/> false - you are already ingesting load balancer logs into Sumo Logic. | `bool` | `true` | no |
7272
| <a name="input_collect_logs_cloudwatch"></a> [collect\_logs\_cloudwatch](#input\_collect\_logs\_cloudwatch) | Select the kind of Sumo Logic CloudWatch Logs Sources to create<br/> You have the following options:<br/> "Lambda Log Forwarder" - Creates a Sumo Logic CloudWatch Log Source that collects CloudWatch logs via a Lambda function.<br/> "Kinesis Firehose Log Source" - Creates a Sumo Logic Kinesis Firehose Log Source to collect CloudWatch logs.<br/> "None" - Skips installation of both sources. | `string` | `"Kinesis Firehose Log Source"` | no |
7373
| <a name="input_collect_metric_cloudwatch"></a> [collect\_metric\_cloudwatch](#input\_collect\_metric\_cloudwatch) | Select the kind of CloudWatch Metrics Source to create<br/> You have the following options:<br/> "CloudWatch Metrics Source" - Creates Sumo Logic AWS CloudWatch Metrics Sources.<br/> "Kinesis Firehose Metrics Source" (Recommended) - Creates a Sumo Logic AWS Kinesis Firehose for Metrics Source. Note: This new source has cost and performance benefits over the CloudWatch Metrics Source and is therefore recommended.<br/> "None" - Skips the Installation of both the Sumo Logic Metric Sources | `string` | `"Kinesis Firehose Metrics Source"` | no |
74-
| <a name="input_collect_rce"></a> [collect\_rce](#input\_collect\_rce) | Select the Sumo Logic Root Cause Explorer Source.<br/> You have the following options:<br/> Inventory Source - Creates a Sumo Logic Inventory Source used by Root Cause Explorer.<br/> Xray Source - Creates a Sumo Logic AWS X-Ray Source that collects X-Ray Trace Metrics from your AWS account.<br/> Both - Install both Inventory and Xray sources.<br/> None - Skips installation of both sources. | `string` | `"Both"` | no |
7574
| <a name="input_collector_id"></a> [collector\_id](#input\_collector\_id) | Required if you already have collector. | `string` | `""` | no |
7675
| <a name="input_create_collector"></a> [create\_collector](#input\_create\_collector) | Create a Sumo Logic Collector.<br/> You have the following options:<br/> true - If you want to create collector.<br/> false - If you already have a collector. | `bool` | `true` | no |
7776
| <a name="input_create_s3_bucket"></a> [create\_s3\_bucket](#input\_create\_s3\_bucket) | Create a AWS S3 bucket.<br/> You have the following options:<br/> true - If you want to create S3 bucket.<br/> false - If you already have a S3 bucket. | `bool` | `true` | no |
@@ -134,7 +133,5 @@
134133
| <a name="output_sumologic_field_networkloadbalancer"></a> [sumologic\_field\_networkloadbalancer](#output\_sumologic\_field\_networkloadbalancer) | This output contains sumologic networkloadbalancer field id. |
135134
| <a name="output_sumologic_field_region"></a> [sumologic\_field\_region](#output\_sumologic\_field\_region) | This output contains sumologic Region field id. |
136135
| <a name="output_sumologic_field_tablename"></a> [sumologic\_field\_tablename](#output\_sumologic\_field\_tablename) | This output contains sumologic tablename field id. |
137-
| <a name="output_sumologic_inventory_source"></a> [sumologic\_inventory\_source](#output\_sumologic\_inventory\_source) | This output contains sumologic aws inventory source id. |
138136
| <a name="output_sumologic_kinesis_firehose_for_logs_source"></a> [sumologic\_kinesis\_firehose\_for\_logs\_source](#output\_sumologic\_kinesis\_firehose\_for\_logs\_source) | This output contains sumologic kinesis firehose for logs source id. |
139137
| <a name="output_sumologic_kinesis_firehose_for_metrics_source"></a> [sumologic\_kinesis\_firehose\_for\_metrics\_source](#output\_sumologic\_kinesis\_firehose\_for\_metrics\_source) | This output contains sumologic kinesis firehose for metrics source id. |
140-
| <a name="output_sumologic_xray_source"></a> [sumologic\_xray\_source](#output\_sumologic\_xray\_source) | This output contains sumologic aws xray source id. |

aws-observability-terraform/examples/sourcemodule/overrideSources/main.auto.tfvars

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ sumo_api_endpoint = "" #"<YOUR SUMOLOGIC API ENDPOINT>"
2020
# collect_elb = "true"
2121
# collect_classic_lb = "true"
2222
# collect_cloudtrail = "true"
23-
# collect_rce = "Xray Source"
2423
# collect_logs_cloudwatch = "Kinesis Firehose Log Source"
2524
# collect_metric_cloudwatch = "CloudWatch Metrics Source"
2625
# create_s3_bucket = false

aws-observability-terraform/examples/sourcemodule/overrideSources/variables.tf

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -210,27 +210,6 @@ variable "collect_metric_cloudwatch" {
210210
default = "Kinesis Firehose Metrics Source"
211211
}
212212

213-
variable "collect_rce" {
214-
type = string
215-
description = <<EOT
216-
Select the Sumo Logic Root Cause Explorer Source.
217-
You have the following options:
218-
Inventory Source - Creates a Sumo Logic Inventory Source used by Root Cause Explorer.
219-
Xray Source - Creates a Sumo Logic AWS X-Ray Source that collects X-Ray Trace Metrics from your AWS account.
220-
Both - Install both Inventory and Xray sources.
221-
None - Skips installation of both sources.
222-
EOT
223-
validation {
224-
condition = contains([
225-
"Inventory Source",
226-
"Xray Source",
227-
"Both",
228-
"None", ], var.collect_rce)
229-
error_message = "The value must be one of \"Inventory Source\", \"Xray Source\", \"Both\" and None."
230-
}
231-
default = "Both"
232-
}
233-
234213
variable "elb_details" {
235214
type = object({
236215
source_name = string

aws-observability-terraform/examples/sourcemodule/testSource/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
| <a name="input_collect_elb"></a> [collect\_elb](#input\_collect\_elb) | Create a Sumo Logic ALB Logs Source.<br/> You have the following options:<br/> true - to ingest load balancer logs into Sumo Logic. Creates a Sumo Logic Log Source that collects application load balancer logs from an existing bucket or a new bucket.<br/> If true, please configure \"elb\_source\_details\" with configuration information including the bucket name and path expression to ingest load balancer logs.<br/> false - you are already ingesting load balancer logs into Sumo Logic. | `bool` | `true` | no |
7070
| <a name="input_collect_logs_cloudwatch"></a> [collect\_logs\_cloudwatch](#input\_collect\_logs\_cloudwatch) | Select the kind of Sumo Logic CloudWatch Logs Sources to create<br/> You have the following options:<br/> "Lambda Log Forwarder" - Creates a Sumo Logic CloudWatch Log Source that collects CloudWatch logs via a Lambda function.<br/> "Kinesis Firehose Log Source" - Creates a Sumo Logic Kinesis Firehose Log Source to collect CloudWatch logs.<br/> "None" - Skips installation of both sources. | `string` | `"Kinesis Firehose Log Source"` | no |
7171
| <a name="input_collect_metric_cloudwatch"></a> [collect\_metric\_cloudwatch](#input\_collect\_metric\_cloudwatch) | Select the kind of CloudWatch Metrics Source to create<br/> You have the following options:<br/> "CloudWatch Metrics Source" - Creates Sumo Logic AWS CloudWatch Metrics Sources.<br/> "Kinesis Firehose Metrics Source" (Recommended) - Creates a Sumo Logic AWS Kinesis Firehose for Metrics Source. Note: This new source has cost and performance benefits over the CloudWatch Metrics Source and is therefore recommended.<br/> "None" - Skips the Installation of both the Sumo Logic Metric Sources | `string` | `"Kinesis Firehose Metrics Source"` | no |
72-
| <a name="input_collect_rce"></a> [collect\_rce](#input\_collect\_rce) | Select the Sumo Logic Root Cause Explorer Source.<br/> You have the following options:<br/> Inventory Source - Creates a Sumo Logic Inventory Source used by Root Cause Explorer.<br/> Xray Source - Creates a Sumo Logic AWS X-Ray Source that collects X-Ray Trace Metrics from your AWS account.<br/> Both - Install both Inventory and Xray sources.<br/> None - Skips installation of both sources. | `string` | `"Both"` | no |
7372
| <a name="input_collector_id"></a> [collector\_id](#input\_collector\_id) | Required if you already have collector. | `string` | `""` | no |
7473
| <a name="input_create_collector"></a> [create\_collector](#input\_create\_collector) | Create a Sumo Logic Collector.<br/> You have the following options:<br/> true - If you want to create collector.<br/> false - If you already have a collector. | `bool` | `true` | no |
7574
| <a name="input_create_s3_bucket"></a> [create\_s3\_bucket](#input\_create\_s3\_bucket) | Create a AWS S3 bucket.<br/> You have the following options:<br/> true - If you want to create S3 bucket.<br/> false - If you already have a S3 bucket. | `bool` | `true` | no |
@@ -133,7 +132,5 @@
133132
| <a name="output_sumologic_field_networkloadbalancer"></a> [sumologic\_field\_networkloadbalancer](#output\_sumologic\_field\_networkloadbalancer) | This output contains sumologic networkloadbalancer field id. |
134133
| <a name="output_sumologic_field_region"></a> [sumologic\_field\_region](#output\_sumologic\_field\_region) | This output contains sumologic Region field id. |
135134
| <a name="output_sumologic_field_tablename"></a> [sumologic\_field\_tablename](#output\_sumologic\_field\_tablename) | This output contains sumologic tablename field id. |
136-
| <a name="output_sumologic_inventory_source"></a> [sumologic\_inventory\_source](#output\_sumologic\_inventory\_source) | This output contains sumologic aws inventory source id. |
137135
| <a name="output_sumologic_kinesis_firehose_for_logs_source"></a> [sumologic\_kinesis\_firehose\_for\_logs\_source](#output\_sumologic\_kinesis\_firehose\_for\_logs\_source) | This output contains sumologic kinesis firehose for logs source id. |
138136
| <a name="output_sumologic_kinesis_firehose_for_metrics_source"></a> [sumologic\_kinesis\_firehose\_for\_metrics\_source](#output\_sumologic\_kinesis\_firehose\_for\_metrics\_source) | This output contains sumologic kinesis firehose for metrics source id. |
139-
| <a name="output_sumologic_xray_source"></a> [sumologic\_xray\_source](#output\_sumologic\_xray\_source) | This output contains sumologic aws xray source id. |

aws-observability-terraform/examples/sourcemodule/testSource/variables.tf

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -237,27 +237,6 @@ variable "collect_metric_cloudwatch" {
237237
default = "Kinesis Firehose Metrics Source"
238238
}
239239

240-
variable "collect_rce" {
241-
type = string
242-
description = <<EOT
243-
Select the Sumo Logic Root Cause Explorer Source.
244-
You have the following options:
245-
Inventory Source - Creates a Sumo Logic Inventory Source used by Root Cause Explorer.
246-
Xray Source - Creates a Sumo Logic AWS X-Ray Source that collects X-Ray Trace Metrics from your AWS account.
247-
Both - Install both Inventory and Xray sources.
248-
None - Skips installation of both sources.
249-
EOT
250-
validation {
251-
condition = contains([
252-
"Inventory Source",
253-
"Xray Source",
254-
"Both",
255-
"None", ], var.collect_rce)
256-
error_message = "The value must be one of \"Inventory Source\", \"Xray Source\", \"Both\" and None."
257-
}
258-
default = "Both"
259-
}
260-
261240
variable "elb_details" {
262241
type = object({
263242
source_name = string

aws-observability-terraform/source-module/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# AWS Observability Sources
22
# 1. Create Common Collector
3-
# 2. Create Common IAM role with permissions for alb and cloudtrail S3 Bucket, cloudwatch metrics, inventory and xray source. -> main_iam_role.tf
3+
# 2. Create Common IAM role with permissions for alb and cloudtrail S3 Bucket, cloudwatch metrics -> main_iam_role.tf
44
# 3. S3 Bucket and SNS Topic and policy -> main_s3_bucket.tf
55

66
resource "random_string" "aws_random" {

aws-observability-terraform/test/sourcemodule/source_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ func TestSourceModule2(t *testing.T) {
175175
})
176176
}
177177

178-
// Testing scenerio 3 - Collect CW Logs via Lambda Log forwarder, CW Metrics via CW metric source & Inventory source
178+
// Testing scenerio 3 - Collect CW Logs via Lambda Log forwarder, CW Metrics via CW metric source
179179
func TestSourceModule3(t *testing.T) {
180180
// t.Parallel()
181181

@@ -367,7 +367,6 @@ func TestSourceModule5(t *testing.T) {
367367
"collect_elb": "false",
368368
"collect_classic_lb": "false",
369369
"collect_cloudtrail": "false",
370-
"collect_rce": "None",
371370
"collect_logs_cloudwatch": "Lambda Log Forwarder",
372371
"auto_enable_logs_tags_filters": "Environment=Production,Application=MyApp,creator=appsTeam",
373372
"collect_metric_cloudwatch": "CloudWatch Metrics Source",
@@ -463,7 +462,6 @@ func TestSourceModule6(t *testing.T) {
463462
"collect_elb": "false",
464463
"collect_classic_lb": "false",
465464
"collect_cloudtrail": "false",
466-
"collect_rce": "None",
467465
"auto_enable_logs_tags_filters": "Environment=Production,Application=MyApp,creator=appsTeam",
468466
}
469467
// Define the variable values

aws-observability/apps/common/resources.template.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1606,7 +1606,7 @@ Outputs:
16061606
Description: "Check If Account is Paid or Not"
16071607
Value: !GetAtt AccountCheck.is_paid
16081608
Namespaces:
1609-
Description: "Comma Delimited String of CloudWatch Metrics Namespaces for Inventory Source."
1609+
Description: "Comma Delimited String of CloudWatch Metrics Namespaces."
16101610
Value: !GetAtt Primerinvoke.namespaces
16111611
KinesisLogsDeliveryStreamARN:
16121612
Description: "The ARN for your Kinesis Firehose Delivery Stream, use this as the destination when adding CloudWatch Logs subscription filters."

aws-observability/apps/gis/gis.template.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
AWSTemplateFormatVersion: '2010-09-09'
22
Transform: 'AWS::Serverless-2016-10-31'
3-
Description: "Version - v2.12.0: Template to setup the Sumo Logic AWS Inventory Source and Root Cause Explorer app."
3+
Description: "Version - v2.12.0: Template to setup the Sumo Logic Global Intelligence for CloudTrail DevOps app."
44

55
Metadata:
66
'AWS::CloudFormation::Interface':

aws-observability/apps/permissionchecker/permissioncheck.nested.template.test.yaml

Lines changed: 1 addition & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ Resources:
211211

212212
################# Create Lambda Role and Lambda Function to create Sumo Logic Custom Resources #################
213213
################# Checks for IAM and Lambda Permissions #################
214-
################# Checks for IAM ROLE - Sumo Source, Inventory Source also #################
214+
################# Checks for IAM ROLE - Sumo Source #################
215215
LambdaRole:
216216
Type: AWS::IAM::Role
217217
Metadata:
@@ -281,79 +281,6 @@ Resources:
281281
Resource:
282282
"*"
283283

284-
RootCauseRole:
285-
Type: AWS::IAM::Role
286-
Metadata:
287-
cfn_nag:
288-
rules_to_suppress:
289-
- id: W11
290-
reason: "Operations are performed across resources."
291-
Properties:
292-
AssumeRolePolicyDocument:
293-
Version: '2012-10-17'
294-
Statement:
295-
- Effect: Allow
296-
Principal:
297-
AWS: arn:aws:iam::246946804217:root
298-
Action: sts:AssumeRole
299-
Condition:
300-
StringEquals:
301-
sts:ExternalId: !Sub "${Section1aSumoLogicDeployment}:${Section1dSumoLogicOrganizationId}"
302-
Path: "/"
303-
Policies:
304-
- PolicyName: SumoInventoryPolicy
305-
PolicyDocument:
306-
Version: '2012-10-17'
307-
Statement:
308-
- Action:
309-
- apigateway:GET
310-
- autoscaling:Describe*
311-
- cloudfront:GetDistributionConfig
312-
- cloudfront:ListDistributions
313-
- cloudtrail:DescribeTrails
314-
- cloudtrail:GetTrailStatus
315-
- cloudwatch:Describe*
316-
- cloudwatch:Get*
317-
- cloudwatch:List*
318-
- codedeploy:List*
319-
- codedeploy:BatchGet*
320-
- dynamodb:Describe*
321-
- dynamodb:List*
322-
- ec2:Describe*
323-
- ecs:Describe*
324-
- ecs:List*
325-
- elasticache:Describe*
326-
- elasticache:List*
327-
- elasticfilesystem:Describe*
328-
- elasticloadbalancing:Describe*
329-
- elasticmapreduce:Describe*
330-
- elasticmapreduce:List*
331-
- es:Describe*
332-
- es:List*
333-
- health:Describe*
334-
- kinesis:Describe*
335-
- kinesis:List*
336-
- lambda:List*
337-
- mq:Describe*
338-
- mq:List*
339-
- rds:Describe*
340-
- rds:List*
341-
- redshift:Describe*
342-
- route53:List*
343-
- sqs:ListQueues
344-
- ses:GetSendStatistics
345-
- ses:GetSendQuota
346-
- sns:List*
347-
- tag:GetResources
348-
- tag:GetTagKeys
349-
- tag:GetTagValues
350-
- xray:BatchGetTraces
351-
- xray:Get*
352-
- pi:DescribeDimensionKeys
353-
- pi:GetResourceMetrics
354-
Effect: Allow
355-
Resource: "*"
356-
357284
LambdaHelper:
358285
Type: 'AWS::Serverless::Function'
359286
Properties:

0 commit comments

Comments
 (0)