Merge pull request #533 from SumoLogic/TRIDENT-18052

TRIDENT-18052: Add InsightConfiguration Field

Author: sumovishal

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 2.23.1 (Unreleased)
 FEATURES:
 * **New Resource:** sumologic_cse_outlier_rule (GH-532)
+* Add new optional `global_signal_suppression_window` field to sumologic_cse_insights_configuration (TRIDENT-18052)
 
 ## 2.23.0 (May 24, 2023)
 FEATURES:

sumologic/resource_sumologic_cse_insights_configuration.go

@@ -26,6 +26,11 @@ func resourceSumologicCSEInsightsConfiguration() *schema.Resource {
 				Optional: true,
 				ForceNew: false,
 			},
+			"global_signal_suppression_window": {
+				Type:     schema.TypeFloat,
+				Optional: true,
+				ForceNew: false,
+			},
 		},
 	}
 }
@@ -49,6 +54,7 @@ func resourceSumologicCSEInsightsConfigurationRead(d *schema.ResourceData, meta
 
 	d.Set("lookback_days", CSEInsightsConfiguration.LookbackDays)
 	d.Set("threshold", CSEInsightsConfiguration.Threshold)
+	d.Set("global_signal_suppression_window", CSEInsightsConfiguration.GlobalSignalSuppressionWindow)
 
 	return nil
 }
@@ -93,9 +99,11 @@ func resourceToCSEInsightsConfiguration(d *schema.ResourceData) (CSEInsightsConf
 
 	lookbackDays := d.Get("lookback_days").(float64)
 	threshold := d.Get("threshold").(float64)
+	globalSignalSuppressionWindow := d.Get("global_signal_suppression_window").(float64)
 
 	return CSEInsightsConfiguration{
-		LookbackDays: &lookbackDays,
-		Threshold:    &threshold,
+		LookbackDays:                  &lookbackDays,
+		Threshold:                     &threshold,
+		GlobalSignalSuppressionWindow: &globalSignalSuppressionWindow,
 	}, nil
 }

sumologic/resource_sumologic_cse_insights_configuration_test.go

@@ -14,17 +14,18 @@ func TestAccSumologicSCEInsightsConfiguration_create(t *testing.T) {
 	var insightConfiguration CSEInsightsConfiguration
 	nLookbackDays := 10.0
 	nThreshold := 13.0
+	nGlobalSignalSuppressionWindow := 48.0
 	resourceName := "sumologic_cse_insights_configuration.insights_configuration"
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCSEInsightsConfigurationDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testCreateCSEInsightsConfigurationConfig(nLookbackDays, nThreshold),
+				Config: testCreateCSEInsightsConfigurationConfig(nLookbackDays, nThreshold, nGlobalSignalSuppressionWindow),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckCSEInsightsConfigurationExists(resourceName, &insightConfiguration),
-					testCheckInsightsConfigurationValues(&insightConfiguration, nLookbackDays, nThreshold),
+					testCheckInsightsConfigurationValues(&insightConfiguration, nLookbackDays, nThreshold, nGlobalSignalSuppressionWindow),
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 				),
 			},
@@ -49,21 +50,22 @@ func testAccCSEInsightsConfigurationDestroy(s *terraform.State) error {
 			return fmt.Errorf("Encountered an error: " + err.Error())
 		}
 		if s != nil {
-			if s.Threshold != nil && s.LookbackDays != nil {
+			if s.Threshold != nil && s.LookbackDays != nil && s.GlobalSignalSuppressionWindow != nil {
 				return fmt.Errorf("insight Configuration still exists")
 			}
 		}
 	}
 	return nil
 }
 
-func testCreateCSEInsightsConfigurationConfig(nLookbackDays float64, nThreshold float64) string {
+func testCreateCSEInsightsConfigurationConfig(nLookbackDays float64, nThreshold float64, nGlobalSignalSuppressionWindow float64) string {
 	return fmt.Sprintf(`
 resource "sumologic_cse_insights_configuration" "insights_configuration" {
 	lookback_days = "%f"
 	threshold = "%f"
+	global_signal_suppression_window = "%f"
 }
-`, nLookbackDays, nThreshold)
+`, nLookbackDays, nThreshold, nGlobalSignalSuppressionWindow)
 }
 
 func testCheckCSEInsightsConfigurationExists(n string, insightConfiguration *CSEInsightsConfiguration) resource.TestCheckFunc {
@@ -89,14 +91,17 @@ func testCheckCSEInsightsConfigurationExists(n string, insightConfiguration *CSE
 	}
 }
 
-func testCheckInsightsConfigurationValues(insightConfiguration *CSEInsightsConfiguration, nLookbackDays float64, nThreshold float64) resource.TestCheckFunc {
+func testCheckInsightsConfigurationValues(insightConfiguration *CSEInsightsConfiguration, nLookbackDays float64, nThreshold float64, nGlobalSignalSuppressionWindow float64) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		if *insightConfiguration.LookbackDays != nLookbackDays {
 			return fmt.Errorf("bad lookback days, expected \"%f\", got: %#v", nLookbackDays, insightConfiguration.LookbackDays)
 		}
 		if *insightConfiguration.Threshold != nThreshold {
 			return fmt.Errorf("bad threshold, expected \"%f\", got: %#v", nThreshold, insightConfiguration.Threshold)
 		}
+		if *insightConfiguration.GlobalSignalSuppressionWindow != nGlobalSignalSuppressionWindow {
+			return fmt.Errorf("bad global signal suppression window, expected \"%f\", got: %#v", nGlobalSignalSuppressionWindow, insightConfiguration.GlobalSignalSuppressionWindow)
+		}
 
 		return nil
 	}

sumologic/sumologic_cse_insights_configuration.go

@@ -44,6 +44,7 @@ type CSEInsightsConfigurationResponse struct {
 }
 
 type CSEInsightsConfiguration struct {
-	LookbackDays *float64 `json:"lookbackDays,omitempty"`
-	Threshold    *float64 `json:"threshold,omitempty"`
+	LookbackDays                  *float64 `json:"lookbackDays,omitempty"`
+	Threshold                     *float64 `json:"threshold,omitempty"`
+	GlobalSignalSuppressionWindow *float64 `json:"globalSignalSuppressionWindow,omitempty"`
 }

website/docs/r/cse_insights_configuration.html.markdown

@@ -13,6 +13,7 @@ Provides the Sumologic CSE Insights Configuration for the whole organization. Th
 resource "sumologic_cse_insights_configuration" "insights_configuration" {
   lookback_days = 13.0
   threshold = 12.0
+  global_signal_suppression_window = 48.0
 }
 ```
 
@@ -22,6 +23,7 @@ The following arguments are supported:
 
 - `lookback_days` - (Optional) Detection window expressed in days.
 - `threshold` - (Optional) Detection threshold activity score.
+- `global_signal_suppression_window` - (Optional) Detection global signal suppression window expressed in hours.
 
 The following attributes are exported: