[Monitors] slo trigger condition parsing

Took 1 minute

Author: Ashish Gaurav

sumologic/resource_sumologic_monitors_library_monitor.go

@@ -468,20 +468,39 @@ var metricsMissingDataTriggerConditionSchema = map[string]*schema.Schema{
 }
 
 var sloSLITriggerConditionSchema = map[string]*schema.Schema{
-	"sli_threshold": {
-		Type:         schema.TypeFloat,
-		Required:     true,
-		ValidateFunc: validation.FloatBetween(0, 100),
-	},
+	"critical": nested(true, schemaMap{
+		"sli_threshold": {
+			Type:         schema.TypeFloat,
+			Required:     true,
+			ValidateFunc: validation.FloatBetween(0, 100),
+		},
+	}),
+	"warning": nested(true, schemaMap{
+		"sli_threshold": {
+			Type:         schema.TypeFloat,
+			Required:     true,
+			ValidateFunc: validation.FloatBetween(0, 100),
+		},
+	}),
 }
 
 var sloBurnRateTriggerConditionSchema = map[string]*schema.Schema{
-	"time_range": &timeRangeSchema,
-	"burn_rate_threshold": {
-		Type:         schema.TypeFloat,
-		Required:     true,
-		ValidateFunc: validation.FloatAtLeast(0),
-	},
+	"critical": nested(true, schemaMap{
+		"time_range": &timeRangeSchema,
+		"burn_rate_threshold": {
+			Type:         schema.TypeFloat,
+			Required:     true,
+			ValidateFunc: validation.FloatAtLeast(0),
+		},
+	}),
+	"warning": nested(true, schemaMap{
+		"time_range": &timeRangeSchema,
+		"burn_rate_threshold": {
+			Type:         schema.TypeFloat,
+			Required:     true,
+			ValidateFunc: validation.FloatAtLeast(0),
+		},
+	}),
 }
 
 var occurrenceTypeSchema = schema.Schema{
@@ -588,6 +607,7 @@ func resourceSumologicMonitorsLibraryMonitorRead(d *schema.ResourceData, meta in
 	d.Set("group_notifications", monitor.GroupNotifications)
 	d.Set("playbook", monitor.Playbook)
 	d.Set("alert_name", monitor.AlertName)
+	d.Set("slo_id", monitor.SloID)
 	// set notifications
 	notifications := make([]interface{}, len(monitor.Notifications))
 	for i, n := range monitor.Notifications {
@@ -804,6 +824,12 @@ func triggerConditionsBlockToJson(block map[string]interface{}) []TriggerConditi
 	if sc, ok := fromSingletonArray(block, metricsMissingDataConditionFieldName); ok {
 		conditions = append(conditions, metricsMissingDataConditionBlockToJson(sc)...)
 	}
+	if sc, ok := fromSingletonArray(block, sloSLIConditionFieldName); ok {
+		conditions = append(conditions, sloSLIConditionBlockToJson(sc)...)
+	}
+	if sc, ok := fromSingletonArray(block, sloBurnRateConditionFieldName); ok {
+		conditions = append(conditions, sloBurnConditionBlockToJson(sc)...)
+	}
 
 	return conditions
 }
@@ -867,7 +893,6 @@ func logsMissingDataConditionBlockToJson(block map[string]interface{}) []Trigger
 	alert := TriggerCondition{
 		TimeRange:       block["time_range"].(string),
 		DetectionMethod: logsMissingDataConditionDetectionMethod,
-		TriggerType:     "MissingData",
 	}
 	resolution := TriggerCondition{
 		TimeRange:       block["time_range"].(string),
@@ -886,6 +911,7 @@ func metricsMissingDataConditionBlockToJson(block map[string]interface{}) []Trig
 		DetectionMethod: metricsMissingDataConditionDetectionMethod,
 		TriggerType:     "MissingData",
 	}
+
 	resolution := TriggerCondition{
 		TimeRange:       block["time_range"].(string),
 		TriggerSource:   block["trigger_source"].(string),
@@ -895,6 +921,22 @@ func metricsMissingDataConditionBlockToJson(block map[string]interface{}) []Trig
 	return []TriggerCondition{alert, resolution}
 }
 
+func sloSLIConditionBlockToJson(block map[string]interface{}) []TriggerCondition {
+	base := TriggerCondition{
+		DetectionMethod: sloSLIConditionDetectionMethod,
+	}
+
+	return base.sloCloneReadingFromNestedBlocks(block)
+}
+
+func sloBurnConditionBlockToJson(block map[string]interface{}) []TriggerCondition {
+	base := TriggerCondition{
+		DetectionMethod: sloBurnRateConditionDetectionMethod,
+	}
+
+	return base.sloCloneReadingFromNestedBlocks(block)
+}
+
 // TriggerCondition JSON model to 'trigger_conditions' block
 func jsonToTriggerConditionsBlock(conditions []TriggerCondition) map[string]interface{} {
 	missingDataConditions := make([]TriggerCondition, 0)
@@ -917,6 +959,10 @@ func jsonToTriggerConditionsBlock(conditions []TriggerCondition) map[string]inte
 			triggerConditionsBlock[logsOutlierConditionFieldName] = toSingletonArray(jsonToLogsOutlierConditionBlock(dataConditions))
 		case metricsOutlierConditionDetectionMethod:
 			triggerConditionsBlock[metricsOutlierConditionFieldName] = toSingletonArray(jsonToMetricsOutlierConditionBlock(dataConditions))
+		case sloSLIConditionDetectionMethod:
+			triggerConditionsBlock[sloSLIConditionFieldName] = toSingletonArray(jsonToSloSliConditionBlock(dataConditions))
+		case sloBurnRateConditionDetectionMethod:
+			triggerConditionsBlock[sloBurnRateConditionFieldName] = toSingletonArray(jsonToSloBurnRateConditionBlock(dataConditions))
 		}
 	}
 	if len(missingDataConditions) > 0 {
@@ -1112,6 +1158,63 @@ func jsonToMetricsOutlierConditionBlock(conditions []TriggerCondition) map[strin
 	return block
 }
 
+func jsonToSloSliConditionBlock(conditions []TriggerCondition) map[string]interface{} {
+	var criticalAlrt, warningAlrt = dict{}, dict{}
+	block := map[string]interface{}{}
+
+	block["critical"] = toSingletonArray(criticalAlrt)
+	block["warning"] = toSingletonArray(warningAlrt)
+
+	var hasCritical, hasWarning = false, false
+	for _, condition := range conditions {
+		switch condition.TriggerType {
+		case "Critical":
+			hasCritical = true
+			criticalAlrt["sli_threshold"] = condition.SLIThreshold
+		case "Warning":
+			hasWarning = true
+			warningAlrt["sli_threshold"] = condition.SLIThreshold
+		}
+	}
+	if !hasCritical {
+		delete(block, "critical")
+	}
+	if !hasWarning {
+		delete(block, "warning")
+	}
+	return block
+}
+
+func jsonToSloBurnRateConditionBlock(conditions []TriggerCondition) map[string]interface{} {
+
+	var criticalAlrt, warningAlrt = dict{}, dict{}
+	block := map[string]interface{}{}
+
+	block["critical"] = toSingletonArray(criticalAlrt)
+	block["warning"] = toSingletonArray(warningAlrt)
+
+	var hasCritical, hasWarning = false, false
+	for _, condition := range conditions {
+		switch condition.TriggerType {
+		case "Critical":
+			hasCritical = true
+			criticalAlrt["time_range"] = condition.TimeRange
+			criticalAlrt["burn_rate_threshold"] = condition.BurnRateThreshold
+		case "Warning":
+			hasWarning = true
+			warningAlrt["time_range"] = condition.TimeRange
+			warningAlrt["burn_rate_threshold"] = condition.BurnRateThreshold
+		}
+	}
+	if !hasCritical {
+		delete(block, "critical")
+	}
+	if !hasWarning {
+		delete(block, "warning")
+	}
+	return block
+}
+
 func jsonToLogsMissingDataConditionBlock(conditions []TriggerCondition) map[string]interface{} {
 	block := map[string]interface{}{}
 	firstCondition := conditions[0]
@@ -1193,6 +1296,7 @@ func resourceToMonitorsLibraryMonitor(d *schema.ResourceData) MonitorsLibraryMon
 		GroupNotifications: d.Get("group_notifications").(bool),
 		Playbook:           d.Get("playbook").(string),
 		AlertName:          d.Get("alert_name").(string),
+		SloID:              d.Get("slo_id").(string),
 	}
 }
 
@@ -1256,6 +1360,10 @@ func (condition *TriggerCondition) readFrom(block map[string]interface{}) {
 			condition.Consecutive = v.(int)
 		case "direction":
 			condition.Direction = v.(string)
+		case "sli_threshold":
+			condition.SLIThreshold = v.(float64)
+		case "burn_rate_threshold":
+			condition.BurnRateThreshold = v.(float64)
 		default:
 		}
 	}
@@ -1313,6 +1421,24 @@ func (base TriggerCondition) cloneReadingFromNestedBlocks(block map[string]inter
 	return conditions
 }
 
+// adapted version of cloneReadingFromNestedBlocks for slo conditions
+func (base TriggerCondition) sloCloneReadingFromNestedBlocks(block map[string]interface{}) []TriggerCondition {
+	var conditions = []TriggerCondition{}
+	var criticalCondition, warningCondition = base, base
+	criticalCondition.TriggerType = "Critical"
+	warningCondition.TriggerType = "Warning"
+
+	if critical, ok := fromSingletonArray(block, "critical"); ok {
+		criticalCondition.readFrom(critical)
+		conditions = append(conditions, criticalCondition)
+	}
+	if warning, ok := fromSingletonArray(block, "warning"); ok {
+		warningCondition.readFrom(warning)
+		conditions = append(conditions, warningCondition)
+	}
+	return conditions
+}
+
 func toSingletonArray(m map[string]interface{}) []map[string]interface{} {
 	return []map[string]interface{}{m}
 }

sumologic/sumologic_monitors_library_monitor.go

@@ -139,6 +139,7 @@ type MonitorsLibraryMonitor struct {
 	GroupNotifications bool                  `json:"groupNotifications"`
 	Playbook           string                `json:"playbook,omitempty"`
 	AlertName          string                `json:"alertName,omitempty"`
+	SloID              string                `json:"sloId,omitempty"`
 }
 
 type MonitorQuery struct {