address missing comments from GH-274 and GH-281

Author: Pedro Montiel

CHANGELOG.md

@@ -1,11 +1,15 @@
 ## 2.11.0 (Unreleased)
+
+* Address missing feedback from GH-274 and GH-281 (GH-285)
+
 FEATURES:
 
 * **New Resource:** sumologic_cse_rule_tuning_expression (GH-281)
 * **New Resource:** sumologic_cse_insights_resolution (GH-274)
 * **New Resource:** sumologic_cse_insights_status (GH-274)
 * **New Resource:** sumologic_cse_insights_configuration (GH-274)
 
+
 ## 2.10.0 (September 22, 2021)
 
 * Add a provider option `admin_mode`

sumologic/resource_sumologic_cse_rule_tuning_expression.go

@@ -19,37 +19,30 @@ func resourceSumologicCSERuleTuningExpression() *schema.Resource {
 			"description": {
 				Type:     schema.TypeString,
 				Required: true,
-				ForceNew: false,
 			},
 			"name": {
 				Type:     schema.TypeString,
 				Required: true,
-				ForceNew: false,
 			},
 			"expression": {
 				Type:     schema.TypeString,
 				Required: true,
-				ForceNew: false,
 			},
 			"enabled": {
 				Type:     schema.TypeBool,
 				Required: true,
-				ForceNew: false,
 			},
 			"exclude": {
 				Type:     schema.TypeBool,
 				Required: true,
-				ForceNew: false,
 			},
 			"is_global": {
 				Type:     schema.TypeBool,
 				Required: true,
-				ForceNew: false,
 			},
 			"rule_ids": {
 				Type:     schema.TypeList,
 				Required: true,
-				ForceNew: false,
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
 				},
@@ -115,7 +108,7 @@ func resourceSumologicCSERuleTuningExpressionCreate(d *schema.ResourceData, meta
 		d.SetId(id)
 	}
 
-	return resourceSumologicCSERuleTuningExpressionUpdate(d, meta)
+	return resourceSumologicCSERuleTuningExpressionRead(d, meta)
 }
 
 func resourceSumologicCSERuleTuningExpressionUpdate(d *schema.ResourceData, meta interface{}) error {

sumologic/sumologic_client.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"io"
 	"io/ioutil"
+	"log"
 	"net/http"
 	"net/url"
 	"time"
@@ -28,15 +29,16 @@ type Client struct {
 var ProviderVersion string
 
 var endpoints = map[string]string{
-	"us1": "https://api.sumologic.com/api/",
-	"us2": "https://api.us2.sumologic.com/api/",
-	"fed": "https://api.fed.sumologic.com/api/",
-	"eu":  "https://api.eu.sumologic.com/api/",
-	"au":  "https://api.au.sumologic.com/api/",
-	"de":  "https://api.de.sumologic.com/api/",
-	"jp":  "https://api.jp.sumologic.com/api/",
-	"ca":  "https://api.ca.sumologic.com/api/",
-	"in":  "https://api.in.sumologic.com/api/",
+	"us1":  "https://api.sumologic.com/api/",
+	"us2":  "https://api.us2.sumologic.com/api/",
+	"fed":  "https://api.fed.sumologic.com/api/",
+	"eu":   "https://api.eu.sumologic.com/api/",
+	"au":   "https://api.au.sumologic.com/api/",
+	"de":   "https://api.de.sumologic.com/api/",
+	"jp":   "https://api.jp.sumologic.com/api/",
+	"ca":   "https://api.ca.sumologic.com/api/",
+	"in":   "https://api.in.sumologic.com/api/",
+	"nite": "https://nite-api.sumologic.net/api/",
 }
 
 var rateLimiter = time.NewTicker(time.Minute / 240)
@@ -132,8 +134,10 @@ func (s *Client) GetWithCookies(urlPath string, cookies []*http.Cookie) ([]byte,
 func (s *Client) Post(urlPath string, payload interface{}) ([]byte, error) {
 	relativeURL, _ := url.Parse(urlPath)
 	sumoURL := s.BaseURL.ResolveReference(relativeURL)
-
+	log.Printf("[INFO] Post URL: %s", sumoURL)
 	body, _ := json.Marshal(payload)
+
+	log.Printf("[INFO] POST body: %s", body)
 	req, err := createNewRequest(http.MethodPost, sumoURL.String(), bytes.NewBuffer(body), s.AccessID, s.AccessKey)
 	if err != nil {
 		return nil, err
@@ -189,10 +193,12 @@ func (s *Client) PostRawPayload(urlPath string, payload string) ([]byte, error)
 func (s *Client) Put(urlPath string, payload interface{}) ([]byte, error) {
 	relativeURL, _ := url.Parse(urlPath)
 	sumoURL := s.BaseURL.ResolveReference(relativeURL)
-
+	log.Printf("[INFO] Put URL: %s", sumoURL)
 	_, etag, _ := s.Get(sumoURL.String())
 
 	body, _ := json.Marshal(payload)
+
+	log.Printf("[INFO] PUT body: %s", body)
 	req, err := createNewRequest(http.MethodPut, sumoURL.String(), bytes.NewBuffer(body), s.AccessID, s.AccessKey)
 	if err != nil {
 		return nil, err
@@ -225,7 +231,7 @@ func (s *Client) Put(urlPath string, payload interface{}) ([]byte, error) {
 func (s *Client) Get(urlPath string) ([]byte, string, error) {
 	relativeURL, _ := url.Parse(urlPath)
 	sumoURL := s.BaseURL.ResolveReference(relativeURL)
-
+	log.Printf("[INFO] Get URL: %s", sumoURL)
 	req, err := createNewRequest(http.MethodGet, sumoURL.String(), nil, s.AccessID, s.AccessKey)
 	if err != nil {
 		return nil, "", err
@@ -246,7 +252,7 @@ func (s *Client) Get(urlPath string) ([]byte, string, error) {
 	if err != nil {
 		return nil, "", err
 	}
-
+	log.Printf("[INFO] Get response: %s", string(d))
 	if resp.StatusCode == 404 {
 		return nil, "", nil
 	} else if resp.StatusCode >= 400 {
@@ -259,7 +265,7 @@ func (s *Client) Get(urlPath string) ([]byte, string, error) {
 func (s *Client) Delete(urlPath string) ([]byte, error) {
 	relativeURL, _ := url.Parse(urlPath)
 	sumoURL := s.BaseURL.ResolveReference(relativeURL)
-
+	log.Printf("[INFO] Delete URL: %s", sumoURL)
 	req, err := createNewRequest(http.MethodDelete, sumoURL.String(), nil, s.AccessID, s.AccessKey)
 	if err != nil {
 		return nil, err

website/docs/r/cse_insights_configuration.html.markdown

@@ -29,7 +29,10 @@ The following attributes are exported:
 
 ## Import
 
-Insights Configuration can be imported using the field id, e.g.:
+Insights Configuration can be imported using the id `cse-insights-configuration`:
+
+~> **NOTE:** Only `cse-insights-configuration` id should be used when importing hte insights configuration. Using any other id may have unintended consequences.
+
 ```hcl
-terraform import sumologic_cse_insights_configuration.insights_configuration ID
+terraform import sumologic_cse_insights_configuration.insights_configuration cse-insights-configuration
 ```