Merge pull request #223 from SumoLogic/avijit-monitors-schema-validations

Added validation for threshold_type

Author: kumar-avijit

sumologic/resource_sumologic_monitors_library_monitor.go

@@ -5,6 +5,7 @@ import (
 	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 )
 
 func resourceSumologicMonitorsLibraryMonitor() *schema.Resource {
@@ -90,30 +91,36 @@ func resourceSumologicMonitorsLibraryMonitor() *schema.Resource {
 						"trigger_type": {
 							Type:     schema.TypeString,
 							Optional: true,
+							ValidateFunc: validation.StringInSlice([]string{"Critical","Warning","MissingData","ResolvedCritical","ResolvedWarning","ResolvedMissingData"}, false),
 						},
 						"threshold": {
 							Type:     schema.TypeFloat,
 							Optional: true,
 						},
 						"threshold_type": {
-							Type:     schema.TypeString,
-							Optional: true,
+							Type:         schema.TypeString,
+							Optional:     true,
+							ValidateFunc: validation.StringInSlice([]string{"LessThan", "LessThanOrEqual", "GreaterThan", "GreaterThanOrEqual"}, false),
 						},
 						"time_range": {
 							Type:     schema.TypeString,
 							Optional: true,
+							ValidateFunc: validation.StringInSlice([]string{"5m","10m","15m","30m","60m","1h","3h","6h","12h","24h","1d"}, false),
 						},
 						"trigger_source": {
 							Type:     schema.TypeString,
 							Optional: true,
+							ValidateFunc: validation.StringInSlice([]string{"AllTimeSeries","AnyTimeSeries","AllResults"}, false),
 						},
 						"occurrence_type": {
 							Type:     schema.TypeString,
 							Optional: true,
+							ValidateFunc: validation.StringInSlice([]string{"AtLeastOnce","Always","ResultCount","MissingData"}, false),
 						},
 						"detection_method": {
 							Type:     schema.TypeString,
 							Optional: true,
+							ValidateFunc: validation.StringInSlice([]string{"StaticCondition","LogsStaticCondition","MetricsStaticCondition","LogsOutlierCondition","MetricsOutlierCondition","LogsMissingDataCondition","MetricsMissingDataCondition"}, false),
 						},
 					},
 				},
@@ -142,6 +149,7 @@ func resourceSumologicMonitorsLibraryMonitor() *schema.Resource {
 										Type:     schema.TypeString,
 										Optional: true,
 										Computed: true,
+										ValidateFunc: validation.StringInSlice([]string{"Email","AWSLambda","AzureFunctions","Datadog","HipChat","Jira","NewRelic","Opsgenie","PagerDuty","Slack","MicrosoftTeams","Webhook"}, false),
 									},
 									"subject": {
 										Type:     schema.TypeString,
@@ -198,6 +206,7 @@ func resourceSumologicMonitorsLibraryMonitor() *schema.Resource {
 			"monitor_type": {
 				Type:     schema.TypeString,
 				Required: true,
+				ValidateFunc: validation.StringInSlice([]string{"Logs", "Metrics"}, false),
 			},
 
 			"is_locked": {
@@ -223,6 +232,7 @@ func resourceSumologicMonitorsLibraryMonitor() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				Default:  "MonitorsLibraryMonitor",
+				ValidateFunc: validation.StringInSlice([]string{"MonitorsLibraryMonitor", "MonitorsLibraryFolder"}, false),
 			},
 
 			"modified_by": {

sumologic/resource_sumologic_monitors_library_monitor_test.go

@@ -2,6 +2,7 @@ package sumologic
 
 import (
 	"fmt"
+	"regexp"
 	"strconv"
 	"strings"
 	"testing"
@@ -11,6 +12,31 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
+func TestAccSumologicMonitorsLibraryMonitor_schemaValidations(t *testing.T) {
+	var monitorsLibraryMonitor MonitorsLibraryMonitor
+	config := `
+       resource "sumologic_monitor" "test" { 
+         name = "test"
+         type = "MonitorsLibraryMonitor"
+         monitor_type = "Logs"
+         triggers {
+           threshold_type = "foo"
+         }
+       }`
+	expectedError := regexp.MustCompile(".*expected triggers.0.threshold_type to be one of \\[LessThan LessThanOrEqual GreaterThan GreaterThanOrEqual\\], got foo.*")
+	resource.Test(t, resource.TestCase{
+		Providers: testAccProviders,
+		CheckDestroy: testAccCheckMonitorsLibraryMonitorDestroy(monitorsLibraryMonitor),
+		Steps: []resource.TestStep{
+			{
+				Config:      config,
+				PlanOnly:    true,
+				ExpectError: expectedError,
+			},
+		},
+	})
+}
+
 func TestAccSumologicMonitorsLibraryMonitor_basic(t *testing.T) {
 	var monitorsLibraryMonitor MonitorsLibraryMonitor
 	testNameSuffix := acctest.RandString(16)