Skip to content

Commit 1a3682e

Browse files
authored
Merge pull request #73 from SumoLogic/apoorv-fix-nil-cast
fix nil interface unchecked cast
2 parents 858ad6a + 62f1b71 commit 1a3682e

File tree

1 file changed

+15
-9
lines changed

1 file changed

+15
-9
lines changed

sumologic/resource_sumologic_generic_polling_source.go

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -335,15 +335,19 @@ func getPollingPathSettings(d *schema.ResourceData) (PollingPath, error) {
335335
case "CloudWatchPath", "AwsInventoryPath":
336336
pathSettings.Type = pathType
337337
rawLimitToRegions := path["limit_to_regions"].([]interface{})
338-
LimitToRegions := make([]string, len(rawLimitToRegions))
339-
for i, v := range rawLimitToRegions {
340-
LimitToRegions[i] = v.(string)
338+
LimitToRegions := make([]string, 0, len(rawLimitToRegions))
339+
for _, v := range rawLimitToRegions {
340+
if v != nil {
341+
LimitToRegions = append(LimitToRegions, v.(string))
342+
}
341343
}
342344

343345
rawLimitToNamespaces := path["limit_to_namespaces"].([]interface{})
344-
LimitToNamespaces := make([]string, len(rawLimitToNamespaces))
345-
for i, v := range rawLimitToNamespaces {
346-
LimitToNamespaces[i] = v.(string)
346+
LimitToNamespaces := make([]string, 0, len(rawLimitToNamespaces))
347+
for _, v := range rawLimitToNamespaces {
348+
if v != nil {
349+
LimitToNamespaces = append(LimitToNamespaces, v.(string))
350+
}
347351
}
348352
pathSettings.LimitToRegions = LimitToRegions
349353
pathSettings.LimitToNamespaces = LimitToNamespaces
@@ -353,9 +357,11 @@ func getPollingPathSettings(d *schema.ResourceData) (PollingPath, error) {
353357
case "AwsXRayPath":
354358
pathSettings.Type = "AwsXRayPath"
355359
rawLimitToRegions := path["limit_to_regions"].([]interface{})
356-
LimitToRegions := make([]string, len(rawLimitToRegions))
357-
for i, v := range rawLimitToRegions {
358-
LimitToRegions[i] = v.(string)
360+
LimitToRegions := make([]string, 0, len(rawLimitToRegions))
361+
for _, v := range rawLimitToRegions {
362+
if v != nil {
363+
LimitToRegions = append(LimitToRegions, v.(string))
364+
}
359365
}
360366
pathSettings.LimitToRegions = LimitToRegions
361367
default:

0 commit comments

Comments
 (0)