including review feedback

Author: Pedro Montiel

sumologic/resource_sumologic_cse_insights_configuration.go

@@ -98,9 +98,11 @@ func resourceToCSEInsightsConfiguration(d *schema.ResourceData) (CSEInsightsConf
 		return CSEInsightsConfiguration{}, nil
 	}
 
-	return CSEInsightsConfiguration{
+	lookbackDays := d.Get("lookback_days").(float64)
+	threshold := d.Get("threshold").(float64)
 
-		LookbackDays: d.Get("lookback_days").(float64),
-		Threshold:    d.Get("threshold").(float64),
+	return CSEInsightsConfiguration{
+		LookbackDays: &lookbackDays,
+		Threshold:    &threshold,
 	}, nil
 }

sumologic/resource_sumologic_cse_insights_configuration_test.go

@@ -47,7 +47,7 @@ func testAccCSEInsightsConfigurationDestroy(s *terraform.State) error {
 			return fmt.Errorf("Encountered an error: " + err.Error())
 		}
 		if s != nil {
-			if s.Threshold != 0 && s.LookbackDays != 0 {
+			if s.Threshold != nil && s.LookbackDays != nil {
 				return fmt.Errorf("insight Configuration still exists")
 			}
 		}
@@ -89,10 +89,10 @@ func testCheckCSEInsightsConfigurationExists(n string, insightConfiguration *CSE
 
 func testCheckInsightsConfigurationValues(insightConfiguration *CSEInsightsConfiguration, nLookbackDays float64, nThreshold float64) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
-		if insightConfiguration.LookbackDays != nLookbackDays {
+		if *insightConfiguration.LookbackDays != nLookbackDays {
 			return fmt.Errorf("bad lookback days, expected \"%f\", got: %#v", nLookbackDays, insightConfiguration.LookbackDays)
 		}
-		if insightConfiguration.Threshold != nThreshold {
+		if *insightConfiguration.Threshold != nThreshold {
 			return fmt.Errorf("bad threshold, expected \"%f\", got: %#v", nThreshold, insightConfiguration.Threshold)
 		}
 

sumologic/sumologic_cse_insights_configuration.go

@@ -44,6 +44,6 @@ type CSEInsightsConfigurationResponse struct {
 }
 
 type CSEInsightsConfiguration struct {
-	LookbackDays float64 `json:"lookbackDays,omitempty"`
-	Threshold    float64 `json:"threshold,omitempty"`
+	LookbackDays *float64 `json:"lookbackDays,omitempty"`
+	Threshold    *float64 `json:"threshold,omitempty"`
 }

website/docs/r/cse_insights_configuration.html.markdown

@@ -2,7 +2,7 @@
 layout: "sumologic"
 page_title: "SumoLogic: sumologic_cse_insights_configuration"
 description: |-
-  Provides a CSE Insights Configuration
+    Provides the CSE Insights Configuration for the whole organization. There can be only one configuration per organization.
 ---
 
 # sumologic_cse_insights_configuration