Merge pull request #381 from SumoLogic/agrv-slo-docs

[SLO] fix allowed value for compliance window size

Author: agaurav

sumologic/resource_sumologic_slo.go

@@ -211,6 +211,7 @@ func resourceSumologicSLO() *schema.Resource {
 							Type:     schema.TypeString,
 							Required: true,
 							ValidateFunc: validation.StringInSlice([]string{
+								"Week", "Month", "Quarter",
 								"1d", "2d", "3d", "4d", "5d", "6d", "7d", "8d", "9d", "10d", "11d", "12d", "13d", "14d",
 							}, false),
 						},
@@ -519,15 +520,25 @@ func getSLOCompliance(d *schema.ResourceData) *SLOCompliance {
 	complianceType := complianceDict["compliance_type"].(string)
 
 	startFrom := ""
-	if complianceType == "Calendar" && complianceDict["start_from"] != nil {
-		startFrom = complianceDict["start_from"].(string)
+	windowType := ""
+	size := complianceDict["size"].(string)
+
+	if complianceType == "Calendar" {
+		// field windowType needs to be specified instead of `size` for calendar compliance
+		windowType = size
+		size = ""
+
+		if complianceDict["start_from"] != nil {
+			startFrom = complianceDict["start_from"].(string)
+		}
 	}
 
 	return &SLOCompliance{
 		ComplianceType: complianceType,
 		Target:         complianceDict["target"].(float64),
 		Timezone:       complianceDict["timezone"].(string),
-		Size:           complianceDict["size"].(string),
+		Size:           size,
+		WindowType:     windowType,
 		StartFrom:      startFrom,
 	}
 }

website/docs/r/slo.html.markdown

@@ -97,16 +97,17 @@ The following arguments are supported:
     - `target` - (Required) The target value to use, must be a number between 0 and 100.
     - `timezone` - (Required) Time zone for the SLO compliance. Follow the format in the [IANA Time Zone Database][3].
     - `size` - (Required) The size of the compliance period to use.
-      For `Calendar` compliance type the allowed values are `Week`, `Month`, `Quarter`.
-    - `start_from` - (Optional) Start of the calendar window. For week, it would be the day of the week (for e.g Sunday,
-      Monday etc). For month, it will always be the first day of the month. For quarter, it would be the first month of
-      the quarter (for e.g January, February etc.)
-    - `indicator` - (Required) The service level indicator on which SLO is to be defined. more details on the difference
-      b/w them can be found on
-      the [slo help page](https://help.sumologic.com/Beta/SLO_Reliability_Management/Access_and_Create_SLOs)
-        - [window_based_evaluation](#window_based_evaluation) - Evaluate SLI using successful/total windows.
-        - [request_based_evaluation](#request_based_evaluation) - Evaluate SLI based on occurrence of successful
-          events / total events over entire compliance period.
+      - For `Rolling` compliance type it must be a multiple of days e.g. `1d`, `2d`.
+      - For `Calendar` compliance type the allowed values are `Week`, `Month`, `Quarter`.
+    - `start_from` - Start of the calendar window. For `Week` its required and it would be the day of the week (for e.g. Sunday,
+      Monday etc).  For `Quarter` its required, it would be the first month of the start of quarter (for e.g. January, February etc.). 
+      For `Month` it's not required and is set to first day of the month.
+- `indicator` - (Required) The service level indicator on which SLO is to be defined. more details on the difference
+  b/w them can be found on
+  the [slo help page](https://help.sumologic.com/Beta/SLO_Reliability_Management/Access_and_Create_SLOs)
+    - [window_based_evaluation](#window_based_evaluation) - Evaluate SLI using successful/total windows.
+    - [request_based_evaluation](#request_based_evaluation) - Evaluate SLI based on occurrence of successful
+      events / total events over entire compliance period.
 
 #### window_based_evaluation