SUMO-168729: Add entity id as part of saml resource (#236)

* SUMO-168729: Add entity id as part of saml response

* SUMO-168729: formatting

* SUMO-168729: Modifying text related to entity id

* SUMO-168729: Modifying changelog to include entity id info as part of terraform release

Author: Srujana-Srujana

CHANGELOG.md

@@ -6,6 +6,10 @@ BUG FIXES:
 * seperated docs for sumologic_monitor_folder from docs for sumologic_monitor.
 * resource/sumologic_monitor: Fixed docs for `trigger_conditions`.
 
+FEATURES:
+
+* Adding "entityId" as part of SAML API response object.
+
 ## 2.9.8 (July 30, 2021)
 
 FEATURES:

sumologic/resource_sumologic_saml_configuration.go

@@ -110,6 +110,10 @@ func resourceSumologicSamlConfiguration() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+			"entity_id": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
 		},
 	}
 }
@@ -211,6 +215,7 @@ func setSamlConfiguration(d *schema.ResourceData, samlConfiguration *SamlConfigu
 	d.Set("disable_requested_authn_context", samlConfiguration.DisableRequestedAuthnContext)
 	d.Set("is_redirect_binding", samlConfiguration.IsRedirectBinding)
 	d.Set("assertion_consumer_url", samlConfiguration.AssertionConsumerUrl)
+	d.Set("entity_id", samlConfiguration.EntityId)
 
 	d.Set("certificate", samlConfiguration.Certificate)
 }

sumologic/resource_sumologic_saml_configuration_test.go

@@ -216,6 +216,10 @@ func testAccCheckSamlConfigurationExists(name string) resource.TestCheckFunc {
 		if strings.EqualFold(assertion_consumer_url, "") {
 			return fmt.Errorf("Assertion Consumer URL not found for Saml Configuration (id=%s)", id)
 		}
+		entity_id := rs.Primary.Attributes["entity_id"]
+		if strings.EqualFold(entity_id, "") {
+			return fmt.Errorf("Entity Id not set for Saml Configuration (id=%s)", id)
+		}
 		return nil
 	}
 }

sumologic/sumologic_saml_configuration.go

@@ -87,4 +87,5 @@ type SamlConfiguration struct {
 	Certificate                  string                       `json:"certificate,omitempty"`
 	ID                           string                       `json:"id,omitempty"`
 	AssertionConsumerUrl         string                       `json:"assertionConsumerUrl,omitempty"`
+	EntityId                     string                       `json:"entityId,omitempty"`
 }

website/docs/r/saml_configuration.html.markdown

@@ -69,6 +69,7 @@ The following attributes are exported:
 - `id` - Unique identifier for the SAML Configuration.
 - `certificate` - Authentication Request Signing Certificate for the user.
 - `assertion_consumer_url` - The URL on Sumo Logic where the IdP will redirect to with its authentication response.
+- `entity_id` - A unique identifier that is the intended audience of the SAML assertion.
 
 ## Import
 SAML Configuration can be imported using the SAML configuration id, e.g.: