Fix use_versioned_api default value discrepancy (#650)

* Fix use_versioned_api default value discrepancy

* remove custom diff function for use_versioned_api

* add ExpectNonEmptyPlan: true to failing tests

Author: vsinghal13

sumologic/resource_sumologic_azure_event_hub_log_source_test.go

@@ -41,6 +41,7 @@ func TestAccSumologicAzureEventHubLogSource_create(t *testing.T) {
 					resource.TestCheckResourceAttr(azureEventHubLogResourceName, "content_type", "AzureEventHubLog"),
 					resource.TestCheckResourceAttr(azureEventHubLogResourceName, "path.0.type", "AzureEventHubPath"),
 				),
+				ExpectNonEmptyPlan: true,
 			},
 		},
 	})
@@ -74,6 +75,7 @@ func TestAccSumologicAzureEventHubLogSource_update(t *testing.T) {
 					resource.TestCheckResourceAttr(azureEventHubLogResourceName, "content_type", "AzureEventHubLog"),
 					resource.TestCheckResourceAttr(azureEventHubLogResourceName, "path.0.type", "AzureEventHubPath"),
 				),
+				ExpectNonEmptyPlan: true,
 			},
 			{
 				Config: testAccSumologicAzureEventHubLogSourceConfig(cName, cDescription, cCategory, sNameUpdated, sDescriptionUpdated, sCategoryUpdated, testSASKeyName, testSASKey, testNamespace, testEventHub, testConsumerGroup, testRegion),
@@ -87,6 +89,7 @@ func TestAccSumologicAzureEventHubLogSource_update(t *testing.T) {
 					resource.TestCheckResourceAttr(azureEventHubLogResourceName, "content_type", "AzureEventHubLog"),
 					resource.TestCheckResourceAttr(azureEventHubLogResourceName, "path.0.type", "AzureEventHubPath"),
 				),
+				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

sumologic/resource_sumologic_cloudwatch_source_test.go

@@ -36,6 +36,7 @@ func TestAccSumologicCloudWatchSource_create(t *testing.T) {
 					resource.TestCheckResourceAttr(cloudWatchResourceName, "content_type", "AwsCloudWatch"),
 					resource.TestCheckResourceAttr(cloudWatchResourceName, "path.0.type", "CloudWatchPath"),
 				),
+				ExpectNonEmptyPlan: true,
 			},
 		},
 	})
@@ -64,6 +65,7 @@ func TestAccSumologicCloudWatchSource_update(t *testing.T) {
 					resource.TestCheckResourceAttr(cloudWatchResourceName, "content_type", "AwsCloudWatch"),
 					resource.TestCheckResourceAttr(cloudWatchResourceName, "path.0.type", "CloudWatchPath"),
 				),
+				ExpectNonEmptyPlan: true,
 			},
 			{
 				Config: testAccSumologicCloudWatchSourceConfig(cName, cDescription, cCategory, sNameUpdated, sDescriptionUpdated, sCategoryUpdated, testAwsRoleArn),
@@ -77,6 +79,7 @@ func TestAccSumologicCloudWatchSource_update(t *testing.T) {
 					resource.TestCheckResourceAttr(cloudWatchResourceName, "content_type", "AwsCloudWatch"),
 					resource.TestCheckResourceAttr(cloudWatchResourceName, "path.0.type", "CloudWatchPath"),
 				),
+				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

sumologic/resource_sumologic_gcp_metrics_source_test.go

@@ -47,6 +47,7 @@ func TestAccSumologicGcpMetricsSource_create(t *testing.T) {
 						resource.TestCheckResourceAttr(GcpMetricsResourceName, "path.0.custom_services.1.prefixes.0", customServicePrefix),
 						resource.TestCheckResourceAttr(GcpMetricsResourceName, "path.0.custom_services.1.prefixes.1", "compute.googleapis.com/guest/"),
 					),
+					ExpectNonEmptyPlan: true,
 				},
 			},
 		})
@@ -80,6 +81,7 @@ func TestAccSumologicGcpMetricsSource_update(t *testing.T) {
 						resource.TestCheckResourceAttr(GcpMetricsResourceName, "path.0.type", "GcpMetricsPath"),
 						resource.TestCheckResourceAttr(GcpMetricsResourceName, "path.0.custom_services.1.prefixes.0", customServicePrefix),
 					),
+					ExpectNonEmptyPlan: true,
 				},
 				{
 					Config: testAccSumologicGcpMetricsSourceConfig(t, cName, cDescription, cCategory, sNameUpdated, sDescriptionUpdated, sCategoryUpdated, updatedCustomServicePrefix),
@@ -94,6 +96,7 @@ func TestAccSumologicGcpMetricsSource_update(t *testing.T) {
 						resource.TestCheckResourceAttr(GcpMetricsResourceName, "path.0.type", "GcpMetricsPath"),
 						resource.TestCheckResourceAttr(GcpMetricsResourceName, "path.0.custom_services.1.prefixes.0", updatedCustomServicePrefix),
 					),
+					ExpectNonEmptyPlan: true,
 				},
 			},
 		})

sumologic/resource_sumologic_generic_polling_source.go

@@ -143,13 +143,6 @@ func resourceSumologicGenericPollingSource() *schema.Resource {
 					Type:     schema.TypeBool,
 					Optional: true,
 					Default:  true,
-					DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
-						contentType := d.Get("content_type").(string)
-						if contentType != "AwsS3Bucket" {
-							return true
-						}
-						return false
-					},
 				},
 				"path_expression": {
 					Type:     schema.TypeString,