SUMO-226102:updated based on feedback

Author: jxie418

CHANGELOG.md

@@ -1,6 +1,6 @@
 ## 2.25.1 (Unreleased)
 FEATURES:
-* **New Resource:** sumologic_muting_schedule
+* **New Resource:** sumologic_muting_schedule (GH-569)
 * resource/sumologic_monitor: Added support for associating tags with a Monitor.
 
 ## 2.25.0 (August 8, 2023)

sumologic/resource_sumologic_muting_schedules_library_muting_schedule.go

@@ -134,10 +134,6 @@ func getScheduleDefinitionSchemma() map[string]*schema.Schema {
 			Type:     schema.TypeString,
 			Optional: true,
 		},
-		"is_form": {
-			Type:     schema.TypeBool,
-			Optional: true,
-		},
 	}
 }
 
@@ -254,7 +250,6 @@ func resourceSumologicMutingSchedulesLibraryMutingScheduleRead(d *schema.Resourc
 		"start_time": mutingSchedule.Schedule.StartTime,
 		"duration":   mutingSchedule.Schedule.Duration,
 		"rrule":      mutingSchedule.Schedule.RRule,
-		"is_form":    mutingSchedule.Schedule.IsForm,
 	}
 
 	d.Set("created_by", mutingSchedule.CreatedBy)
@@ -320,7 +315,6 @@ func getScheduleDefinition(d *schema.ResourceData) ScheduleDefinition {
 		StartTime: scheduleDefinitionDict["start_time"].(string),
 		Duration:  scheduleDefinitionDict["duration"].(int),
 		RRule:     scheduleDefinitionDict["rrule"].(string),
-		IsForm:    scheduleDefinitionDict["is_form"].(bool),
 	}
 	return scheduleDefinition
 }

sumologic/resource_sumologic_muting_schedules_library_muting_schedule_test.go

@@ -74,7 +74,6 @@ func TestAccSumologicMutingSchedulesLibraryMutingSchedule_create(t *testing.T) {
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.start_date", testSchedule.StartDate),
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.start_time", testSchedule.StartTime),
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.rrule", testSchedule.RRule),
-					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.is_form", strconv.FormatBool(testSchedule.IsForm)),
 				),
 			},
 		},
@@ -138,7 +137,6 @@ func TestAccSumologicMutingSchedulesLibraryMutingSchedule_update(t *testing.T) {
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.start_date", testSchedule.StartDate),
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.start_time", testSchedule.StartTime),
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.rrule", testSchedule.RRule),
-					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.is_form", strconv.FormatBool(testSchedule.IsForm)),
 				),
 			},
 			{
@@ -154,7 +152,6 @@ func TestAccSumologicMutingSchedulesLibraryMutingSchedule_update(t *testing.T) {
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.start_time", testUpdateSchedule.StartTime),
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.duration", strconv.FormatInt((int64)(testUpdateSchedule.Duration), 10)),
 					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.rrule", testUpdateSchedule.RRule),
-					resource.TestCheckResourceAttr("sumologic_muting_schedule.test", "schedule.0.is_form", strconv.FormatBool(testUpdateSchedule.IsForm)),
 				),
 			},
 		},
@@ -257,7 +254,6 @@ func testAccSumologicMutingSchedulesLibraryMutingSchedule(testName string) strin
 		start_time = "00:00"
 		duration = 40
 		rrule = "FREQ=DAILY;INTERVAL=1;BYHOUR=9,10"
-        is_form = false
 	  }
 }
 `, testName, startDate)
@@ -282,7 +278,6 @@ func testAccSumologicMutingSchedulesLibraryMutingScheduleUpdate(testName string)
 	start_time = "01:00"
 	duration = 50
 	rrule = "FREQ=DAILY;INTERVAL=1"
-	is_form = false
 	}
 }
 `, testName, startDate)
@@ -306,7 +301,6 @@ func testAccSumologicMutingSchedulesLibraryMutingScheduleBadMonitorScope(testNam
 	start_time = "01:00"
 	duration = 50
 	rrule = "FREQ=DAILY;INTERVAL=1"
-	is_form = false
 	}
 }
 `, testName, startDate)

website/docs/r/muting_schedule.html.markdown

@@ -15,17 +15,17 @@ Provides the ability to create, read, delete, and update [MutingSchedule][1].
 resource "sumologic_muting_schedule" "muting_schedule" {
   name = "Muting Schedule For one time"
   description = "This is an example for one time Muting schedule for all monitor"
-	type = "MutingSchedulesLibraryMutingSchedule"
-	content_type = "MutingSchedule"
-	monitor {
-		all = true
-	  }
-	schedule  {
-		timezone = "America/Los_Angeles"
-		start_date = "2023-08-05"
-		start_time = "00:00"
-		duration = 60
-	}
+  type = "MutingSchedulesLibraryMutingSchedule"
+  content_type = "MutingSchedule"
+  monitor {
+	all = true
+  }
+  schedule  {
+	timezone = "America/Los_Angeles"
+	start_date = "2023-08-05"
+	start_time = "00:00"
+	duration = 60
+  }
 }
 ```
 
@@ -35,17 +35,17 @@ resource "sumologic_muting_schedule" "muting_schedule" {
 resource "sumologic_muting_schedule" "muting_schedule" {
   name = "Muting Schedule For one time"
   description = "This is an example for one time Muting schedule for all monitor"
-	type = "MutingSchedulesLibraryMutingSchedule"
-	content_type = "MutingSchedule"
-	monitor {
-		ids = ["0000000000200B92"]
-	  }
-	schedule  {
-		timezone = "America/Los_Angeles"
-		start_date = "2023-08-05"
-		start_time = "00:00"
-		duration = 60
-	}
+  type = "MutingSchedulesLibraryMutingSchedule"
+  content_type = "MutingSchedule"
+  monitor {
+	ids = ["0000000000200B92"]
+  }
+  schedule  {
+	timezone = "America/Los_Angeles"
+	start_date = "2023-08-05"
+	start_time = "00:00"
+	duration = 60
+  }
 }
 ```
 
@@ -55,18 +55,18 @@ resource "sumologic_muting_schedule" "muting_schedule" {
 resource "sumologic_muting_schedule" "muting_schedule" {
   name = "Muting Schedule For one time"
   description = "This is an example for one time Muting schedule for all monitor"
-	type = "MutingSchedulesLibraryMutingSchedule"
-	content_type = "MutingSchedule"
-	monitor {
-		all = true
-	  }
-	schedule  {
-		timezone = "America/Los_Angeles"
-		start_date = "2023-08-05"
-		start_time = "00:00"
-		duration = 30
-    	rrule = "FREQ=DAILY;INTERVAL=1;BYHOUR=9,10"
-	}
+  type = "MutingSchedulesLibraryMutingSchedule"
+  content_type = "MutingSchedule"
+  monitor {
+	all = true
+  }
+  schedule  {
+	timezone = "America/Los_Angeles"
+	start_date = "2023-08-05"
+	start_time = "00:00"
+	duration = 30
+	rrule = "FREQ=DAILY;INTERVAL=1;BYHOUR=9,10"
+  }
 }
 ```
 
@@ -115,7 +115,6 @@ The following arguments are supported:
   An event occurring on the first and second Monday of October would be specified by the rule: `FREQ=YEARLY;BYMONTH=10;BYDAY=MO;BYSETPOS=1,2`
   Event that repeats monthly: every 29th of every other month! `FREQ=MONTHLY;INTERVAL=2;BYMONTHDAY=29`
   (https://freetools.textmagic.com/rrule-generator)
-  - `is_form`- (Optional) A flag identifying if the RRule is created or modified through Form UI. This value is determined by the system and users don't have to define it.
 
 #### monitor_scope_type
   - `ids` - (Optional) List of monitor Ids in hex. Must be empty if `all` is true.