Merge pull request #136 from SumoLogic/ssain-cleanup-collector-resource

deprecate lookup_by_name, destroy; clean up collector tests

Author: seansain

CHANGELOG.md

@@ -16,4 +16,5 @@ BUG FIXES:
 
 DEPRECATIONS:
 
-* resource/sumologiccollector_ingest_budget_assignment: Deprecated in favor of assigning ingest budgets through the _budget field attribute of collectors [GH-135]
+* resource/sumologic_collector_ingest_budget_assignment: Deprecated in favor of assigning ingest budgets through the _budget field attribute of collectors [GH-135]
+* resource/sumologic_collector: Deprecated `lookup_by_name` and `destroy` attributes

sumologic/resource_sumologic_collector.go

@@ -27,13 +27,11 @@ func resourceSumologicCollector() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: false,
-				Default:  "",
 			},
 			"category": {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: false,
-				Default:  "",
 			},
 			"timezone": {
 				Type:     schema.TypeString,
@@ -48,19 +46,20 @@ func resourceSumologicCollector() *schema.Resource {
 				},
 				Optional: true,
 				ForceNew: false,
-				Default:  "",
 			},
 			"lookup_by_name": {
-				Type:     schema.TypeBool,
-				Optional: true,
-				ForceNew: false,
-				Default:  false,
+				Deprecated: "We are deprecating the lookup_by_name attribute as collectors now have data sources.",
+				Type:       schema.TypeBool,
+				Optional:   true,
+				ForceNew:   false,
+				Default:    false,
 			},
 			"destroy": {
-				Type:     schema.TypeBool,
-				Optional: true,
-				ForceNew: false,
-				Default:  true,
+				Deprecated: "We are deprecating the destroy attribute as all resources support lifecycle attribute prevent_destroy",
+				Type:       schema.TypeBool,
+				Optional:   true,
+				ForceNew:   false,
+				Default:    true,
 			},
 		},
 	}