SUMO-213711 updated tests

Author: jinkane

sumologic/resource_sumologic_monitors_library_monitor.go

@@ -1384,11 +1384,9 @@ func jsonToSloSliConditionBlock(conditions []TriggerCondition) map[string]interf
 		case "Critical":
 			hasCritical = true
 			criticalAlrt["sli_threshold"] = condition.SLIThreshold
-			criticalAlrt["time_range"] = condition.TimeRange
 		case "Warning":
 			hasWarning = true
 			warningAlrt["sli_threshold"] = condition.SLIThreshold
-			warningAlrt["time_range"] = condition.TimeRange
 		}
 	}
 	if !hasCritical {

sumologic/resource_sumologic_monitors_library_monitor_test.go

@@ -1219,6 +1219,25 @@ resource "sumologic_monitor" "test" {
 	return resourceText
 }
 
+func exampleSloMonitorWithTriggerCondition(
+	testName string,
+	trigger string) string {
+	var resourceText = fmt.Sprintf(`
+resource "sumologic_monitor" "test" {
+	name = "%s"
+	description = "terraform_test_monitor_description"
+	type = "MonitorsLibraryMonitor"
+	is_disabled = false
+	content_type = "Monitor"
+	monitor_type = "Slo"
+    trigger_conditions {
+      %s
+    }
+	playbook = "This is a test playbook"
+}`, testName, trigger)
+	return resourceText
+}
+
 var exampleLogsStaticTriggerConditionBlock = `
    logs_static_condition {
      critical {
@@ -1319,6 +1338,31 @@ var exampleMetricsMissingDataTriggerConditionBlock = `
      trigger_source = "AnyTimeSeries"
    }`
 
+var exampleSloSliTriggerConditionBlock = `
+   slo_sli_condition {
+	critical {
+		sli_threshold = 90
+	}
+   }`
+
+var exampleSloBurnRateTriggerConditionBlock = `
+   slo_burn_rate_condition {
+      critical {
+        burn_rate_threshold =  20
+        time_range = "1d"
+      }
+      warning {
+        burn_rate {
+             burn_rate_threshold =  20
+             time_range = "2d"
+        }
+        burn_rate {
+             burn_rate_threshold =  20
+             time_range = "2d"
+        }
+      }
+    }`
+
 func exampleLogsStaticMonitor(testName string) string {
 	query := "error | timeslice 1m | count as field by _timeslice"
 	return exampleMonitorWithTriggerCondition(testName, "Logs", query,
@@ -1367,6 +1411,14 @@ func exampleMetricsMissingDataMonitor(testName string) string {
 		exampleMetricsMissingDataTriggerConditionBlock, []string{"MissingData", "ResolvedMissingData"})
 }
 
+func exampleSloSliMonitor(testName string) string {
+	return exampleSloMonitorWithTriggerCondition(testName, exampleSloSliTriggerConditionBlock)
+}
+
+func exampleSloBurnRateMonitor(testName string) string {
+	return exampleSloMonitorWithTriggerCondition(testName, exampleSloBurnRateTriggerConditionBlock)
+}
+
 var allExampleMonitors = []func(testName string) string{
 	exampleLogsStaticMonitor,
 	exampleLogsStaticMonitorWithResolutionWindow,
@@ -1376,6 +1428,8 @@ var allExampleMonitors = []func(testName string) string{
 	exampleMetricsOutlierMonitor,
 	exampleLogsMissingDataMonitor,
 	exampleMetricsMissingDataMonitor,
+	exampleSloSliMonitor,
+	exampleSloBurnRateMonitor,
 }
 
 func testAccSumologicMonitorsLibraryMonitorWithInvalidTriggerCondition(testName string, triggerCondition string) string {
@@ -1462,7 +1516,6 @@ func exampleMetricsMissingDataTriggerCondition(triggerType string) TriggerCondit
 
 func exampleSloSliTriggerCondition(triggerType string, threshold float64) TriggerCondition {
 	return TriggerCondition{
-		TimeRange:       "30m",
 		SLIThreshold:    threshold,
 		TriggerType:     triggerType,
 		DetectionMethod: "SloSliCondition",
@@ -1578,6 +1631,8 @@ var allInvalidTriggerConditionMonitorResources = []func(testName string) string{
 	invalidExampleWithNoTriggerCondition,
 	invalidExampleWithEmptyLogStaticTriggerCondition,
 	invalidExampleWithEmptyMetricsStaticTriggerCondition,
+	invalidExampleWithEmptySloSliTriggerCondition,
+	invalidExampleWithEmptySloSliTriggerCondition,
 }
 
 func invalidExampleWithNoTriggerCondition(testName string) string {
@@ -1595,3 +1650,11 @@ func invalidExampleWithEmptyMetricsStaticTriggerCondition(testName string) strin
 	return exampleMonitorWithTriggerCondition(testName, "Logs", query,
 		`metrics_static_condition {}`, []string{"Critical", "ResolvedCritical"})
 }
+
+func invalidExampleWithEmptySloSliTriggerCondition(testName string) string {
+	return exampleSloMonitorWithTriggerCondition(testName, `slo_sli_condition {}`)
+}
+
+func invalidExampleWithEmptySloBurnRateTriggerCondition(testName string) string {
+	return exampleSloMonitorWithTriggerCondition(testName, `slo_burn_rate_condition {}`)
+}