Merge pull request #410 from SumoLogic/aggr-check

SUMO-189150: removing validations from tf for SLI window aggregation

Author: arpitjain305

sumologic/resource_sumologic_slo.go

@@ -5,20 +5,14 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"log"
-	"regexp"
 )
 
-const sloAggregationRegexString = `^(Avg|Min|Max|Sum|(p[5-9][0-9])(\.\d{1,3})?$)$` // TODO update it to allow lower pct values
-const sloAggregationWindowRegexString = `^[0-9]{1,2}(m|h)$`                        // TODO make it exact of min 1m and max 1h
 const fieldNameWindowBasedEvaluation = `window_based_evaluation`
 const fieldNameRequestBasedEvaluation = `request_based_evaluation`
 const sloContentTypeString = "Slo"
 
 func resourceSumologicSLO() *schema.Resource {
 
-	aggrRegex := regexp.MustCompile(sloAggregationRegexString)
-	windowRegex := regexp.MustCompile(sloAggregationWindowRegexString)
-
 	queryGroupElemSchema := &schema.Resource{
 		Schema: map[string]*schema.Schema{
 			"row_id": {
@@ -111,14 +105,12 @@ func resourceSumologicSLO() *schema.Resource {
 				}, false),
 			},
 			"aggregation": {
-				Type:         schema.TypeString,
-				Optional:     true,
-				ValidateFunc: validation.StringMatch(aggrRegex, `value must match : `+sloAggregationRegexString),
+				Type:     schema.TypeString,
+				Optional: true,
 			},
 			"size": {
 				Type:         schema.TypeString,
 				Required:     true,
-				ValidateFunc: validation.StringMatch(windowRegex, `value must match : `+sloAggregationWindowRegexString),
 			},
 		},
 	}