Use Set type for topology label to avoid ordering issues

Author: sumovishal

sumologic/resource_sumologic_dashboard.go

@@ -69,7 +69,7 @@ func resourceSumologicDashboard() *schema.Resource {
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"data": {
-							Type:     schema.TypeList,
+							Type:     schema.TypeSet,
 							Required: true,
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
@@ -948,9 +948,9 @@ func getTimeRangeBoundary(tfRangeBoundary map[string]interface{}) interface{} {
 }
 
 func getTopologyLabel(tfTopologyLabel map[string]interface{}) *TopologyLabel {
-	if items := tfTopologyLabel["data"].([]interface{}); len(items) >= 1 {
+	if items := tfTopologyLabel["data"].(*schema.Set); items.Len() >= 1 {
 		labelMap := make(map[string][]string)
-		for _, item := range items {
+		for _, item := range items.List() {
 			dataItem := item.(map[string]interface{})
 			key := dataItem["label"].(string)
 			itemValues := dataItem["values"].([]interface{})
@@ -960,6 +960,7 @@ func getTopologyLabel(tfTopologyLabel map[string]interface{}) *TopologyLabel {
 			}
 			labelMap[key] = values
 		}
+
 		return &TopologyLabel{
 			Data: labelMap,
 		}

sumologic/resource_sumologic_dashboard_test.go

@@ -253,10 +253,6 @@ func TestAccSumologicDashboard_update(t *testing.T) {
 						"theme", newTheme),
 					resource.TestCheckResourceAttr("sumologic_dashboard.tf_crud_test",
 						"topology_label_map.0.data.#", "1"),
-					resource.TestCheckResourceAttr("sumologic_dashboard.tf_crud_test",
-						"topology_label_map.0.data.0.label", firstLabelKey),
-					resource.TestCheckResourceAttr("sumologic_dashboard.tf_crud_test",
-						"topology_label_map.0.data.0.values.0", newFirstLabelValue),
 					resource.TestCheckResourceAttr("sumologic_dashboard.tf_crud_test",
 						"time_range.0.begin_bounded_time_range.0.from.0.literal_time_range.0.range_name",
 						newLiteralRangeName),

sumologic/sumologic_dashboard.go

@@ -3,6 +3,7 @@ package sumologic
 import (
 	"encoding/json"
 	"fmt"
+	"log"
 )
 
 func (s *Client) GetDashboard(id string) (*Dashboard, error) {
@@ -20,6 +21,7 @@ func (s *Client) GetDashboard(id string) (*Dashboard, error) {
 	if err != nil {
 		return nil, err
 	}
+	log.Printf("[GetDashboard] response: %+v\n", dashboard)
 	return &dashboard, nil
 }
 
@@ -34,6 +36,7 @@ func (s *Client) CreateDashboard(dashboardReq Dashboard) (*Dashboard, error) {
 	if err != nil {
 		return nil, err
 	}
+	log.Printf("[CreateDashboard] response: %+v\n", dashboard)
 	return &dashboard, nil
 }