Merge pull request #770 from SumoLogic/improve-workflow

improve the matrix test workflow

Author: sjain05

.github/workflows/test.yml

@@ -7,16 +7,8 @@ permissions:
 on:
   pull_request:
     branches: [ master ]
-    paths-ignore:
-      - 'README.md'
-      - 'CHANGELOG.md'
-      - 'website/**'
   push:
     branches: [ master ]
-    paths-ignore:
-      - 'README.md'
-      - 'CHANGELOG.md'
-      - 'website/**'
   # For systems with an upstream API that could drift unexpectedly (like most SaaS systems, etc.),
   # we recommend testing at a regular interval not necessarily tied to code changes. This will
   # ensure you are alerted to something breaking due to an API change, even if the code did not
@@ -36,17 +28,21 @@ jobs:
     outputs:
       run_tests: ${{ steps.filter.outputs.run_tests }}
     steps:
-      - uses: dorny/paths-filter@v2
+      - uses: actions/[email protected]
+        with:
+          fetch-depth: 0  # so we can diff against base
+      - uses: dorny/paths-filter@v3
         id: filter
         with:
+          predicate-quantifier: 'every'
           filters: |
             run_tests:
-              - '!CHANGELOG.md'
+              - '**'
               - '!README.md'
+              - '!CHANGELOG.md'
               - '!website/**'
   # ensure the code builds...
   build:
-    if: needs.should_test.outputs.run_tests == 'true'
     needs: should_test
     name: Build
     runs-on: ubuntu-latest
@@ -70,10 +66,9 @@ jobs:
         go build -v .
   # run acceptance tests in a matrix with Terraform core versions
   test:
-    if: needs.should_test.outputs.run_tests == 'true'
-    needs: build
     name: Matrix Test
     runs-on: ubuntu-latest
+    needs: [ should_test, build ]
     timeout-minutes: 90
     strategy:
       fail-fast: false
@@ -82,56 +77,52 @@ jobs:
         terraform:
           - '1.0.3'
     steps:
+      - name: Set up Go
+        uses: actions/[email protected]
+        with:
+          go-version: '1.22'
+        id: go
 
-    - name: Set up Go
-      uses: actions/[email protected]
-      with:
-        go-version: '1.22'
-      id: go
-
-    - name: Check out code into the Go module directory
-      uses: actions/[email protected]
-
-    - name: Get dependencies
-      run: |
-        go mod download
+      - name: Check out code into the Go module directory
+        uses: actions/[email protected]
 
-    - name: TF acceptance tests
-      timeout-minutes: 90
-      env:
-        TF_ACC: "1"
-        TF_ACC_TERRAFORM_VERSION: ${{ matrix.terraform }}
+      - name: Get dependencies
+        run: |
+          go mod download
 
-        # Set whatever additional acceptance test env vars here. You can
-        # optionally use data from your repository secrets using the
-        # following syntax:
-        # SOME_VAR: ${{ secrets.SOME_VAR }}
-        SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
-        SUMOLOGIC_ACCESSKEY:  ${{ secrets.SUMOLOGIC_ACCESSKEY }}
-        SUMOLOGIC_ENVIRONMENT:  ${{ secrets.SUMOLOGIC_ENVIRONMENT }}
-        SUMOLOGIC_TEST_BUCKET_NAME:  ${{ secrets.SUMOLOGIC_TEST_BUCKET_NAME }}
-        SUMOLOGIC_TEST_CONSUMER_GROUP:  ${{ secrets.SUMOLOGIC_TEST_CONSUMER_GROUP }}
-        SUMOLOGIC_TEST_EVENT_HUB:  ${{ secrets.SUMOLOGIC_TEST_EVENT_HUB }}
-        SUMOLOGIC_TEST_GOOGLE_APPLICATION_CREDENTIALS:  ${{ secrets.SUMOLOGIC_TEST_GOOGLE_APPLICATION_CREDENTIALS }}
-        SUMOLOGIC_TEST_NAMESPACE:  ${{ secrets.SUMOLOGIC_TEST_NAMESPACE }}
-        SUMOLOGIC_TEST_REGION:  ${{ secrets.SUMOLOGIC_TEST_REGION }}
-        SUMOLOGIC_TEST_ROLE_ARN:  ${{ secrets.SUMOLOGIC_TEST_ROLE_ARN }}
-        SUMOLOGIC_TEST_SAS_KEY:  ${{ secrets.SUMOLOGIC_TEST_SAS_KEY }}
-        SUMOLOGIC_TEST_SAS_KEY_NAME:  ${{ secrets.SUMOLOGIC_TEST_SAS_KEY_NAME }}
-        SUMOLOGIC_DATA_FORWARDING_BUCKET:  ${{ secrets.SUMOLOGIC_DATA_FORWARDING_BUCKET }}
-        SUMOLOGIC_DATA_FORWARDING_ROLE_ARN:  ${{ secrets.SUMOLOGIC_DATA_FORWARDING_ROLE_ARN }}
-        SUMOLOGIC_DATA_FORWARDING_AWS_REGION:  ${{ secrets.SUMOLOGIC_DATA_FORWARDING_AWS_REGION }}
-        SUMOLOGIC_TEST_AZURE_TENANT_ID:  ${{ secrets.SUMOLOGIC_TEST_AZURE_TENANT_ID }}
-        SUMOLOGIC_TEST_AZURE_CLIENT_ID:  ${{ secrets.SUMOLOGIC_TEST_AZURE_CLIENT_ID }}
-        SUMOLOGIC_TEST_AZURE_CLIENT_SECRET:  ${{ secrets.SUMOLOGIC_TEST_AZURE_CLIENT_SECRET }}
+      - name: TF acceptance tests
+        timeout-minutes: 90
+        run: |
+          if [ "${{ needs.should_test.outputs.run_tests }}" = "false" ]; then
+            echo "Skipping tests for Terraform ${{ matrix.terraform }} — docs or workflows changes only."
+            exit 0
+          fi
+          
+          echo "Running tests for Terraform ${{ matrix.terraform }}"
+          go test -timeout 0 -v -cover ./sumologic/
+        env:
+          TF_ACC: "1"
+          TF_ACC_TERRAFORM_VERSION: ${{ matrix.terraform }}
 
-      # disable go test timeout. We rely on GitHub action timeout.
-      run: |
-        go test -timeout 0 -v -cover ./sumologic/
-  # skip acceptance tests
-  skip:
-    if: needs.should_test.outputs.run_tests != 'true'
-    needs: should_test
-    runs-on: ubuntu-latest
-    steps:
-      - run: echo "Skipping tests because only docs or website files changed."
+          # Set whatever additional acceptance test env vars here. You can
+          # optionally use data from your repository secrets using the
+          # following syntax:
+          # SOME_VAR: ${{ secrets.SOME_VAR }}
+          SUMOLOGIC_ACCESSID: ${{ secrets.SUMOLOGIC_ACCESSID }}
+          SUMOLOGIC_ACCESSKEY: ${{ secrets.SUMOLOGIC_ACCESSKEY }}
+          SUMOLOGIC_ENVIRONMENT: ${{ secrets.SUMOLOGIC_ENVIRONMENT }}
+          SUMOLOGIC_TEST_BUCKET_NAME: ${{ secrets.SUMOLOGIC_TEST_BUCKET_NAME }}
+          SUMOLOGIC_TEST_CONSUMER_GROUP: ${{ secrets.SUMOLOGIC_TEST_CONSUMER_GROUP }}
+          SUMOLOGIC_TEST_EVENT_HUB: ${{ secrets.SUMOLOGIC_TEST_EVENT_HUB }}
+          SUMOLOGIC_TEST_GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.SUMOLOGIC_TEST_GOOGLE_APPLICATION_CREDENTIALS }}
+          SUMOLOGIC_TEST_NAMESPACE: ${{ secrets.SUMOLOGIC_TEST_NAMESPACE }}
+          SUMOLOGIC_TEST_REGION: ${{ secrets.SUMOLOGIC_TEST_REGION }}
+          SUMOLOGIC_TEST_ROLE_ARN: ${{ secrets.SUMOLOGIC_TEST_ROLE_ARN }}
+          SUMOLOGIC_TEST_SAS_KEY: ${{ secrets.SUMOLOGIC_TEST_SAS_KEY }}
+          SUMOLOGIC_TEST_SAS_KEY_NAME: ${{ secrets.SUMOLOGIC_TEST_SAS_KEY_NAME }}
+          SUMOLOGIC_DATA_FORWARDING_BUCKET: ${{ secrets.SUMOLOGIC_DATA_FORWARDING_BUCKET }}
+          SUMOLOGIC_DATA_FORWARDING_ROLE_ARN: ${{ secrets.SUMOLOGIC_DATA_FORWARDING_ROLE_ARN }}
+          SUMOLOGIC_DATA_FORWARDING_AWS_REGION: ${{ secrets.SUMOLOGIC_DATA_FORWARDING_AWS_REGION }}
+          SUMOLOGIC_TEST_AZURE_TENANT_ID: ${{ secrets.SUMOLOGIC_TEST_AZURE_TENANT_ID }}
+          SUMOLOGIC_TEST_AZURE_CLIENT_ID: ${{ secrets.SUMOLOGIC_TEST_AZURE_CLIENT_ID }}
+          SUMOLOGIC_TEST_AZURE_CLIENT_SECRET: ${{ secrets.SUMOLOGIC_TEST_AZURE_CLIENT_SECRET }}