addressing some of the results of tfproviderlint and updating packages

Author: Sean Sain

go.mod

@@ -3,7 +3,34 @@ module github.com/SumoLogic/sumologic-terraform-provider
 go 1.12
 
 require (
+	cloud.google.com/go/pubsub v1.2.0 // indirect
+	github.com/aws/aws-sdk-go v1.28.14 // indirect
+	github.com/fatih/color v1.9.0 // indirect
 	github.com/go-errors/errors v1.0.1
-	github.com/hashicorp/hcl v0.0.0-20180404174102-ef8a98b0bbce // indirect
-	github.com/hashicorp/terraform-plugin-sdk v1.0.0
+	github.com/go-test/deep v1.0.5 // indirect
+	github.com/golang/mock v1.4.0 // indirect
+	github.com/hashicorp/go-getter v1.4.1 // indirect
+	github.com/hashicorp/go-hclog v0.12.0 // indirect
+	github.com/hashicorp/go-uuid v1.0.2 // indirect
+	github.com/hashicorp/hcl v1.0.0 // indirect
+	github.com/hashicorp/hcl/v2 v2.3.0 // indirect
+	github.com/hashicorp/terraform-config-inspect v0.0.0-20200210163047-f7d8399e1194 // indirect
+	github.com/hashicorp/terraform-plugin-sdk v1.6.0
+	github.com/hashicorp/terraform-svchost v0.0.0-20191119180714-d2e4933b9136 // indirect
+	github.com/hashicorp/yamux v0.0.0-20190923154419-df201c70410d // indirect
+	github.com/kr/pretty v0.2.0 // indirect
+	github.com/mattn/go-isatty v0.0.12 // indirect
+	github.com/oklog/run v1.1.0 // indirect
+	github.com/posener/complete v1.2.3 // indirect
+	github.com/sergi/go-diff v1.1.0 // indirect
+	github.com/ulikunitz/xz v0.5.6 // indirect
+	github.com/vmihailenco/msgpack v4.0.4+incompatible // indirect
+	github.com/zclconf/go-cty v1.2.1 // indirect
+	golang.org/x/crypto v0.0.0-20200210222208-86ce3cb69678 // indirect
+	golang.org/x/exp v0.0.0-20200207192155-f17229e696bd // indirect
+	golang.org/x/tools v0.0.0-20200210223759-b0390335f4a1 // indirect
+	google.golang.org/api v0.17.0 // indirect
+	google.golang.org/genproto v0.0.0-20200210034751-acff78025515 // indirect
+	google.golang.org/grpc v1.27.1 // indirect
+	gopkg.in/yaml.v2 v2.2.8 // indirect
 )

go.sum

@@ -13,7 +13,7 @@ import (
 )
 
 //Testing create functionality for Content resources
-func TestAccContentCreate(t *testing.T) {
+func TestAccContent_create(t *testing.T) {
 	var content Content
 	personalContentId := os.Getenv("SUMOLOGIC_PF")
 
@@ -35,7 +35,7 @@ func TestAccContentCreate(t *testing.T) {
 	})
 }
 
-func TestAccContentUpdate(t *testing.T) {
+func TestAccContent_update(t *testing.T) {
 	var content Content
 	personalContentId := os.Getenv("SUMOLOGIC_PF")
 

sumologic/resource_sumologic_content_test.go

@@ -21,7 +21,31 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccFieldExtractionRuleCreate(t *testing.T) {
+func TestAccSumologicFieldExtractionRule_basic(t *testing.T) {
+	var fieldextractionrule FieldExtractionRule
+	testName := FieldsMap["FieldExtractionRule"]["name"]
+	testScope := FieldsMap["FieldExtractionRule"]["scope"]
+	testParseExpression := FieldsMap["FieldExtractionRule"]["parseExpression"]
+	testEnabled, _ := strconv.ParseBool(FieldsMap["FieldExtractionRule"]["enabled"])
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckFieldExtractionRuleDestroy(fieldextractionrule),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCheckSumologicFieldExtractionRuleConfigImported(testName, testScope, testParseExpression, testEnabled),
+			},
+			{
+				ResourceName:      "sumologic_field_extraction_rule.foo",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func TestAccFieldExtractionRule_create(t *testing.T) {
 	var fieldextractionrule FieldExtractionRule
 	testName := FieldsMap["FieldExtractionRule"]["name"]
 	testScope := FieldsMap["FieldExtractionRule"]["scope"]
@@ -88,7 +112,7 @@ func testAccCheckFieldExtractionRuleExists(name string, fieldextractionrule *Fie
 	}
 }
 
-func TestAccFieldExtractionRuleUpdate(t *testing.T) {
+func TestAccFieldExtractionRule_update(t *testing.T) {
 	var fieldextractionrule FieldExtractionRule
 	testName := FieldsMap["FieldExtractionRule"]["name"]
 	testScope := FieldsMap["FieldExtractionRule"]["scope"]
@@ -131,6 +155,17 @@ func TestAccFieldExtractionRuleUpdate(t *testing.T) {
 	})
 }
 
+func testAccCheckSumologicFieldExtractionRuleConfigImported(name string, scope string, parseExpression string, enabled bool) string {
+	return fmt.Sprintf(`
+resource "sumologic_field_extraction_rule" "foo" {
+      name = "%s"
+      scope = "%s"
+      parse_expression = "%s"
+      enabled = %t
+}
+`, name, scope, parseExpression, enabled)
+}
+
 func testAccSumologicFieldExtractionRule(name string, scope string, parseExpression string, enabled bool) string {
 	return fmt.Sprintf(`
 resource "sumologic_field_extraction_rule" "test" {

sumologic/resource_sumologic_extraction_rule_import_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccFolderCreate(t *testing.T) {
+func TestAccFolder_create(t *testing.T) {
 	var folder Folder
 	rName := acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum)
 	personalFolderId := os.Getenv("SUMOLOGIC_PF")
@@ -34,7 +34,7 @@ func TestAccFolderCreate(t *testing.T) {
 	})
 }
 
-func TestAccFolderUpdate(t *testing.T) {
+func TestAccFolder_update(t *testing.T) {
 	var folder Folder
 	rName := acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum)
 	personalFolderId := os.Getenv("SUMOLOGIC_PF")

sumologic/resource_sumologic_extraction_rule_test.go

@@ -13,7 +13,6 @@ func resourceSumologicPartition() *schema.Resource {
 		Read:   resourceSumologicPartitionRead,
 		Delete: resourceSumologicPartitionDelete,
 		Update: resourceSumologicPartitionUpdate,
-		Exists: resourceSumologicPartitionExists,
 
 		Schema: map[string]*schema.Schema{
 			"name": {
@@ -120,16 +119,6 @@ func resourceSumologicPartitionUpdate(d *schema.ResourceData, meta interface{})
 
 	return resourceSumologicPartitionRead(d, meta)
 }
-func resourceSumologicPartitionExists(d *schema.ResourceData, meta interface{}) (bool, error) {
-	c := meta.(*Client)
-
-	spartition, err := c.GetPartition(d.Id())
-	if err != nil {
-		return false, err
-	}
-
-	return spartition != nil, nil
-}
 
 func resourceToPartition(d *schema.ResourceData) Partition {
 	return Partition{

sumologic/resource_sumologic_folder_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccSumoLogicPartition(t *testing.T) {
+func TestAccSumoLogicPartition_basic(t *testing.T) {
 	testName := acctest.RandString(16)
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },

sumologic/resource_sumologic_partition.go

@@ -21,7 +21,31 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccRoleCreate(t *testing.T) {
+func TestAccSumologicRole_basic(t *testing.T) {
+	var role Role
+	testName := FieldsMap["Role"]["name"]
+	testDescription := FieldsMap["Role"]["description"]
+	testFilterPredicate := FieldsMap["Role"]["filterPredicate"]
+	testCapabilities := []string{"\"" + FieldsMap["Role"]["capabilities"] + "\""}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckRoleDestroy(role),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCheckSumologicRoleConfigImported(testName, testDescription, testFilterPredicate, testCapabilities),
+			},
+			{
+				ResourceName:      "sumologic_role.foo",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func TestAccRole_create(t *testing.T) {
 	var role Role
 	testName := FieldsMap["Role"]["name"]
 	testDescription := FieldsMap["Role"]["description"]
@@ -88,7 +112,7 @@ func testAccCheckRoleExists(name string, role *Role, t *testing.T) resource.Test
 	}
 }
 
-func TestAccRoleUpdate(t *testing.T) {
+func TestAccRole_update(t *testing.T) {
 	var role Role
 	testName := FieldsMap["Role"]["name"]
 	testDescription := FieldsMap["Role"]["description"]
@@ -131,6 +155,17 @@ func TestAccRoleUpdate(t *testing.T) {
 	})
 }
 
+func testAccCheckSumologicRoleConfigImported(name string, description string, filterPredicate string, capabilities []string) string {
+	return fmt.Sprintf(`
+resource "sumologic_role" "foo" {
+      name = "%s"
+      description = "%s"
+      filter_predicate = "%s"
+      capabilities = %v
+}
+`, name, description, filterPredicate, capabilities)
+}
+
 func testAccSumologicRole(name string, description string, filterPredicate string, capabilities []string) string {
 	return fmt.Sprintf(`
 resource "sumologic_role" "test" {