SUMO-170407: fixing test failures

Author: rsanbhad

sumologic/resource_sumologic_connection.go

@@ -83,7 +83,7 @@ func resourceSumologicConnection() *schema.Resource {
 			"connection_subtype": {
 				Type:         schema.TypeString,
 				Optional:     true,
-				ValidateFunc: validation.StringInSlice([]string{"Incident", "Event", ""}, false),
+				ValidateFunc: validation.StringInSlice([]string{"Incident", "Event"}, false),
 			},
 		},
 	}

sumologic/resource_sumologic_monitors_library_monitor.go

@@ -149,7 +149,7 @@ func resourceSumologicMonitorsLibraryMonitor() *schema.Resource {
 										Type:         schema.TypeString,
 										Optional:     true,
 										Computed:     true,
-										ValidateFunc: validation.StringInSlice([]string{"Email", "AWSLambda", "AzureFunctions", "Datadog", "HipChat", "Jira", "NewRelic", "Opsgenie", "PagerDuty", "Slack", "MicrosoftTeams", "Webhook"}, false),
+										ValidateFunc: validation.StringInSlice([]string{"Email", "AWSLambda", "AzureFunctions", "Datadog", "HipChat", "Jira", "NewRelic", "Opsgenie", "PagerDuty", "Slack", "MicrosoftTeams", "ServiceNow", "Webhook"}, false),
 									},
 									"subject": {
 										Type:     schema.TypeString,

sumologic/sumologic_client.go

@@ -360,7 +360,7 @@ type Connection struct {
 	CustomHeaders     []Headers `json:"customHeaders,omitempty"`
 	DefaultPayload    string    `json:"defaultPayload"`
 	WebhookType       string    `json:"webhookType"`
-	ConnectionSubtype string    `json:"connectionSubtype"`
+	ConnectionSubtype string    `json:"connectionSubtype,omitempty"`
 }
 
 // Headers is used to describe headers for http requests.

website/docs/r/connection.html.markdown

@@ -48,7 +48,7 @@ The following arguments are supported:
 - `headers` - (Optional) Map of access authorization headers.
 - `custom_headers` - (Optional) Map of custom webhook headers
 - `default_payload` - (Required) Default payload of the webhook.
-- `connection_subtype` - (Optional) The subtype of the connection. Valid values are `Incident` and `Event`. NOTEL This is only used for the `ServiceNow` webhook type.
+- `connection_subtype` - (Optional) The subtype of the connection. Valid values are `Incident` and `Event`. NOTE: This is only used for the `ServiceNow` webhook type.
 - `webhook_type` - (Optional) Type of webhook. Valid values are `AWSLambda`, `Azure`, `Datadog`, `HipChat`, `PagerDuty`, `Slack`, `Webhook`, `NewRelic`, `MicrosoftTeams`, and `ServiceNow`. Default: `Webhook`
 
 Additional data provided in state