Merge pull request #606 from SumoLogic/DET-374-fix-rule-import-for-severity

DET-374: Fix rule import for severity.

Author: pwardecki-sumo

CHANGELOG.md

@@ -1,5 +1,8 @@
 ## 2.28.1 (Unreleased)
 
+BUG FIXES:
+* Minor fixes enabling proper resource import for CSE Rules (`severity`, `severity_mapping`, `aggregation_functions`). (GH-606)
+
 ## 2.28.0 (November 23, 2023)
 FEATURES:
 * resource/sumologic_monitor: Added support for setting `time_zone` at Monitor level for notifications content (GH-586)

sumologic/resource_sumologic_cse_aggregation_rule_test.go

@@ -73,6 +73,11 @@ func TestAccSumologicCSEAggregationRule_createAndUpdate(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }

sumologic/resource_sumologic_cse_chain_rule.go

@@ -112,6 +112,7 @@ func resourceSumologicCSEChainRuleRead(d *schema.ResourceData, meta interface{})
 	d.Set("is_prototype", CSEChainRuleGet.IsPrototype)
 	d.Set("ordered", CSEChainRuleGet.Ordered)
 	d.Set("name", CSEChainRuleGet.Name)
+	d.Set("severity", CSEChainRuleGet.Severity)
 	d.Set("summary_expression", CSEChainRuleGet.SummaryExpression)
 	d.Set("tags", CSEChainRuleGet.Tags)
 	d.Set("window_size", CSEChainRuleGet.WindowSizeName)

sumologic/resource_sumologic_cse_chain_rule_test.go

@@ -66,6 +66,11 @@ func TestAccSumologicCSEChainRule_createAndUpdate(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }

sumologic/resource_sumologic_cse_first_seen_rule_test.go

@@ -59,6 +59,11 @@ func TestAccSumologicCSEFirstSeenRule_createAndUpdate(t *testing.T) {
 					testCheckFirstSeenRuleValues(t, &updatedPayload, &result),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }

sumologic/resource_sumologic_cse_match_rule_test.go

@@ -62,6 +62,11 @@ func TestAccSumologicCSEMatchRule_createAndUpdate(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }

sumologic/resource_sumologic_cse_outlier_rule.go

@@ -132,7 +132,7 @@ func resourceSumologicCSEOutlierRuleRead(d *schema.ResourceData, meta interface{
 		return nil
 	}
 
-	d.Set("aggregate_function", aggregationFunctionsArrayToResource(CSEOutlierRuleGet.AggregationFunctions))
+	d.Set("aggregation_functions", aggregationFunctionsArrayToResource(CSEOutlierRuleGet.AggregationFunctions))
 	d.Set("baseline_window_size", CSEOutlierRuleGet.BaselineWindowSize)
 	d.Set("description_expression", CSEOutlierRuleGet.DescriptionExpression)
 	d.Set("deviation_threshold", CSEOutlierRuleGet.DeviationThreshold)

sumologic/resource_sumologic_cse_outlier_rule_test.go

@@ -63,6 +63,11 @@ func TestAccSumologicCSEOutlierRule_createAndUpdate(t *testing.T) {
 					testCheckOutlierRuleValues(t, &updatedPayload, &result),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }

sumologic/resource_sumologic_cse_threshold_rule.go

@@ -110,6 +110,7 @@ func resourceSumologicCSEThresholdRuleRead(d *schema.ResourceData, meta interfac
 	d.Set("is_prototype", CSEThresholdRuleGet.IsPrototype)
 	d.Set("limit", CSEThresholdRuleGet.Limit)
 	d.Set("name", CSEThresholdRuleGet.Name)
+	d.Set("severity", CSEThresholdRuleGet.Severity)
 	d.Set("summary_expression", CSEThresholdRuleGet.SummaryExpression)
 	d.Set("tags", CSEThresholdRuleGet.Tags)
 	d.Set("window_size", CSEThresholdRuleGet.WindowSizeName)

sumologic/resource_sumologic_cse_threshold_rule_test.go

@@ -64,6 +64,11 @@ func TestAccSumologicCSEThresholdRule_createAndUpdate(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }