Skip to content

Commit 8d98ba1

Browse files
author
Ashish Gaurav
committed
[SLO] fix allowed value for compliance window size
Took 17 minutes
1 parent 468b61f commit 8d98ba1

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

sumologic/resource_sumologic_slo.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ func resourceSumologicSLO() *schema.Resource {
211211
Type: schema.TypeString,
212212
Required: true,
213213
ValidateFunc: validation.StringInSlice([]string{
214+
"Week", "Month", "Quarter",
214215
"1d", "2d", "3d", "4d", "5d", "6d", "7d", "8d", "9d", "10d", "11d", "12d", "13d", "14d",
215216
}, false),
216217
},

website/docs/r/slo.html.markdown

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,16 +97,17 @@ The following arguments are supported:
9797
- `target` - (Required) The target value to use, must be a number between 0 and 100.
9898
- `timezone` - (Required) Time zone for the SLO compliance. Follow the format in the [IANA Time Zone Database][3].
9999
- `size` - (Required) The size of the compliance period to use.
100-
For `Calendar` compliance type the allowed values are `Week`, `Month`, `Quarter`.
100+
- For `Rolling` compliance type it must be a multiple of days e.g. `1d`, `2d`.
101+
- For `Calendar` compliance type the allowed values are `Week`, `Month`, `Quarter`.
101102
- `start_from` - (Optional) Start of the calendar window. For week, it would be the day of the week (for e.g Sunday,
102103
Monday etc). For month, it will always be the first day of the month. For quarter, it would be the first month of
103104
the quarter (for e.g January, February etc.)
104-
- `indicator` - (Required) The service level indicator on which SLO is to be defined. more details on the difference
105-
b/w them can be found on
106-
the [slo help page](https://help.sumologic.com/Beta/SLO_Reliability_Management/Access_and_Create_SLOs)
107-
- [window_based_evaluation](#window_based_evaluation) - Evaluate SLI using successful/total windows.
108-
- [request_based_evaluation](#request_based_evaluation) - Evaluate SLI based on occurrence of successful
109-
events / total events over entire compliance period.
105+
- `indicator` - (Required) The service level indicator on which SLO is to be defined. more details on the difference
106+
b/w them can be found on
107+
the [slo help page](https://help.sumologic.com/Beta/SLO_Reliability_Management/Access_and_Create_SLOs)
108+
- [window_based_evaluation](#window_based_evaluation) - Evaluate SLI using successful/total windows.
109+
- [request_based_evaluation](#request_based_evaluation) - Evaluate SLI based on occurrence of successful
110+
events / total events over entire compliance period.
110111

111112
#### window_based_evaluation
112113

0 commit comments

Comments
 (0)