feedback from vishal

Author: Pedro Montiel

sumologic/resource_sumologic_cse_insights_resolution.go

@@ -7,6 +7,11 @@ import (
 	"strconv"
 )
 
+const Resolved string = "Resolved"
+const FalsePositive string = "FalsePositive"
+const NoAction string = "NoAction"
+const Duplicate string = "Duplicate"
+
 func resourceSumologicCSEInsightsResolution() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceSumologicCSEInsightsResolutionCreate,
@@ -32,7 +37,7 @@ func resourceSumologicCSEInsightsResolution() *schema.Resource {
 				Type:         schema.TypeString,
 				Optional:     true,
 				ForceNew:     false,
-				ValidateFunc: validation.StringInSlice([]string{"Resolved", "False Positive", "No Action", "Duplicate"}, false),
+				ValidateFunc: validation.StringInSlice([]string{Resolved, FalsePositive, NoAction, Duplicate}, false),
 			},
 		},
 	}
@@ -42,11 +47,11 @@ func resourceSumologicCSEInsightsResolutionRead(d *schema.ResourceData, meta int
 	c := meta.(*Client)
 
 	var CSEInsightsResolutionGet *CSEInsightsResolutionGet
-	id, _ := strconv.Atoi(d.Id())
+	id := d.Id()
 
 	CSEInsightsResolutionGet, err := c.GetCSEInsightsResolution(id)
 	if err != nil {
-		log.Printf("[WARN] CSE Insights Resolution not found when looking by id: %d, err: %v", id, err)
+		log.Printf("[WARN] CSE Insights Resolution not found when looking by id: %s, err: %v", id, err)
 
 	}
 
@@ -69,13 +74,13 @@ func parentIdToParentName(parentId int) string {
 
 	if parentId > 0 {
 		if parentId == 1 {
-			parentName = "Resolved"
+			parentName = Resolved
 		} else if parentId == 2 {
-			parentName = "False Positive"
+			parentName = FalsePositive
 		} else if parentId == 3 {
-			parentName = "No Action"
+			parentName = NoAction
 		} else if parentId == 4 {
-			parentName = "Duplicate"
+			parentName = Duplicate
 		}
 	}
 	return parentName
@@ -85,24 +90,23 @@ func parentNameToParentId(parentName string) int {
 
 	parentId := -1
 
-	if parentName != "" {
-		if parentName == "Resolved" {
-			parentId = 1
-		} else if parentName == "False Positive" {
-			parentId = 2
-		} else if parentName == "No Action" {
-			parentId = 3
-		} else if parentName == "Duplicate" {
-			parentId = 4
-		}
+	if parentName == Resolved {
+		parentId = 1
+	} else if parentName == FalsePositive {
+		parentId = 2
+	} else if parentName == NoAction {
+		parentId = 3
+	} else if parentName == Duplicate {
+		parentId = 4
 	}
+
 	return parentId
 }
 
 func resourceSumologicCSEInsightsResolutionDelete(d *schema.ResourceData, meta interface{}) error {
 	c := meta.(*Client)
 
-	id, _ := strconv.Atoi(d.Id())
+	id := d.Id()
 	return c.DeleteCSEInsightsResolution(id)
 
 }

sumologic/resource_sumologic_cse_insights_resolution_test.go

@@ -2,7 +2,6 @@ package sumologic
 
 import (
 	"fmt"
-	"strconv"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
@@ -44,10 +43,7 @@ func testAccCSEInsightsResolutionDestroy(s *terraform.State) error {
 			return fmt.Errorf("CSE Insights Resolution destruction check: CSE Insights Resolution ID is not set")
 		}
 
-		id, err := strconv.Atoi(rs.Primary.ID)
-		if err != nil {
-			return fmt.Errorf("cse insight resolution check: id should be int; got %s", rs.Primary.ID)
-		}
+		id := rs.Primary.ID
 
 		s, err := client.GetCSEInsightsResolution(id)
 		if err != nil {
@@ -81,10 +77,7 @@ func testCheckCSEInsightsResolutionExists(n string, insightResolution *CSEInsigh
 			return fmt.Errorf("insight Resolution ID is not set")
 		}
 
-		id, err := strconv.Atoi(rs.Primary.ID)
-		if err != nil {
-			return fmt.Errorf("insight Resolution id should be int; got %s", rs.Primary.ID)
-		}
+		id := rs.Primary.ID
 
 		c := testAccProvider.Meta().(*Client)
 		insightResolutionResp, err := c.GetCSEInsightsResolution(id)

sumologic/resource_sumologic_cse_insights_status.go

@@ -26,6 +26,10 @@ func resourceSumologicCSEInsightsStatus() *schema.Resource {
 				Required: true,
 				ForceNew: false,
 			},
+			"display_name": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
 		},
 	}
 }
@@ -50,6 +54,7 @@ func resourceSumologicCSEInsightsStatusRead(d *schema.ResourceData, meta interfa
 
 	d.Set("name", CSEInsightsStatusGet.Name)
 	d.Set("description", CSEInsightsStatusGet.Description)
+	d.Set("display_name", CSEInsightsStatusGet.DisplayName)
 
 	return nil
 }

sumologic/sumologic_cse_insights_resolution.go

@@ -5,8 +5,8 @@ import (
 	"fmt"
 )
 
-func (s *Client) GetCSEInsightsResolution(id int) (*CSEInsightsResolutionGet, error) {
-	data, _, err := s.Get(fmt.Sprintf("sec/v1/insight-resolutions/%d", id))
+func (s *Client) GetCSEInsightsResolution(id string) (*CSEInsightsResolutionGet, error) {
+	data, _, err := s.Get(fmt.Sprintf("sec/v1/insight-resolutions/%s", id))
 	if err != nil {
 		return nil, err
 	}
@@ -24,8 +24,8 @@ func (s *Client) GetCSEInsightsResolution(id int) (*CSEInsightsResolutionGet, er
 	return &response.CSEInsightsResolutionGet, nil
 }
 
-func (s *Client) DeleteCSEInsightsResolution(id int) error {
-	_, err := s.Delete(fmt.Sprintf("sec/v1/insight-resolutions/%d", id))
+func (s *Client) DeleteCSEInsightsResolution(id string) error {
+	_, err := s.Delete(fmt.Sprintf("sec/v1/insight-resolutions/%s", id))
 
 	return err
 }

website/docs/r/cse_insights_configuration.html.markdown

@@ -11,8 +11,8 @@ Provides the Sumologic CSE Insights Configuration for the whole organization. Th
 ## Example Usage
 ```hcl
 resource "sumologic_cse_insights_configuration" "insights_configuration" {
-  lookback_days = 13
-  threshold = 12
+  lookback_days = 13.0
+  threshold = 12.0
 }
 ```
 

website/docs/r/cse_insights_resolution.html.markdown

@@ -2,11 +2,11 @@
 layout: "sumologic"
 page_title: "SumoLogic: sumologic_cse_insights_resolution"
 description: |-
-  Provides a CSE Insights Resolution
+  Provides a Sumologic CSE Insights Resolution. When an insight gets closed, a resolution indicates why it got closed.
 ---
 
 # sumologic_cse_insights_resolution
-Provides a CSE Insights Resolution.
+Provides a Sumologic CSE Insights Resolution. When an insight gets closed, a resolution indicates why it got closed.
 
 ## Example Usage
 ```hcl

website/docs/r/cse_insights_status.html.markdown

@@ -2,11 +2,11 @@
 layout: "sumologic"
 page_title: "SumoLogic: sumologic_cse_insights_status"
 description: |-
-  Provides a CSE Insights Status
+  Provides a Sumologic CSE Insights Status
 ---
 
 # sumologic_cse_insights_status
-Provides a CSE Insights Status.
+Provides a Sumologic CSE Insights Status.
 
 ## Example Usage
 ```hcl