Metrics Search Terraform Resource - field constraints

Author: sumo-zzhou

sumologic/resource_sumologic_metrics_search.go

@@ -4,6 +4,7 @@ import (
 	"log"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 )
 
 func resourceSumologicMetricsSearch() *schema.Resource {
@@ -18,24 +19,29 @@ func resourceSumologicMetricsSearch() *schema.Resource {
 
 		Schema: map[string]*schema.Schema{
 			"title": {
-				Type:     schema.TypeString,
-				Required: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ValidateFunc: validation.StringLenBetween(1, 255),
 			},
 			"description": {
-				Type:     schema.TypeString,
-				Optional: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ValidateFunc: validation.StringLenBetween(0, 8192),
 			},
 			"parent_id": {
 				Type:     schema.TypeString,
-				Optional: true,
+				Required: true,
 			},
 			"log_query": {
-				Type:     schema.TypeString,
-				Optional: true,
+				Type:         schema.TypeString,
+				Optional:     true,
+				ValidateFunc: validation.StringLenBetween(0, 1024),
 			},
 			"desired_quantization_in_secs": {
-				Type:     schema.TypeInt,
-				Optional: true,
+				Type:         schema.TypeInt,
+				Optional:     true,
+				Default:      0,
+				ValidateFunc: validation.IntAtLeast(0),
 			},
 			"time_range": {
 				Type:     schema.TypeList,
@@ -51,7 +57,7 @@ func resourceSumologicMetricsSearch() *schema.Resource {
 			},
 			"metrics_queries": {
 				Type:     schema.TypeList,
-				Optional: true,
+				Required: true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"row_id": {

sumologic/resource_sumologic_metrics_search_test.go

@@ -88,4 +88,4 @@ func testAccSumologicMetricsSearch(tfResourceName string, title string, descript
 	`, tfResourceName, title, description, logQuery, desiredQuantizationInSecs,
 		metricsSearchQuery[0].RowId, metricsSearchQuery[0].Query,
 		literalRangeName)
-}
+}

website/docs/r/metrics_search.html.markdown

@@ -38,7 +38,7 @@ resource "sumologic_metrics_search" "example_metrics_search" {
 The following arguments are supported:
 
 - `title` - (Required) Title of the search.
-- `description` - (Optional) Description of the search.
+- `description` - (Required) Description of the search.
 - `parent_id` - (Required) The identifier of the folder to create the log search in.
 - `log_query` - Log query to perform.
 - `metrics_queries` - (Required) Array of objects [MetricsSearchQuery](#schema-for-metrics_search_query). Metrics queries, up to the maximum of six.