Skip to content

Commit 970c090

Browse files
authored
Use int64 where API returns a 64 bit wide integer (#177)
1 parent d012a73 commit 970c090

File tree

5 files changed

+21
-17
lines changed

5 files changed

+21
-17
lines changed

sumologic/data_source_sumologic_collector.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func dataSourceSumologicCollectorRead(d *schema.ResourceData, meta interface{})
7373
}
7474
}
7575

76-
d.SetId(strconv.Itoa(collector.ID))
76+
d.SetId(strconv.FormatInt(collector.ID, 10))
7777
d.Set("name", collector.Name)
7878
d.Set("description", collector.Description)
7979
d.Set("category", collector.Category)

sumologic/data_source_sumologic_http_source.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ package sumologic
22

33
import (
44
"fmt"
5-
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
65
"strconv"
6+
7+
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
78
)
89

910
func dataSourceSumologicHTTPSource() *schema.Resource {
@@ -54,7 +55,7 @@ func dataSourceSumologicHTTPSourceRead(d *schema.ResourceData, meta interface{})
5455
c := meta.(*Client)
5556

5657
id, _ := strconv.Atoi(d.Id())
57-
source, err := c.GetSourceName(d.Get("collector_id").(int), d.Get("name").(string))
58+
source, err := c.GetSourceName(d.Get("collector_id").(int64), d.Get("name").(string))
5859

5960
if err != nil {
6061
return err

sumologic/resource_sumologic_collector.go

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func resourceSumologicCollectorRead(d *schema.ResourceData, meta interface{}) er
6464
} else if collector == nil {
6565
log.Printf("[WARN] Got a nil Collector when looking by name: %s", d.Id())
6666
} else {
67-
d.SetId(strconv.Itoa(collector.ID))
67+
d.SetId(strconv.FormatInt(collector.ID, 10))
6868
}
6969
} else {
7070
collector, err = c.GetCollector(id)
@@ -111,28 +111,31 @@ func resourceSumologicCollectorCreate(d *schema.ResourceData, meta interface{})
111111
return err
112112
}
113113

114-
d.SetId(strconv.Itoa(id))
114+
d.SetId(strconv.FormatInt(id, 10))
115115
}
116116

117117
return resourceSumologicCollectorUpdate(d, meta)
118118
}
119119

120120
func resourceSumologicCollectorUpdate(d *schema.ResourceData, meta interface{}) error {
121-
122-
collector := resourceToCollector(d)
121+
collector, err := resourceToCollector(d)
122+
if err != nil {
123+
return err
124+
}
123125

124126
c := meta.(*Client)
125-
err := c.UpdateCollector(collector)
126-
127-
if err != nil {
127+
if err = c.UpdateCollector(collector); err != nil {
128128
return err
129129
}
130130

131131
return resourceSumologicCollectorRead(d, meta)
132132
}
133133

134-
func resourceToCollector(d *schema.ResourceData) Collector {
135-
id, _ := strconv.Atoi(d.Id())
134+
func resourceToCollector(d *schema.ResourceData) (Collector, error) {
135+
id, err := strconv.ParseInt(d.Id(), 10, 64)
136+
if err != nil {
137+
return Collector{}, err
138+
}
136139

137140
return Collector{
138141
ID: id,
@@ -142,5 +145,5 @@ func resourceToCollector(d *schema.ResourceData) Collector {
142145
Category: d.Get("category").(string),
143146
TimeZone: d.Get("timezone").(string),
144147
Fields: d.Get("fields").(map[string]interface{}),
145-
}
148+
}, nil
146149
}

sumologic/sumologic_collectors.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func (s *Client) DeleteCollector(id int) error {
4949
return err
5050
}
5151

52-
func (s *Client) CreateCollector(collector Collector) (int, error) {
52+
func (s *Client) CreateCollector(collector Collector) (int64, error) {
5353

5454
request := CollectorRequest{
5555
Collector: collector,
@@ -101,7 +101,7 @@ type CollectorLink struct {
101101
}
102102

103103
type Collector struct {
104-
ID int `json:"id,omitempty"`
104+
ID int64 `json:"id,omitempty"`
105105
CollectorType string `json:"collectorType,omitempty"`
106106
Name string `json:"name"`
107107
Description string `json:"description,omitempty"`
@@ -110,6 +110,6 @@ type Collector struct {
110110
Fields map[string]interface{} `json:"fields,omitempty"`
111111
Links []CollectorLink `json:"links,omitempty"`
112112
CollectorVersion string `json:"collectorVersion,omitempty"`
113-
LastSeenAlive int `json:"lastSeenAlive,omitempty"`
113+
LastSeenAlive int64 `json:"lastSeenAlive,omitempty"`
114114
Alive bool `json:"alive,omitempty"`
115115
}

sumologic/sumologic_sources.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ func (s *Client) DestroySource(sourceID int, collectorID int) error {
335335
return err
336336
}
337337

338-
func (s *Client) GetSourceName(collectorID int, sourceName string) (*Source, error) {
338+
func (s *Client) GetSourceName(collectorID int64, sourceName string) (*Source, error) {
339339

340340
data, _, err := s.Get(
341341
fmt.Sprintf("v1/collectors/%d/sources", collectorID),

0 commit comments

Comments
 (0)