Fix crash when role data source id or name not found

Author: emichaeli

sumologic/data_source_sumologic_role.go

@@ -55,6 +55,9 @@ func dataSourceSumologicRoleRead(d *schema.ResourceData, meta interface{}) error
 		if err != nil {
 			return fmt.Errorf("role with id %v not found: %v", id, err)
 		}
+		if role == nil {
+			return fmt.Errorf("role with id %v not found", id)
+		}
 	} else {
 		if rname, ok := d.GetOk("name"); ok {
 			name := rname.(string)
@@ -97,6 +100,9 @@ func (s *Client) GetRoleName(name string) (*Role, error) {
 	if err != nil {
 		return nil, err
 	}
+	if len(response.Roles) == 0 {
+		return nil, fmt.Errorf("role with name '%s' does not exist", name)
+	}
 
 	return &response.Roles[0], nil
 }

sumologic/data_source_sumologic_role_test.go

@@ -1,12 +1,13 @@
 package sumologic
 
 import (
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccDataSourcSumologicRole_basic(t *testing.T) {
+func TestAccDataSourceSumologicRole_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
@@ -33,6 +34,40 @@ func testAccDataSourceRoleCheck(name, reference string) resource.TestCheckFunc {
 	)
 }
 
+func TestAccDataSourceSumologicRole_role_name_doesnt_exist(t *testing.T) {
+	roleDoestExistConfig := `
+  data "sumologic_role" "role_name_doesnt_exist" {
+    name = "someRoleNameDoesntExist8746"
+  }`
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config:      roleDoestExistConfig,
+				ExpectError: regexp.MustCompile("role with name 'someRoleNameDoesntExist8746' does not exist"),
+			},
+		},
+	})
+}
+
+func TestAccDataSourceSumologicRole_role_id_doesnt_exist(t *testing.T) {
+	roleDoestExistConfig := `
+  data "sumologic_role" "role_id_doesnt_exist" {
+    id = 99999999999999
+  }`
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config:      roleDoestExistConfig,
+				ExpectError: regexp.MustCompile("role with id 99999999999999 not found"),
+			},
+		},
+	})
+}
+
 var testDataSourceAccSumologicRoleConfig = `
 resource "sumologic_role" "test" {
   name = "My_SumoRole"