Skip to content

Commit a953737

Browse files
authored
Merge pull request #147 from SumoLogic/ssain-move-data-source-role-code
move some code around for generator
2 parents c631ba7 + 255bf0c commit a953737

File tree

2 files changed

+24
-23
lines changed

2 files changed

+24
-23
lines changed

sumologic/data_source_sumologic_role.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package sumologic
22

33
import (
4+
"encoding/json"
45
"errors"
56
"fmt"
67
"log"
@@ -79,3 +80,26 @@ func dataSourceSumologicRoleRead(d *schema.ResourceData, meta interface{}) error
7980
log.Printf("[DEBUG] data_source_sumologic_role: retrieved %v", role)
8081
return nil
8182
}
83+
84+
func (s *Client) GetRoleName(name string) (*Role, error) {
85+
data, _, err := s.Get(fmt.Sprintf("v1/roles?name=%s", name))
86+
if err != nil {
87+
return nil, err
88+
}
89+
90+
if data == nil {
91+
return nil, fmt.Errorf("role with name '%s' does not exist", name)
92+
}
93+
94+
var response RoleResponse
95+
err = json.Unmarshal(data, &response)
96+
if err != nil {
97+
return nil, err
98+
}
99+
100+
return &response.Roles[0], nil
101+
}
102+
103+
type RoleResponse struct {
104+
Roles []Role `json:"data"`
105+
}

sumologic/sumologic_role.go

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -53,25 +53,6 @@ func (s *Client) GetRole(id string) (*Role, error) {
5353
return &role, nil
5454
}
5555

56-
func (s *Client) GetRoleName(name string) (*Role, error) {
57-
data, _, err := s.Get(fmt.Sprintf("v1/roles?name=%s", name))
58-
if err != nil {
59-
return nil, err
60-
}
61-
62-
if data == nil {
63-
return nil, fmt.Errorf("role with name '%s' does not exist", name)
64-
}
65-
66-
var response RoleResponse
67-
err = json.Unmarshal(data, &response)
68-
if err != nil {
69-
return nil, err
70-
}
71-
72-
return &response.Roles[0], nil
73-
}
74-
7556
func (s *Client) UpdateRole(role Role) error {
7657
url := fmt.Sprintf("v1/roles/%s", role.ID)
7758

@@ -81,10 +62,6 @@ func (s *Client) UpdateRole(role Role) error {
8162
return err
8263
}
8364

84-
type RoleResponse struct {
85-
Roles []Role `json:"data"`
86-
}
87-
8865
// models
8966
type Role struct {
9067
ID string `json:"id,omitempty"`

0 commit comments

Comments
 (0)