INVS-11: remove active flag

Author: Pedro Montiel

sumologic/resource_sumologic_cse_match_list.go

@@ -17,10 +17,6 @@ func resourceSumologicCSEMatchList() *schema.Resource {
 		},
 
 		Schema: map[string]*schema.Schema{
-			"active": {
-				Type:     schema.TypeBool,
-				Optional: true,
-			},
 			"default_ttl": {
 				Type:     schema.TypeInt,
 				Required: true,
@@ -66,10 +62,6 @@ func resourceSumologicCSEMatchList() *schema.Resource {
 							Type:     schema.TypeString,
 							Computed: true,
 						},
-						"active": {
-							Type:     schema.TypeBool,
-							Required: true,
-						},
 						"description": {
 							Type:     schema.TypeString,
 							Required: true,
@@ -143,7 +135,6 @@ func setItems(d *schema.ResourceData, items []CSEMatchListItemGet) {
 	for _, t := range items {
 		mapping := map[string]interface{}{
 			"id":          t.ID,
-			"active":      t.Active,
 			"description": t.Meta.Description,
 			"expiration":  t.Expiration,
 			"value":       t.Value,
@@ -184,7 +175,7 @@ func resourceSumologicCSEMatchListCreate(d *schema.ResourceData, meta interface{
 
 	if d.Id() == "" {
 		id, err := c.CreateCSEMatchList(CSEMatchListPost{
-			Active:       d.Get("active").(bool),
+			Active:       true,
 			DefaultTtl:   d.Get("default_ttl").(int),
 			Description:  d.Get("description").(string),
 			Name:         d.Get("name").(string),
@@ -227,7 +218,7 @@ func resourceToCSEMatchListItem(data interface{}) CSEMatchListItemPost {
 		itemObj := itemsSlice[0].(map[string]interface{})
 		item.ID = itemObj["id"].(string)
 		item.Description = itemObj["description"].(string)
-		item.Active = itemObj["active"].(bool)
+		item.Active = true
 		item.Expiration = itemObj["expiration"].(string)
 		item.Value = itemObj["value"].(string)
 	}
@@ -284,7 +275,7 @@ func resourceToCSEMatchList(d *schema.ResourceData) (CSEMatchListPost, error) {
 
 	return CSEMatchListPost{
 		ID:           id,
-		Active:       d.Get("active").(bool),
+		Active:       true,
 		DefaultTtl:   d.Get("default_ttl").(int),
 		Description:  d.Get("description").(string),
 		Name:         d.Get("name").(string),

sumologic/resource_sumologic_cse_match_list_test.go

@@ -12,12 +12,10 @@ func TestAccSumologicSCEMatchList_createAndUpdate(t *testing.T) {
 	SkipCseTest(t)
 
 	var matchList CSEMatchListGet
-	nActive := true
 	nDefaultTtl := 10800
 	nDescription := "New Match List Description"
 	nName := "Match List Name"
 	nTargetColumn := "SrcIp"
-	liActive := true
 	liDescription := "Match List Item Description"
 	liValue := "value"
 	liExpiration := "2122-02-27T04:00:00"
@@ -32,15 +30,15 @@ func TestAccSumologicSCEMatchList_createAndUpdate(t *testing.T) {
 		CheckDestroy: testAccCSEMatchListDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testCreateCSEMatchListConfig(nActive, nDefaultTtl, nDescription, nName, nTargetColumn, liActive, liDescription, liExpiration, liValue),
+				Config: testCreateCSEMatchListConfig(nDefaultTtl, nDescription, nName, nTargetColumn, liDescription, liExpiration, liValue),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckCSEMatchListExists(resourceName, &matchList),
 					testCheckMatchListValues(&matchList, nDefaultTtl, nDescription, nName, nTargetColumn),
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 				),
 			},
 			{
-				Config: testCreateCSEMatchListConfig(nActive, uDefaultTtl, uDescription, nName, nTargetColumn, liActive, uliDescription, liExpiration, liValue),
+				Config: testCreateCSEMatchListConfig(uDefaultTtl, uDescription, nName, nTargetColumn, uliDescription, liExpiration, liValue),
 				Check: resource.ComposeTestCheckFunc(
 					testCheckCSEMatchListExists(resourceName, &matchList),
 					testCheckMatchListValues(&matchList, uDefaultTtl, uDescription, nName, nTargetColumn),
@@ -73,22 +71,20 @@ func testAccCSEMatchListDestroy(s *terraform.State) error {
 	return nil
 }
 
-func testCreateCSEMatchListConfig(nActive bool, nDefaultTtl int, nDescription string, nName string, nTargetColumn string, liActive bool, liDescription string, liExpiration string, liValue string) string {
+func testCreateCSEMatchListConfig(nDefaultTtl int, nDescription string, nName string, nTargetColumn string, liDescription string, liExpiration string, liValue string) string {
 	return fmt.Sprintf(`
 resource "sumologic_cse_match_list" "match_list" {
-	active = "%t"
 	default_ttl = "%d"
 	description = "%s"
 	name = "%s"
 	target_column = "%s"
 	items {
-		active = "%t"
 		description = "%s"
 		expiration = "%s"
 		value = "%s"
 	}
 }
-`, nActive, nDefaultTtl, nDescription, nName, nTargetColumn, liActive, liDescription, liExpiration, liValue)
+`, nDefaultTtl, nDescription, nName, nTargetColumn, liDescription, liExpiration, liValue)
 }
 
 func testCheckCSEMatchListExists(n string, matchList *CSEMatchListGet) resource.TestCheckFunc {

website/docs/r/cse_log_match_list.html.markdown

@@ -29,15 +29,13 @@ resource "sumologic_cse_match_list" "match_list" {
 
 The following arguments are supported:
 
-- `active` - (Optional) Match list active flag. Default True.
 - `default_ttl` - (Required) The match list time to live. Specified in seconds.
 - `description` - (Required) Match list description.
 - `name` - (Required) Match list name.
 - `target_column` - (Required) Target column. (possible values: Hostname, FileHash, Url, SrcIp, DstIp, Domain, Username, Ip, Asn, Isp, Org, SrcAsn, SrcIsp, SrcOrg, DstAsn, DstIsp, DstOrg or any custom column.)
 - `items` - (Optional) List of match list items. See [match_list_item schema](#schema-for-match_list_item) for details.
 
 ### Schema for `match_list_item`
-- `acive` - (Required) Match list item active flag.
 - `description` - (Required) Match list item description.
 - `value` - (Optional) Match list item value.
 - `expiration` - (Optional) Match list item expiration. (Format: YYYY-MM-DDTHH:mm:ss)