Skip to content

Commit bc6a24e

Browse files
Merge branch 'master' of https://github.com/SumoLogic/terraform-provider-sumologic into chirag-BE-468
2 parents 35efd3c + dd450a7 commit bc6a24e

28 files changed

+389
-387
lines changed

.github/CODEOWNERS

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,16 @@
22
# Each line is a file pattern followed by one or more owners.
33

44
# These owners will be the default owners for everything in
5-
# the repo. Unless a later match takes precedence,
6-
# @sumovishal, @dagould will be requested for
7-
# review when someone opens a pull request.
8-
* @sumovishal @dagould
5+
# the repo. Unless a later match takes precedence, they will
6+
# be requested for review when someone opens a pull request.
7+
* @SumoLogic/tf-platform-team
98

109
# Code owners for collection sources
1110
/sumologic/*_source.go @maimaisie @vsinghal13
1211
/sumologic/*_source_test.go @maimaisie @vsinghal13
1312
/sumologic/*_ingest_budget* @maimaisie @vsinghal13
1413
/sumologic/*_collector* @maimaisie @vsinghal13
15-
/sumologic/*_cse* @josh-williams @pmontiel-sumo
14+
/sumologic/*_cse* @pmontiel-sumo
1615
/website/docs/r/collector* @maimaisie @vsinghal13
1716
/website/docs/r/ingest_* @maimaisie @vsinghal13
1817
/website/docs/r/*_source* @maimaisie @vsinghal13

.github/workflows/test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,9 @@ jobs:
9898
SUMOLOGIC_TEST_ROLE_ARN: ${{ secrets.SUMOLOGIC_TEST_ROLE_ARN }}
9999
SUMOLOGIC_TEST_SAS_KEY: ${{ secrets.SUMOLOGIC_TEST_SAS_KEY }}
100100
SUMOLOGIC_TEST_SAS_KEY_NAME: ${{ secrets.SUMOLOGIC_TEST_SAS_KEY_NAME }}
101+
SUMOLOGIC_DATA_FORWARDING_BUCKET: ${{ secrets.SUMOLOGIC_DATA_FORWARDING_BUCKET }}
102+
SUMOLOGIC_DATA_FORWARDING_ROLE_ARN: ${{ secrets.SUMOLOGIC_DATA_FORWARDING_ROLE_ARN }}
103+
SUMOLOGIC_DATA_FORWARDING_AWS_REGION: ${{ secrets.SUMOLOGIC_DATA_FORWARDING_AWS_REGION }}
101104

102105
# disable go test timeout. We rely on GitHub action timeout.
103106
run: |

CHANGELOG.md

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,28 @@
1-
## 3.0.0 (Unreleased)
2-
DEPRECATIONS:
3-
* resource_sumologic_ingest_budget : Deprecated in favour of `resource_sumologic_ingest_budget_v2`.
1+
## X.Y.Z (Unreleased)
2+
* Add new change notes here
3+
4+
## 3.0.1 (January 17, 2025)
5+
**ENHANCEMENTS:**
6+
* Add support for update method to change state of the fields resource
7+
8+
## 3.0.0 (December 09, 2024)
9+
**REMOVALS:**
10+
* resource_sumologic_ingest_budget : remove deprecated resource.
11+
* resource_sumologic_collector_ingest_budget_assignment: remove deprecated resource.
12+
13+
**ENHANCEMENTS:**
14+
* Add support for MetricsAnomalyCondition to Monitor resource (GH-698)
15+
16+
**BUG FIXES:**
17+
* Fixed typo in connection.html.markdown documentation
18+
19+
## 2.31.5 (October 04, 2024)
20+
ENHANCEMENTS:
21+
* Added *index_id* attribute to sumologic_scheduled_view. (GH-691)
22+
* Added support for configuring sumologic_data_forwarding_rule for sumologic_scheduled_view. (GH-691)
23+
BUG FIXES:
24+
* Fix analytics_tier case sensitivity in resource_sumologic_partition (GH-692)
25+
* Remove regex match in resource_sumologic_log_search (GH-693)
426

527
## 2.31.4 (September 19, 2024)
628
* **New Resource:** sumologic_data_forwarding_destination (GH-678)
@@ -15,7 +37,7 @@ ENHANCEMENTS:
1537
* Add IsIncludedInDefaultSearch field to partition resource (GH-674)
1638

1739
BUG FIXES:
18-
* Fix cse_log_mappings resource conversion affecting import (GH-675)
40+
* Fix cse_log_mappings resource conversion affecting import (GH-675)
1941

2042
## 2.31.1 (July 2, 2024)
2143
BUG FIXES:

sumologic/provider.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ func Provider() terraform.ResourceProvider {
8787
"sumologic_cloudsyslog_source": resourceSumologicCloudsyslogSource(),
8888
"sumologic_role": resourceSumologicRole(),
8989
"sumologic_user": resourceSumologicUser(),
90-
"sumologic_ingest_budget": resourceSumologicIngestBudget(),
91-
"sumologic_collector_ingest_budget_assignment": resourceSumologicCollectorIngestBudgetAssignment(),
9290
"sumologic_folder": resourceSumologicFolder(),
9391
"sumologic_content": resourceSumologicContent(),
9492
"sumologic_scheduled_view": resourceSumologicScheduledView(),

sumologic/resource_sumologic_collector_ingest_budget_assignment.go

Lines changed: 0 additions & 90 deletions
This file was deleted.

sumologic/resource_sumologic_data_forwarding_destination.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ func resourceSumologicDataForwardingDestination() *schema.Resource {
6161
"enabled": {
6262
Type: schema.TypeBool,
6363
Optional: true,
64-
Default: false,
6564
},
6665
"s3_region": {
6766
Type: schema.TypeString,

sumologic/resource_sumologic_data_forwarding_rule.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,10 @@ func resourceSumologicDataForwardingRule() *schema.Resource {
3333
"enabled": {
3434
Type: schema.TypeBool,
3535
Optional: true,
36-
Default: true,
3736
},
3837
"file_format": {
3938
Type: schema.TypeString,
4039
Optional: true,
41-
Default: "{index}_{day}_{hour}_{minute}_{second}",
4240
},
4341
"payload_schema": {
4442
Type: schema.TypeString,

sumologic/resource_sumologic_data_forwarding_rule_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func TestAccSumologicDataForwardingRule_basic(t *testing.T) {
6060
testAccCheckDataForwardingRuleExists(),
6161
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "index_id", indexId),
6262
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "destination_id", destinationId),
63-
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "enabled", "true"),
63+
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "enabled", "false"),
6464
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "file_format", "test/"),
6565
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "payload_schema", "builtInFields"),
6666
resource.TestCheckResourceAttr(dataForwardingRuleResourceName, "format", "json"),
@@ -227,7 +227,7 @@ func testAccSumologicDataForwardingRuleUpdateConfig() string {
227227
resource "sumologic_data_forwarding_rule" "test" {
228228
index_id = "%s"
229229
destination_id = "%s"
230-
enabled = true
230+
enabled = false
231231
file_format = "test/"
232232
payload_schema = "builtInFields"
233233
format = "json"

sumologic/resource_sumologic_field.go

Lines changed: 39 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package sumologic
22

33
import (
4+
"errors"
45
"fmt"
56

67
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
@@ -10,6 +11,7 @@ func resourceSumologicField() *schema.Resource {
1011
return &schema.Resource{
1112
Create: resourceSumologicFieldCreate,
1213
Read: resourceSumologicFieldRead,
14+
Update: resourceSumologicFieldUpdate,
1315
Delete: resourceSumologicFieldDelete,
1416
Importer: &schema.ResourceImporter{
1517
State: resourceSumologicFieldImport,
@@ -38,7 +40,6 @@ func resourceSumologicField() *schema.Resource {
3840
"state": {
3941
Type: schema.TypeString,
4042
Optional: true,
41-
ForceNew: true,
4243
},
4344
},
4445
}
@@ -116,6 +117,43 @@ func resourceSumologicFieldImport(d *schema.ResourceData, meta interface{}) ([]*
116117
return []*schema.ResourceData{d}, nil
117118
}
118119

120+
func resourceSumologicFieldUpdate(d *schema.ResourceData, meta interface{}) error {
121+
c := meta.(*Client)
122+
123+
id := d.Get("field_id").(string)
124+
name := d.Get("field_name").(string)
125+
state := d.Get("state").(string)
126+
if id == "" {
127+
newId, err := c.FindFieldId(name)
128+
if err != nil {
129+
return err
130+
}
131+
id = newId
132+
}
133+
_, err := c.GetField(id)
134+
135+
if err != nil {
136+
return err
137+
}
138+
139+
if state == "Enabled" {
140+
err := c.EnableField(id)
141+
if err != nil {
142+
return err
143+
}
144+
} else if state == "Disabled" {
145+
err := c.DisableField(id)
146+
if err != nil {
147+
return err
148+
}
149+
} else {
150+
return errors.New("Invalid value of state field. Only Enabled or Disabled values are accepted")
151+
}
152+
153+
return resourceSumologicFieldRead(d, meta)
154+
155+
}
156+
119157
func resourceToField(d *schema.ResourceData) Field {
120158
return Field{
121159
DataType: d.Get("data_type").(string),

sumologic/resource_sumologic_field_test.go

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,41 @@ func TestAccSumologicField_create(t *testing.T) {
5656
})
5757
}
5858

59+
func TestAccSumologicField_update(t *testing.T) {
60+
var field Field
61+
testFieldName := "fields_provider_test"
62+
testDataType := "String"
63+
testState := "Enabled"
64+
updatedState := "Disabled"
65+
resource.Test(t, resource.TestCase{
66+
PreCheck: func() { testAccPreCheck(t) },
67+
Providers: testAccProviders,
68+
CheckDestroy: testAccCheckFieldDestroy(field),
69+
Steps: []resource.TestStep{
70+
{
71+
Config: testAccSumologicField(testFieldName, testDataType, testState),
72+
Check: resource.ComposeTestCheckFunc(
73+
testAccCheckFieldExists("sumologic_field.test", &field, t),
74+
testAccCheckFieldAttributes("sumologic_field.test"),
75+
resource.TestCheckResourceAttr("sumologic_field.test", "field_name", testFieldName),
76+
resource.TestCheckResourceAttr("sumologic_field.test", "data_type", testDataType),
77+
resource.TestCheckResourceAttr("sumologic_field.test", "state", testState),
78+
),
79+
},
80+
{
81+
Config: testAccSumologicFieldUpdate(testFieldName, testDataType, updatedState),
82+
Check: resource.ComposeTestCheckFunc(
83+
testAccCheckFieldExists("sumologic_field.test", &field, t),
84+
testAccCheckFieldAttributes("sumologic_field.test"),
85+
resource.TestCheckResourceAttr("sumologic_field.test", "field_name", testFieldName),
86+
resource.TestCheckResourceAttr("sumologic_field.test", "data_type", testDataType),
87+
resource.TestCheckResourceAttr("sumologic_field.test", "state", updatedState),
88+
),
89+
},
90+
},
91+
})
92+
}
93+
5994
func testAccCheckFieldDestroy(field Field) resource.TestCheckFunc {
6095
return func(s *terraform.State) error {
6196
client := testAccProvider.Meta().(*Client)
@@ -116,6 +151,16 @@ resource "sumologic_field" "test" {
116151
`, fieldName, dataType, state)
117152
}
118153

154+
func testAccSumologicFieldUpdate(fieldName string, dataType string, state string) string {
155+
return fmt.Sprintf(`
156+
resource "sumologic_field" "test" {
157+
field_name = "%s"
158+
data_type = "%s"
159+
state = "%s"
160+
}
161+
`, fieldName, dataType, state)
162+
}
163+
119164
func testAccCheckFieldAttributes(name string) resource.TestCheckFunc {
120165
return func(s *terraform.State) error {
121166
f := resource.ComposeTestCheckFunc(

0 commit comments

Comments
 (0)