SUMO-178423: added html documentation and minor refactoring

Author: Naman Goyal

sumologic/provider.go

@@ -92,7 +92,7 @@ func Provider() terraform.ResourceProvider {
 			"sumologic_folder":                                   resourceSumologicFolder(),
 			"sumologic_content":                                  resourceSumologicContent(),
 			"sumologic_scheduled_view":                           resourceSumologicScheduledView(),
-			"sumologic_s3_data_forwarding_destination":           resourceSumologicDataForwardingDestination(),
+			"sumologic_data_forwarding_destination":              resourceSumologicDataForwardingDestination(),
 			"sumologic_partition":                                resourceSumologicPartition(),
 			"sumologic_field_extraction_rule":                    resourceSumologicFieldExtractionRule(),
 			"sumologic_connection":                               resourceSumologicConnection(),

sumologic/resource_sumologic_data_forwarding.go renamed to sumologic/resource_sumologic_data_forwarding_destination.go

@@ -11,7 +11,7 @@ import (
 )
 
 func getTestParams() (string, string, string, string, string, string) {
-	dataForwardingResourceName := "sumologic_s3_data_forwarding_destination.test"
+	dataForwardingResourceName := "sumologic_data_forwarding_destination.test"
 	destinationName, description := getRandomizedDataForwardingParams()
 	testAwsRoleArn := os.Getenv("SUMOLOGIC_TEST_ROLE_ARN")
 	testAwsBucket := os.Getenv("SUMOLOGIC_TEST_BUCKET_NAME")
@@ -168,7 +168,7 @@ func testAccCheckDataForwardingDestroy() resource.TestCheckFunc {
 
 func testAccSumologicDataForwardingCreateConfig(destinationName string, description string, testAwsBucket string, testAwsRoleArn string, testAwsRegion string) string {
 	return fmt.Sprintf(`
-resource "sumologic_s3_data_forwarding_destination" "test" {
+resource "sumologic_data_forwarding_destination" "test" {
     destination_name = "%s"
 	description = "%s"
     bucket_name      = "%s"
@@ -184,7 +184,7 @@ resource "sumologic_s3_data_forwarding_destination" "test" {
 
 func testAccSumologicDataForwardingUpdateConfig(destinationName string, description string, testAwsBucket string, testAwsRoleArn string, testAwsRegion string) string {
 	return fmt.Sprintf(`
-resource "sumologic_s3_data_forwarding_destination" "test" {
+resource "sumologic_data_forwarding_destination" "test" {
     destination_name = "%s"
 	description = "%s"
     bucket_name      = "%s"

sumologic/resource_sumologic_data_forwarding_test.go renamed to sumologic/resource_sumologic_data_forwarding_destination_test.go

@@ -0,0 +1,41 @@
+---
+layout: "sumologic"
+page_title: "SumoLogic: sumologic_data_forwarding_destination"
+description: |-
+  Provides a Sumologic Data Forwarding Destination
+---
+
+# sumologic_data_forwarding_destination
+Provider to manage [Sumologic Data Forwarding Destination](https://help.sumologic.com/docs/manage/data-forwarding/amazon-s3-bucket/#configure-an-s3-data-forwarding-destination)
+
+## Example Usage
+```hcl
+resource "sumologic_data_forwarding_destination" "example_data_forwarding_destination" {
+    destination_name = "df-destination"
+    description = ""
+    bucket_name = "df-bucket"
+    region = "us-east-1"
+    authentication_mode = "RoleBased"
+    access_key_id = "accessKeyId"
+    secret_access_key = "secretAccessKey"
+    role_arn = "arn:aws:iam::some-valid-arn"
+    encrypted = "false"
+}
+```
+## Argument reference
+
+The following arguments are supported:
+
+- `destination_name` - (Required) Name of the S3 data forwarding destination.
+- `description` - (Optional) Description of the S3 data forwarding destination.
+- `bucket_name` - (Required) The name of the Amazon S3 bucket.
+- `region` - (Optional) The region where the S3 bucket is located.
+- `authentication_mode` - (Required) AWS IAM authentication method used for access. Possible values are: 1. `AccessKey` 2. `RoleBased`
+- `access_key_id` - (Optional) The AWS Access ID to access the S3 bucket.
+- `secret_access_key` - (Optional) The AWS Secret Key to access the S3 bucket.
+- `role_arn` - (Optional) The AWS Role ARN to access the S3 bucket.
+- `encrypted` - (Optional) Enable S3 server-side encryption.
+
+The following attributes are exported:
+
+- `id` - The internal ID of the data_forwarding_destination