SUMO-258848: refactors areAnalyticsTierEqual for brevity

Author: raghavxk

sumologic/resource_sumologic_partition.go

@@ -198,13 +198,13 @@ func resourceToPartition(d *schema.ResourceData) Partition {
 }
 
 func areAnalyticsTierEqual(a, b *string) bool {
-	if a == nil && b == nil {
-		return true
-	}
-
-	if a == nil || b == nil {
-		return false
+	coerceToStr := func(s *string) string {
+		if s == nil {
+			return ""
+		}
+		return *s
 	}
 
-	return strings.EqualFold(*a, *b)
+	return strings.EqualFold(coerceToStr(a), coerceToStr(b))
 }
+