Not forcing new resource in case of tag filter change or auth change

Drive-by
terraform import will support import of authentication also
secret_key will be "********" when imported (i.e. as returned by API)

Author: AvadheshKaria

sumologic/resource_sumologic_kinesis_metrics_source.go

@@ -37,7 +37,6 @@ func resourceSumologicKinesisMetricsSource() *schema.Resource {
 	kinesisMetricsSource.Schema["authentication"] = &schema.Schema{
 		Type:     schema.TypeList,
 		Required: true,
-		ForceNew: true,
 		MinItems: 1,
 		MaxItems: 1,
 		Elem: &schema.Resource{
@@ -66,7 +65,6 @@ func resourceSumologicKinesisMetricsSource() *schema.Resource {
 	kinesisMetricsSource.Schema["path"] = &schema.Schema{
 		Type:     schema.TypeList,
 		Required: true,
-		ForceNew: true,
 		MinItems: 1,
 		MaxItems: 1,
 		Elem: &schema.Resource{
@@ -163,12 +161,17 @@ func resourceSumologicKinesisMetricsSourceRead(d *schema.ResourceData, meta inte
 	}
 
 	kinesisMetricsResources := source.ThirdPartyRef.Resources
+	auth := getKinesisMetricsThirdPartyAuth(kinesisMetricsResources)
 	path := getKinesisMetricsThirdPartyPathAttributes(kinesisMetricsResources)
 
 	if err := d.Set("path", path); err != nil {
 		return err
 	}
 
+	if err := d.Set("authentication", auth); err != nil {
+		return err
+	}
+
 	if err := resourceSumologicSourceRead(d, source.Source); err != nil {
 		return fmt.Errorf("%s", err)
 	}
@@ -237,3 +240,23 @@ func getKinesisMetricsThirdPartyPathAttributes(pollingResource []PollingResource
 	}
 	return s
 }
+
+func getKinesisMetricsThirdPartyAuth(pollingResource []PollingResource) []map[string]interface{} {
+	auth := make(map[string]interface{})
+	pr := pollingResource[0]
+	auth["type"] = pr.Authentication.Type
+
+	if pr.Authentication.AwsID != "" {
+		auth["access_key"] = pr.Authentication.AwsID
+	}
+	if pr.Authentication.AwsKey != "" {
+		auth["secret_key"] = pr.Authentication.AwsKey
+	}
+	if pr.Authentication.RoleARN != "" {
+		auth["role_arn"] = pr.Authentication.RoleARN
+	}
+
+	var authArrary []map[string]interface{}
+	authArrary = append(authArrary, auth)
+	return authArrary
+}