SUMO-207606, address lint comments and appended tests to schema validations test case

Author: rmamilla-sumo

sumologic/resource_sumologic_monitors_library_monitor_test.go

@@ -104,6 +104,24 @@ func TestAccSumologicMonitorsLibraryMonitor_schemaValidations(t *testing.T) {
 			},
 		},
 	})
+
+	for _, monitorConfig := range allInvalidMonitors {
+		testNameSuffix := acctest.RandString(16)
+
+		testName := "terraform_test_invalid_monitor_" + testNameSuffix
+
+		resource.Test(t, resource.TestCase{
+			PreCheck:     func() { testAccPreCheck(t) },
+			Providers:    testAccProviders,
+			CheckDestroy: testAccCheckMonitorsLibraryMonitorDestroy(monitorsLibraryMonitor),
+			Steps: []resource.TestStep{
+				{
+					Config:      monitorConfig(testName),
+					ExpectError: regexp.MustCompile("config is invalid"),
+				},
+			},
+		})
+	}
 }
 
 func TestAccSumologicMonitorsLibraryMonitor_triggersTimeRangeDiffSuppression(t *testing.T) {
@@ -312,27 +330,6 @@ func TestAccSumologicMonitorsLibraryMonitor_create_all_monitor_types(t *testing.
 	}
 }
 
-func TestAccSumologicMonitorsLibraryMonitorFail_scenarios(t *testing.T) {
-	var monitorsLibraryMonitor MonitorsLibraryMonitor
-	for _, monitorConfig := range allInvalidMonitors {
-		testNameSuffix := acctest.RandString(16)
-
-		testName := "terraform_test_invalid_monitor_" + testNameSuffix
-
-		resource.Test(t, resource.TestCase{
-			PreCheck:     func() { testAccPreCheck(t) },
-			Providers:    testAccProviders,
-			CheckDestroy: testAccCheckMonitorsLibraryMonitorDestroy(monitorsLibraryMonitor),
-			Steps: []resource.TestStep{
-				{
-					Config:      monitorConfig(testName),
-					ExpectError: regexp.MustCompile("config is invalid"),
-				},
-			},
-		})
-	}
-}
-
 func TestAccSumologicMonitorsLibraryMonitor_update(t *testing.T) {
 	var monitorsLibraryMonitor MonitorsLibraryMonitor
 	testNameSuffix := acctest.RandString(16)