PR Feedback

Author: Josh Williams

sumologic/resource_sumologic_cse_custom_insight.go

@@ -30,8 +30,7 @@ func resourceSumologicCSECustomInsight() *schema.Resource {
 			},
 			"ordered": {
 				Type:     schema.TypeBool,
-				Optional: true,
-				Default:  false,
+				Required: true,
 			},
 			"rule_ids": {
 				Type:     schema.TypeList,
@@ -43,6 +42,7 @@ func resourceSumologicCSECustomInsight() *schema.Resource {
 			"severity": {
 				Type:     schema.TypeString,
 				Required: true,
+				ValidateFunc: validation.StringInSlice([]string{"HIGH", "MEDIUM", "LOW"}, false),
 			},
 			"signal_names": {
 				Type:     schema.TypeList,
@@ -53,7 +53,7 @@ func resourceSumologicCSECustomInsight() *schema.Resource {
 			},
 			"tags": {
 				Type:     schema.TypeList,
-				Optional: true,
+				Required: true,
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
 				},
@@ -95,7 +95,6 @@ func resourceSumologicCSECustomInsightDelete(d *schema.ResourceData, meta interf
 	c := meta.(*Client)
 
 	return c.DeleteCSECustomInsight(d.Id())
-
 }
 
 func resourceSumologicCSECustomInsightCreate(d *schema.ResourceData, meta interface{}) error {

website/docs/r/cse_custom_insight.html.markdown

@@ -28,10 +28,10 @@ The following arguments are supported:
 
 - `description` - (Required) The description of the generated Insights
 - `enabled` - (Required) Whether the Custom Insight should generate Insights
-- `ordered` - (Optional; defaults to false) Whether the signals matching the rule IDs/signal names must be in the same chronological order as they are listed in the Custom Insight
+- `ordered` - (Required) Whether the signals matching the rule IDs/signal names must be in the same chronological order as they are listed in the Custom Insight
 - `name` - (Required) The name of the Custom Insight and the generated Insights
 - `rule_ids` - (Optional) The Rule IDs to match to generate an Insight (exactly one of rule_ids or signal_names must be specified)
-- `severity` - (Required) The severity of the generated Insights
+- `severity` - (Required) The severity of the generated Insights (HIGH, MEDIUM, or LOW)
 - `signal_names` - (Optional) The Signal names to match to generate an Insight (exactly one of rule_ids or signal_names must be specified)
 - `tags` - (Required) The tags of the generated Insights