Merge pull request #750 from SumoLogic/erikatsumo-better-error

Improve error message when an API URL is constructed with missing parameters

Author: ErikAtSumo

CHANGELOG.md

@@ -1,6 +1,9 @@
 ## X.Y.Z (Unreleased)
 * Add new change notes here
 
+ENHANCEMENTS:
+* Improve error message when an API URL is constructed with missing parameters
+
 ## 3.0.8 (April 1, 2025)
 
 BUG FIXES:

sumologic/data_source_sumologic_folder.go

@@ -44,7 +44,7 @@ func dataSourceSumologicFolderRead(d *schema.ResourceData, meta interface{}) err
 }
 
 func (s *Client) GetFolderByPath(path string) (*Folder, error) {
-	data, _, err := s.Get(fmt.Sprintf("v2/content/path?path=%s", url.QueryEscape(path)))
+	data, err := s.Get(fmt.Sprintf("v2/content/path?path=%s", url.QueryEscape(path)))
 	if err != nil {
 		return nil, err
 	}

sumologic/data_source_sumologic_role.go

@@ -86,7 +86,7 @@ func dataSourceSumologicRoleRead(d *schema.ResourceData, meta interface{}) error
 }
 
 func (s *Client) GetRoleName(name string) (*Role, error) {
-	data, _, err := s.Get(fmt.Sprintf("v1/roles?name=%s", url.QueryEscape(name)))
+	data, err := s.Get(fmt.Sprintf("v1/roles?name=%s", url.QueryEscape(name)))
 	if err != nil {
 		return nil, err
 	}

sumologic/data_source_sumologic_role_v2.go

@@ -121,7 +121,7 @@ func dataSourceSumologicRoleV2Read(d *schema.ResourceData, meta interface{}) err
 }
 
 func (s *Client) GetRoleNameV2(name string) (*RoleV2, error) {
-	data, _, err := s.Get(fmt.Sprintf("v2/roles?name=%s", url.QueryEscape(name)))
+	data, err := s.Get(fmt.Sprintf("v2/roles?name=%s", url.QueryEscape(name)))
 	if err != nil {
 		return nil, err
 	}

sumologic/data_source_sumologic_user.go

@@ -91,7 +91,7 @@ func dataSourceSumologicUserRead(d *schema.ResourceData, meta interface{}) error
 }
 
 func (s *Client) GetUserByEmail(email string) (*User, error) {
-	data, _, err := s.Get(fmt.Sprintf("v1/users?email=%s", url.QueryEscape(email)))
+	data, err := s.Get(fmt.Sprintf("v1/users?email=%s", url.QueryEscape(email)))
 	if err != nil {
 		return nil, err
 	}

sumologic/resource_sumologic_monitors_library_monitor_test.go

@@ -1504,7 +1504,7 @@ func exampleSloBurnRateMonitor(testName string) string {
 }
 
 func exampleLogsAnomalyMonitor(testName string) string {
-	query := "_sourceCategory=api error | timeslice 5m | count by _sourceHost"
+	query := "_sourceCategory=api error | timeslice 5m | count by _timeslice"
 	return exampleMonitorWithTriggerCondition(
 		testName,
 		"Logs",

sumologic/sumologic_app.go

@@ -9,7 +9,7 @@ import (
 
 func (s *Client) GetAppInstance(id string) (*AppInstance, error) {
 	url := fmt.Sprintf("v2/apps/instances/%s", id)
-	data, _, err := s.Get(url)
+	data, err := s.Get(url)
 	if err != nil {
 		return nil, err
 	}
@@ -47,7 +47,7 @@ func (s *Client) CreateAppInstance(uuid string, appInstallPayload AppInstallPayl
 	}
 
 	var appInstallResponse AppInstallResponse
-	b, _, _ := s.Get(url)
+	b, _ := s.Get(url)
 	err = json.Unmarshal(b, &appInstallResponse)
 	if err != nil {
 		return "", err
@@ -96,7 +96,7 @@ func (s *Client) UpdateAppInstance(uuid string, appInstallPayload AppInstallPayl
 	}
 
 	var appInstallResponse AppInstallResponse
-	b, _, _ := s.Get(url)
+	b, _ := s.Get(url)
 	err = json.Unmarshal(b, &appInstallResponse)
 	if err != nil {
 		return "", err