Skip to content

Commit f9ce3a1

Browse files
authored
Merge pull request #39 from SumoLogic/hpal_replace_bucket-name
SUMO-211128: Replaced S3 bucket name to fix security issue
2 parents a95fdd3 + 6ae1939 commit f9ce3a1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

examples/aws_cloudtrail.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module "sumologic-cloudtrail-apps" {
1818
"description" = "This source is ceated a.",
1919
"bucket_details" = {
2020
"create_bucket" = false,
21-
"bucket_name" = "sumologic-aws-observability-templates",
21+
"bucket_name" = "YourS3BucketName",
2222
"path_expression" = "AWSLogs/*/CloudTrail/us-east-1/*",
2323
"force_destroy_bucket" = true
2424
},

terratest/run_tests.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function set_env_variables()
5959
local type="$1"
6060
if [[ "${type}" = *"cloudtrail"* ]];then
6161
echo "Setting env variables for ${type}"
62-
export BUCKET_NAME="sumologic-aws-observability-templates"
62+
export BUCKET_NAME="<YourS3BucketName>"
6363
export PATH_EXPRESSION="AWSLogs/<AWS_ACCOUNT_ID>/CloudTrail/us-east-1/*"
6464
export IAM_ROLE="arn:aws:iam::<AWS_ACCOUNT_ID>:role/TestingTerraformCloudTrailRole"
6565
export TOPIC_ARN="arn:aws:sns:us-east-1:<AWS_ACCOUNT_ID>:dynamodb"
@@ -72,21 +72,21 @@ function set_env_variables()
7272
export COLLECTOR_ID="<COLLECTOR_ID>"
7373
elif [[ "${type}" = *"elb"* ]];then
7474
echo "Setting env variables for ${type}"
75-
export BUCKET_NAME_US_WEST_1="cf-templates-1qpf3unpuo1hw-us-west-1"
75+
export BUCKET_NAME_US_WEST_1="<YourS3BucketName>-us-west-1"
7676
export PATH_EXPRESSION_US_WEST_1="*AWSLogs/<AWS_ACCOUNT_ID>/elasticloadbalancing/us-west-1/*"
7777
export TOPIC_ARN_US_WEST_1="arn:aws:sns:us-west-1:<AWS_ACCOUNT_ID>:dynamodb"
78-
export BUCKET_NAME_AP_SOUTH_1="cf-templates-1qpf3unpuo1hw-ap-south-1"
78+
export BUCKET_NAME_AP_SOUTH_1="<YourS3BucketName>-ap-south-1"
7979
export PATH_EXPRESSION_AP_SOUTH_1="*AWSLogs/<AWS_ACCOUNT_ID>/elasticloadbalancing/ap-south-1/*"
8080
export IAM_ROLE="arn:aws:iam::<AWS_ACCOUNT_ID>:role/TestingTerraformCloudTrailRole"
8181
export COLLECTOR_ID="<COLLECTOR_ID>"
8282
elif [[ "${type}" = *"kinesisfirehoseforlogs"* ]];then
8383
echo "Setting env variables for ${type}"
84-
export BUCKET_NAME_US_WEST_1="cf-templates-1qpf3unpuo1hw-us-west-1"
84+
export BUCKET_NAME_US_WEST_1="<YourS3BucketName>-us-west-1"
8585
export COLLECTOR_ID="<COLLECTOR_ID>"
8686
elif [[ "${type}" = *"kinesisfirehoseformetrics"* ]];then
8787
echo "Setting env variables for ${type}"
88-
export BUCKET_NAME_US_WEST_1="cf-templates-1qpf3unpuo1hw-us-west-1"
89-
export BUCKET_NAME_AP_SOUTH_1="cf-templates-1qpf3unpuo1hw-ap-south-1"
88+
export BUCKET_NAME_US_WEST_1="<YourS3BucketName>-us-west-1"
89+
export BUCKET_NAME_AP_SOUTH_1="<YourS3BucketName>-ap-south-1"
9090
export IAM_ROLE="arn:aws:iam::<AWS_ACCOUNT_ID>:role/TestingTerraformCloudTrailRole"
9191
export COLLECTOR_ID="<COLLECTOR_ID>"
9292
elif [[ "${type}" = *"rootcause"* ]];then

0 commit comments

Comments
 (0)