Commit 033a59a
meson: fix some implicit ordering dependencies on generated headers (linuxmint#716)
Given sufficiently high or simply random parallelism, it was possible to
build various source files that included this generated header, without
having coincidentally built the header previously. It then failed to
compile, since there was no actual guarantee the header would come
first. Add explicit header-only dependencies by adding the header as
additional sources to targets that draw it in.
Fixes:
```
* QA Notice: missing ninja dependencies in /var/tmp/portage/x11-wm/muffin-6.4.1/work/muffin-6.4.1-build:
[...]
* Processed 517 nodes.
* Error: There are 249 missing dependency paths.
* 249 targets had depfile dependencies on 1 distinct generated inputs (from 1 rules) without a non-depfile dep path to the generator.
* There might be build flakiness if any of the targets listed above are built alone, or not late enough, in a clean output directory.
```
Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>1 parent 1c739ba commit 033a59a
File tree
3 files changed
+4
-1
lines changed- clutter/clutter
- src
- compositor/plugins
3 files changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
421 | 421 | | |
422 | 422 | | |
423 | 423 | | |
| 424 | + | |
424 | 425 | | |
425 | 426 | | |
426 | 427 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
903 | 903 | | |
904 | 904 | | |
905 | 905 | | |
| 906 | + | |
906 | 907 | | |
907 | 908 | | |
908 | 909 | | |
| |||
933 | 934 | | |
934 | 935 | | |
935 | 936 | | |
| 937 | + | |
936 | 938 | | |
937 | 939 | | |
938 | 940 | | |
| |||
0 commit comments