From 7105ae024d6a82d915b43d14506aade8e3e76c6d Mon Sep 17 00:00:00 2001
From: Joseph S <11660030+joseph-sch@users.noreply.github.com>
Date: Wed, 6 Apr 2022 17:15:19 +0300
Subject: [PATCH] Fix bad units in call to pvlib.pvsystem.sapm

pvlib.pvsystem.sapm expects the irradiance in W/m2 so the irradiance values from `TEST_MAT` do *not* need to be divided by 1,000.

This should fix a failed assertion in `example.py` at line 33.
---
 pvmismatch/contrib/gen_coeffs/__init__.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pvmismatch/contrib/gen_coeffs/__init__.py b/pvmismatch/contrib/gen_coeffs/__init__.py
index 8cf0b07..d211f3e 100644
--- a/pvmismatch/contrib/gen_coeffs/__init__.py
+++ b/pvmismatch/contrib/gen_coeffs/__init__.py
@@ -24,7 +24,8 @@ def gen_iec_61853_from_sapm(pvmodule):
     Module is a dictionary according to ``pvlib.pvsystem.sapm``.
     """
     tc, irr = TEST_MAT
-    return sapm(irr / 1000.0, tc, pvmodule)
+    # sapm in pvlib.pvsystem expects effective_irradiance in W/m2, temp_cell in degrees Celsius
+    return sapm(irr, tc, pvmodule)
 
 
 def gen_two_diode(isc, voc, imp, vmp, nseries, nparallel,