wip

Author: Julusian

packages/documentation/versioned_docs/version-1.50.0/for-developers/device-integrations/intro.md

@@ -9,7 +9,7 @@ In order to understand all about writing TSR integrations there are some concept
 - [TSR Types package](./tsr-types)
 - [TSR Actions](./tsr-actions)
 
-But to start of we will explain the general structure of the TSR. Any user of the TSR will interface primarily with the Conductor class. Primarily the user will input device configurations, mappings and timelines into the TSR. The timeline describes the entire state of all of the devices over time. It does this by putting objects on timeline layers. Every timeline layer maps to a specific part of the device, this is configured through the mappings.
+But to start off we will explain the general structure of the TSR. Any user of the TSR will interface primarily with the Conductor class. Primarily the user will input device configurations, mappings and timelines into the TSR. The timeline describes the entire state of all of the devices over time. It does this by putting objects on timeline layers. Every timeline layer maps to a specific part of the device, this is configured through the mappings.
 
 The timeline is converted into disctinct states at different points in time, and these states are fed to the individual integrations. As an integration developer you shouldn't have to worry about keeping track of this. It is most important that you expose \(a\) a method to convert from a Timeline State to a Device State, \(b\) a method for diffing 2 device states and (c) a way to send commands to the device. We'll dive deeper into this in [TSR Integration API](./tsr-api).
 

packages/documentation/versioned_docs/version-1.51.0/for-developers/device-integrations/intro.md

@@ -9,7 +9,7 @@ In order to understand all about writing TSR integrations there are some concept
 - [TSR Types package](./tsr-types)
 - [TSR Actions](./tsr-actions)
 
-But to start of we will explain the general structure of the TSR. Any user of the TSR will interface primarily with the Conductor class. Primarily the user will input device configurations, mappings and timelines into the TSR. The timeline describes the entire state of all of the devices over time. It does this by putting objects on timeline layers. Every timeline layer maps to a specific part of the device, this is configured through the mappings.
+But to start off we will explain the general structure of the TSR. Any user of the TSR will interface primarily with the Conductor class. Primarily the user will input device configurations, mappings and timelines into the TSR. The timeline describes the entire state of all of the devices over time. It does this by putting objects on timeline layers. Every timeline layer maps to a specific part of the device, this is configured through the mappings.
 
 The timeline is converted into disctinct states at different points in time, and these states are fed to the individual integrations. As an integration developer you shouldn't have to worry about keeping track of this. It is most important that you expose \(a\) a method to convert from a Timeline State to a Device State, \(b\) a method for diffing 2 device states and (c) a way to send commands to the device. We'll dive deeper into this in [TSR Integration API](./tsr-api).
 

packages/webui/src/client/ui/Settings/ShowStyle/HotkeyLegend.tsx

@@ -39,15 +39,20 @@ export function HotkeyLegendSettings({ showStyleBase }: IHotkeyLegendSettingsPro
 	}, [showStyleBase._id])
 
 	const exportHotkeyJSON = useCallback(() => {
+		if (!showStyleBase.hotkeyLegend) return
+
 		const jsonStr = JSON.stringify(showStyleBase.hotkeyLegend, undefined, 4)
 
 		const element = document.createElement('a')
-		element.href = URL.createObjectURL(new Blob([jsonStr], { type: 'application/json' }))
+		const url = URL.createObjectURL(new Blob([jsonStr], { type: 'application/json' }))
+		element.href = url
 		element.download = `${showStyleBase._id}_${showStyleBase.name.replace(/\W/g, '_')}_hotkeys.json`
 
 		document.body.appendChild(element) // Required for this to work in FireFox
 		element.click()
 		document.body.removeChild(element) // Required for this to work in FireFox
+
+		URL.revokeObjectURL(url)
 	}, [showStyleBase._id, showStyleBase.hotkeyLegend, showStyleBase.name])
 
 	const onDeleteHotkeyLegend = useCallback(
@@ -133,7 +138,12 @@ export function HotkeyLegendSettings({ showStyleBase }: IHotkeyLegendSettingsPro
 					<FontAwesomeIcon icon={faPlus} />
 				</Button>
 
-				<Button variant="outline-secondary" className="mx-1" onClick={exportHotkeyJSON}>
+				<Button
+					variant="outline-secondary"
+					className="mx-1"
+					onClick={exportHotkeyJSON}
+					disabled={!showStyleBase.hotkeyLegend || showStyleBase.hotkeyLegend.length === 0}
+				>
 					<FontAwesomeIcon icon={faDownload} />
 					<span>{t('Export')}</span>
 				</Button>

packages/webui/src/client/ui/Settings/SnapshotsView.tsx

@@ -114,9 +114,9 @@ export default function SnapshotsView(): JSX.Element {
 					<tbody>
 						<tr>
 							<th></th>
-							<th>Type</th>
-							<th>Name</th>
-							<th>Comment</th>
+							<th>{t('Type')}</th>
+							<th>{t('Name')}</th>
+							<th>{t('Comment')}</th>
 							{removeSnapshots ? <th></th> : null}
 						</tr>
 						{snapshots.map((snapshot) => {
@@ -294,7 +294,7 @@ function RestoreStoredSnapshotButton({ snapshotId }: { snapshotId: SnapshotId })
 				},
 			})
 		}
-	}, [snapshotId])
+	}, [t, snapshotId])
 
 	return (
 		<Button variant="outline-secondary" onClick={restoreStoredSnapshot}>
@@ -321,15 +321,15 @@ function TakeSystemSnapshotButton({ studioId }: { studioId: StudioId | null }) {
 			.catch((err) => {
 				logger.error(err)
 				doModalDialog({
-					title: t('Restore Snapshot'),
-					message: t('Snapshot restore failed: {{errorMessage}}', { errorMessage: stringifyError(err) }),
+					title: t('Take System Snapshot'),
+					message: t('Take System Snapshot failed: {{errorMessage}}', { errorMessage: stringifyError(err) }),
 					acceptOnly: true,
 					onAccept: () => {
 						// nothing
 					},
 				})
 			})
-	}, [studioId])
+	}, [t, studioId])
 
 	const studioName = useTracker(() => (studioId ? Studios.findOne(studioId)?.name : null), [studioId])
 
@@ -369,7 +369,7 @@ function RemoveSnapshotButton({ snapshotId }: { snapshotId: SnapshotId }) {
 				},
 			})
 		}
-	}, [snapshotId])
+	}, [t, snapshotId])
 
 	return (
 		<Button variant="outline-secondary" onClick={removeStoredSnapshot}>