Handle drag and drop retime operations

Author: rjmunro

packages/blueprints/src/base/studio/userEditOperations/processIngestData.ts

@@ -1,5 +1,6 @@
 import {
 	DefaultUserOperationEditProperties,
+	DefaultUserOperationRetimePiece,
 	DefaultUserOperations,
 	DefaultUserOperationsTypes,
 	IngestChangeType,
@@ -118,14 +119,10 @@ async function applyUserOperation(
 /**
  * Process piece retiming operations from the UI.
  *
- * This function handles drag-and-drop retime operations on pieces in the Sofie Rundown Editor.
- * It modifies the underlying ingest data (objectTime and duration) for pieces within parts.
+ * This function handles drag-and-drop retime operations from the Sofie UI.
  *
- * Expected payload formats:
- * - { newTime: number, newDuration?: number }
- * - { deltaTime: number, deltaDuration?: number }
- * - { startTime: number }
- * - { timing: { start: number, duration?: number } }
+ * It updates the piece timing in the ingest data structure based on the new inPoint provided and
+ * locks the segment/part to prevent NRCS updates.
  *
  * @param context - The ingest data processing context
  * @param mutableIngestRundown - The mutable rundown being processed
@@ -139,7 +136,7 @@ function processRetimePiece(
 	changes: UserOperationChange<BlueprintsUserOperations | DefaultUserOperations>
 ) {
 	// Extract piece timing information from the operation
-	const operation = changes.operation as any // DefaultUserOperationRetimePiece would be the proper type
+	const operation = changes.operation as DefaultUserOperationRetimePiece
 
 	context.logDebug('Processing piece retime operation: ' + JSON.stringify(changes, null, 2))
 
@@ -150,12 +147,19 @@ function processRetimePiece(
 	}
 
 	// Find the part containing the piece
-	const part = mutableIngestRundown.findPart(operationTarget.partExternalId)
+	const partAndSegment = mutableIngestRundown.findPartAndSegment(operationTarget.partExternalId)
+	const { part, segment } = partAndSegment || {}
+
 	if (!part?.payload) {
 		context.logError(`Part not found for retime operation: ${operationTarget.partExternalId}`)
 		return
 	}
 
+	if (!segment) {
+		context.logError(`Segment not found for retime operation: ${operationTarget.segmentExternalId}`)
+		return
+	}
+
 	// Parse the part payload to access pieces
 	const partPayload: any = part.payload
 	if (!partPayload.pieces || !Array.isArray(partPayload.pieces)) {
@@ -199,7 +203,7 @@ function processRetimePiece(
 		context.logWarning(`Retime piece operation has unknown keys in payload: ${unknownKeys.join(', ')}`)
 	}
 
-	// Check if there are actually changes to apply (now comparing in the same units)
+	// Check if there are actually changes to apply
 	const timeDifference = Math.abs(newTime - originalTime)
 	if (timeDifference < 0.005) {
 		// Less than 5ms difference - consider it unchanged
@@ -216,39 +220,27 @@ function processRetimePiece(
 		objectTime: newTime,
 	}
 
+	// Lock segment to prevent NRCS updates:
+	segment.setUserEditState(BlueprintUserOperationTypes.LOCK_SEGMENT_NRCS_UPDATES, true)
+
+	// Mark both segment and part as user-edited
+	segment.setUserEditState(BlueprintUserOperationTypes.USER_EDITED, true)
+	part.setUserEditState(BlueprintUserOperationTypes.USER_EDITED, true)
+
 	// Update the piece in the part payload
 	partPayload.pieces[pieceIndex] = updatedPiece
 
 	// Mark the part as modified using replacePayload
 	part.replacePayload(partPayload)
 
-	// Mark the segment/part as having been edited by the user
-	// This helps track that the content has been modified from the original ingest
-	const partAndSegment = mutableIngestRundown.findPartAndSegment(operationTarget.partExternalId)
-	if (partAndSegment?.segment && partAndSegment?.part) {
-		// Mark both segment and part as user-edited
-		partAndSegment.segment.setUserEditState(BlueprintUserOperationTypes.USER_EDITED, true)
-		partAndSegment.part.setUserEditState(BlueprintUserOperationTypes.USER_EDITED, true)
-
-		// Create a unique user edit state key for this piece retime operation
-		// This ensures each retime operation creates a new state change, triggering persistence
-		const pieceRetimeKey = `${operation.id}_${operationTarget.pieceExternalId}_${Date.now()}`
-
-		// Store the retime operation as a user edit state
-		// Each retime gets a unique key to ensure state changes trigger persistence
-		partAndSegment.segment.setUserEditState(pieceRetimeKey, true)
-		partAndSegment.part.setUserEditState(pieceRetimeKey, true)
+	// Store the retime operation as a user edit state
+	// Each retime gets a unique key to ensure state changes trigger persistence
+	// This is a horrible hack.
+	// segment.setUserEditState(pieceRetimeKey, true)
+	const pieceRetimeKey = `${operation.id}_${operationTarget.pieceExternalId}_${Date.now()}`
+	part.setUserEditState(pieceRetimeKey, true)
 
-		// Also mark the specific operation that was performed
-		partAndSegment.segment.setUserEditState(operation.id, true)
-		partAndSegment.part.setUserEditState(operation.id, true)
-
-		// Lock both segment and part to prevent NRCS updates:
-		partAndSegment.segment.setUserEditState(BlueprintUserOperationTypes.LOCK_SEGMENT_NRCS_UPDATES, true)
-		partAndSegment.part.setUserEditState(BlueprintUserOperationTypes.LOCK_PART_NRCS_UPDATES, true)
-
-		context.logDebug(`Marked segment and part as user-edited and created unique retime state: ${pieceRetimeKey}`)
-	}
+	context.logDebug(`Marked segment and part as user-edited and created unique retime state: ${pieceRetimeKey}`)
 }
 
 function processUpdateProps(
@@ -358,6 +350,7 @@ function updatePieceProps(
 
 	const lifespan = operation.payload.globalProperties['lifespan']
 	context.logDebug('Update piece ' + operationTarget.pieceExternalId + ': ' + lifespan)
+	// TODO: Do we actually update anything here? We just seem to log.
 }
 
 function changeSource(