Skip to content

Commit 83f497e

Browse files
committed
Fix examples for Rolling
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
1 parent f05b087 commit 83f497e

3 files changed

Lines changed: 17 additions & 6 deletions

File tree

examples/example2_16/diffbot.launch.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
Command, LaunchConfiguration,
3030
PathJoinSubstitution, ThisLaunchFileDir
3131
)
32-
from launch_ros.actions import Node
32+
from launch_ros.actions import Node, SetParametersFromFile
3333
from launch_ros.substitutions import FindPackageShare
3434
from launch_ros2_control.actions import SpawnControllers
3535
from launch_ros2_control.descriptions import Controller
@@ -67,15 +67,17 @@ def generate_launch_description():
6767

6868
robot_description_content = LaunchConfiguration('robot_description_content')
6969

70+
diffbot_controller_parameters = PathJoinSubstitution([
71+
FindPackageShare('ros2_control_demo_example_2'),
72+
'config',
73+
'diffbot_controllers.yaml'
74+
])
75+
7076
ld.add_action(Node(
7177
package='controller_manager',
7278
executable='ros2_control_node',
7379
output='both',
74-
parameters=[PathJoinSubstitution([
75-
FindPackageShare('ros2_control_demo_example_2'),
76-
'config',
77-
'diffbot_controllers.yaml'
78-
])]))
80+
parameters=[diffbot_controller_parameters]))
7981

8082
ld.add_action(Node(
8183
package='robot_state_publisher',
@@ -86,6 +88,9 @@ def generate_launch_description():
8688
pid_controller_config_file = PathJoinSubstitution([
8789
ThisLaunchFileDir(), 'diffbot_pid_controllers.yaml'])
8890

91+
# Use global parameters to ensure parameter overriding happens in the correct order
92+
ld.add_action(SetParametersFromFile(diffbot_controller_parameters))
93+
8994
ld.add_action(SpawnControllers([
9095
Controller(
9196
name='pid_controller_left_wheel_joint',

examples/example2_16/diffbot.launch.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
<param name="robot_description" value="$(var robot_description_content)" />
3131
</node>
3232

33+
<!-- Use global parameters to ensure parameter overriding happens in the correct order -->
34+
<set_parameters_from_file filename="$(find-pkg-share ros2_control_demo_example_2)/config/diffbot_controllers.yaml"/>
3335

3436
<spawn_controller>
3537
<controller name="pid_controller_left_wheel_joint" if="$(var use_pid)">

examples/example2_16/diffbot.launch.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ launch:
4545
param:
4646
- { name: robot_description, value: $(var robot_description_content) }
4747

48+
# Use global parameters to ensure parameter overriding happens in the correct order
49+
- set_parameters_from_file:
50+
filename: $(find-pkg-share ros2_control_demo_example_2)/config/diffbot_controllers.yaml
51+
4852
- spawn_controller:
4953
controller:
5054
- name: pid_controller_left_wheel_joint

0 commit comments

Comments
 (0)