Download files: pass filename as const ref

tobbi · tobbi · commit 1268d3be3452 · 2022-05-31T04:28:57.000+02:00
diff --git a/src/supertux/menu/web_asset_menu.cpp b/src/supertux/menu/web_asset_menu.cpp
@@ -68,7 +68,7 @@ WebAssetMenu::menu_action(MenuItem& item)
     {
       std::vector<std::string> empty_vec;
       MenuManager::instance().push_menu(
-        std::make_unique<FileSystemMenu>(nullptr, empty_vec, "", false, [](std::string file) {
+        std::make_unique<FileSystemMenu>(nullptr, empty_vec, "", false, [](const std::string& file) {
           std::string fullpath(std::string(PHYSFS_getRealDir(file.c_str())) + "/" + file);
           FileSystem::open_path(fullpath);
         })

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ WebAssetMenu::menu_action(MenuItem& item)`
`68`	`68`	`{`
`69`	`69`	`std::vector<std::string> empty_vec;`
`70`	`70`	`MenuManager::instance().push_menu(`
`71`		`- std::make_unique<FileSystemMenu>(nullptr, empty_vec, "", false, [](std::string file) {`
	`71`	`+ std::make_unique<FileSystemMenu>(nullptr, empty_vec, "", false, [](const std::string& file) {`
`72`	`72`	`std::string fullpath(std::string(PHYSFS_getRealDir(file.c_str())) + "/" + file);`
`73`	`73`	`FileSystem::open_path(fullpath);`
`74`	`74`	`})`