Code quality

weluvgoatz · weluvgoatz · commit 7a24c8288a76 · 2022-01-06T22:16:18.000-08:00
diff --git a/src/editor/button_widget.cpp b/src/editor/button_widget.cpp
@@ -43,10 +43,10 @@ ButtonWidget::draw(DrawingContext& context)
   }
 
   if (m_grab) {
-    context.color().draw_filled_rect(m_rect, Color(g_config->editorgrabcolor), 4.0f,
+    context.color().draw_filled_rect(m_rect, g_config->editorgrabcolor, 4.0f,
                                      LAYER_GUI-5);
   } else if (m_hover) {
-    context.color().draw_filled_rect(m_rect, Color(g_config->editorhovercolor), 4.0f,
+    context.color().draw_filled_rect(m_rect, g_config->editorhovercolor, 4.0f,
                                      LAYER_GUI-5);
   }
 }
diff --git a/src/editor/layers_widget.cpp b/src/editor/layers_widget.cpp
@@ -65,7 +65,7 @@ EditorLayersWidget::draw(DrawingContext& context)
 
   context.color().draw_filled_rect(Rectf(Vector(0, static_cast<float>(m_Ypos)),
                                          Vector(static_cast<float>(m_Width), static_cast<float>(SCREEN_HEIGHT))),
-                                     Color(g_config->editorcolor),
+                                     g_config->editorcolor,
                                      0.0f,
                                      LAYER_GUI-10);
 
@@ -98,7 +98,7 @@ EditorLayersWidget::draw(DrawingContext& context)
 
   if (draw_rect)
   {
-    context.color().draw_filled_rect(target_rect, Color(g_config->editorhovercolor), 0.0f,
+    context.color().draw_filled_rect(target_rect, g_config->editorhovercolor, 0.0f,
                                        LAYER_GUI-5);
   }
 
diff --git a/src/editor/tip.cpp b/src/editor/tip.cpp
@@ -68,7 +68,7 @@ Tip::draw(DrawingContext& context, const Vector& pos)
   auto position = pos;
   position.y += 35;
   context.color().draw_text(Resources::normal_font, m_header, position,
-                              ALIGN_LEFT, LAYER_GUI-11, Color(g_config->labeltextcolor));
+                              ALIGN_LEFT, LAYER_GUI-11, g_config->labeltextcolor);
 
   for (const auto& str : m_strings) {
     position.y += 22;
diff --git a/src/editor/toolbox_widget.cpp b/src/editor/toolbox_widget.cpp
@@ -73,7 +73,7 @@ EditorToolboxWidget::draw(DrawingContext& context)
   context.color().draw_filled_rect(Rectf(Vector(static_cast<float>(m_Xpos), 0),
                                          Vector(static_cast<float>(context.get_width()),
                                                 static_cast<float>(context.get_height()))),
-                                     Color(g_config->editorcolor),
+                                     g_config->editorcolor,
                                      0.0f, LAYER_GUI-10);
   if (m_dragging) {
     context.color().draw_filled_rect(selection_draw_rect(), Color(0.2f, 0.4f, 1.0f, 0.6f),
@@ -83,7 +83,7 @@ EditorToolboxWidget::draw(DrawingContext& context)
   if (m_hovered_item != HoveredItem::NONE)
   {
     context.color().draw_filled_rect(get_item_rect(m_hovered_item),
-                                       Color(g_config->editorhovercolor),
+                                       g_config->editorhovercolor,
                                        0.0f, LAYER_GUI - 5);
   }
 
diff --git a/src/gui/dialog.cpp b/src/gui/dialog.cpp
@@ -220,7 +220,7 @@ Dialog::draw(DrawingContext& context)
   // draw HL line
   context.color().draw_filled_rect(Rectf(Vector(bg_rect.get_left(), bg_rect.get_bottom() - 35),
                                          Sizef(bg_rect.get_width(), 4)),
-                                   Color(g_config->hlcolor), LAYER_GUI);
+                                   g_config->hlcolor, LAYER_GUI);
   context.color().draw_filled_rect(Rectf(Vector(bg_rect.get_left(), bg_rect.get_bottom() - 35),
                                          Sizef(bg_rect.get_width(), 2)),
                                    Color(1.0f, 1.0f, 1.0f, 1.0f), LAYER_GUI);
@@ -252,7 +252,7 @@ Dialog::draw(DrawingContext& context)
     context.color().draw_text(Resources::normal_font, m_buttons[i].text,
                               Vector(pos.x, pos.y - static_cast<float>(int(Resources::normal_font->get_height() / 2))),
                               ALIGN_CENTER, LAYER_GUI,
-                              i == m_selected_button ? Color(g_config->activetextcolor) : ColorScheme::Menu::default_color);
+                              i == m_selected_button ? g_config->activetextcolor : ColorScheme::Menu::default_color);
   }
 }
 
diff --git a/src/gui/item_back.cpp b/src/gui/item_back.cpp
@@ -36,7 +36,7 @@ ItemBack::draw(DrawingContext& context, const Vector& pos, int menu_width, bool
   context.color().draw_text(Resources::normal_font, get_text(),
                             Vector( pos.x + static_cast<float>(menu_width) / 2.0f,
                                     pos.y - static_cast<float>(int(Resources::normal_font->get_height()/2))),
-                            ALIGN_CENTER, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_CENTER, LAYER_GUI, active ? g_config->activetextcolor : get_color());
   context.color().draw_surface(Resources::back,
                                Vector(pos.x + static_cast<float>(menu_width) / 2.0f + text_width / 2.0f  + 16.0f,
                                       pos.y - 8.0f),
diff --git a/src/gui/item_controlfield.cpp b/src/gui/item_controlfield.cpp
@@ -38,7 +38,7 @@ ItemControlField::draw(DrawingContext& context, const Vector& pos, int menu_widt
   context.color().draw_text(Resources::normal_font, get_text(),
                               Vector(pos.x + 16.0f,
                                      pos.y - static_cast<float>(int(Resources::normal_font->get_height()/2))),
-                              ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                              ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 }
 
 int
diff --git a/src/gui/item_floatfield.cpp b/src/gui/item_floatfield.cpp
@@ -57,7 +57,7 @@ ItemFloatField::draw(DrawingContext& context, const Vector& pos, int menu_width,
   context.color().draw_text(Resources::normal_font, get_text(),
                             Vector(pos.x + 16.0f,
                                    pos.y - Resources::normal_font->get_height() / 2.0f),
-                            ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 }
 
 int
diff --git a/src/gui/item_intfield.cpp b/src/gui/item_intfield.cpp
@@ -44,7 +44,7 @@ ItemIntField::draw(DrawingContext& context, const Vector& pos, int menu_width, b
   context.color().draw_text(Resources::normal_font, get_text(),
                             Vector(pos.x + 16.0f,
                                    pos.y - Resources::normal_font->get_height() / 2.0f),
-                            ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 }
 
 int
diff --git a/src/gui/item_label.cpp b/src/gui/item_label.cpp
@@ -37,7 +37,7 @@ ItemLabel::draw(DrawingContext& context, const Vector& pos, int menu_width, bool
 
 Color
 ItemLabel::get_color() const {
-  return Color(g_config->labeltextcolor);
+  return g_config->labeltextcolor;
 }
 
 int
diff --git a/src/gui/item_stringselect.cpp b/src/gui/item_stringselect.cpp
@@ -40,7 +40,7 @@ ItemStringSelect::draw(DrawingContext& context, const Vector& pos, int menu_widt
   context.color().draw_text(Resources::normal_font, get_text(),
                               Vector(pos.x + 16.0f,
                                      pos.y - Resources::normal_font->get_height() / 2.0f),
-                              ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                              ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 
   // Draw right side
   context.color().draw_surface(Resources::arrow_left,
@@ -54,7 +54,7 @@ ItemStringSelect::draw(DrawingContext& context, const Vector& pos, int menu_widt
   context.color().draw_text(Resources::normal_font, list[*selected],
                             Vector(pos.x + static_cast<float>(menu_width) - roff - 8.0f,
                                    pos.y - Resources::normal_font->get_height() / 2.0f),
-                            ALIGN_RIGHT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_RIGHT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 }
 
 int
diff --git a/src/gui/item_textfield.cpp b/src/gui/item_textfield.cpp
@@ -43,7 +43,7 @@ ItemTextField::draw(DrawingContext& context, const Vector& pos, int menu_width,
   context.color().draw_text(Resources::normal_font, get_text(),
                             Vector(pos.x + 16.0f,
                                    pos.y - static_cast<float>(Resources::normal_font->get_height()) / 2.0f),
-                            ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 }
 
 int
diff --git a/src/gui/item_toggle.cpp b/src/gui/item_toggle.cpp
@@ -45,7 +45,7 @@ ItemToggle::draw(DrawingContext& context, const Vector& pos, int menu_width, boo
 {
   context.color().draw_text(Resources::normal_font, get_text(),
                             Vector(pos.x + 16, pos.y - (Resources::normal_font->get_height()/2)),
-                            ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 
   if (m_get_func()) {
     context.color().draw_surface(Resources::checkbox_checked,
diff --git a/src/gui/menu.cpp b/src/gui/menu.cpp
@@ -613,12 +613,12 @@ Menu::draw(DrawingContext& context)
 
     context.color().draw_filled_rect(Rectf(text_rect.p1() - Vector(4,4),
                                            text_rect.p2() + Vector(4,4)),
-                                     Color(g_config->menuhelpbackcolor),
+                                     g_config->menuhelpbackcolor,
                                      g_config->menuroundness + 4.f,
                                      LAYER_GUI);
 
     context.color().draw_filled_rect(text_rect,
-                                     Color(g_config->menuhelpfrontcolor),
+                                     g_config->menuhelpfrontcolor,
                                      g_config->menuroundness,
                                      LAYER_GUI);
 
diff --git a/src/gui/menu_item.cpp b/src/gui/menu_item.cpp
@@ -54,7 +54,7 @@ MenuItem::draw(DrawingContext& context, const Vector& pos, int menu_width, bool
   context.color().draw_text(Resources::normal_font, m_text,
                             Vector( pos.x + static_cast<float>(menu_width) / 2.0f,
                                     pos.y - static_cast<float>(Resources::normal_font->get_height()) / 2.0f ),
-                            ALIGN_CENTER, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());
+                            ALIGN_CENTER, LAYER_GUI, active ? g_config->activetextcolor : get_color());
 }
 
 Color
diff --git a/src/gui/menu_manager.cpp b/src/gui/menu_manager.cpp
@@ -120,13 +120,13 @@ class MenuTransition final
     // draw menu background rectangles
     context.color().draw_filled_rect(Rectf(rect.get_left() - 4, rect.get_top() - 10-4,
                                              rect.get_right() + 4, rect.get_bottom() + 10 + 4),
-                                       Color(g_config->menubackcolor),
+                                       g_config->menubackcolor,
                                        g_config->menuroundness + 4.f,
                                        LAYER_GUI-10);
 
     context.color().draw_filled_rect(Rectf(rect.get_left(), rect.get_top() - 10,
                                              rect.get_right(), rect.get_bottom() + 10),
-                                       Color(g_config->menufrontcolor),
+                                       g_config->menufrontcolor,
                                        g_config->menuroundness,
                                        LAYER_GUI-10);
   }

Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,10 @@ ButtonWidget::draw(DrawingContext& context)`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`if (m_grab) {`
`46`		`- context.color().draw_filled_rect(m_rect, Color(g_config->editorgrabcolor), 4.0f,`
	`46`	`+ context.color().draw_filled_rect(m_rect, g_config->editorgrabcolor, 4.0f,`
`47`	`47`	`LAYER_GUI-5);`
`48`	`48`	`} else if (m_hover) {`
`49`		`- context.color().draw_filled_rect(m_rect, Color(g_config->editorhovercolor), 4.0f,`
	`49`	`+ context.color().draw_filled_rect(m_rect, g_config->editorhovercolor, 4.0f,`
`50`	`50`	`LAYER_GUI-5);`
`51`	`51`	`}`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ EditorLayersWidget::draw(DrawingContext& context)`
`65`	`65`
`66`	`66`	`context.color().draw_filled_rect(Rectf(Vector(0, static_cast<float>(m_Ypos)),`
`67`	`67`	`Vector(static_cast<float>(m_Width), static_cast<float>(SCREEN_HEIGHT))),`
`68`		`- Color(g_config->editorcolor),`
	`68`	`+ g_config->editorcolor,`
`69`	`69`	`0.0f,`
`70`	`70`	`LAYER_GUI-10);`
`71`	`71`
`@@ -98,7 +98,7 @@ EditorLayersWidget::draw(DrawingContext& context)`
`98`	`98`
`99`	`99`	`if (draw_rect)`
`100`	`100`	`{`
`101`		`- context.color().draw_filled_rect(target_rect, Color(g_config->editorhovercolor), 0.0f,`
	`101`	`+ context.color().draw_filled_rect(target_rect, g_config->editorhovercolor, 0.0f,`
`102`	`102`	`LAYER_GUI-5);`
`103`	`103`	`}`
`104`	`104`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ ItemControlField::draw(DrawingContext& context, const Vector& pos, int menu_widt`
`38`	`38`	`context.color().draw_text(Resources::normal_font, get_text(),`
`39`	`39`	`Vector(pos.x + 16.0f,`
`40`	`40`	`pos.y - static_cast<float>(int(Resources::normal_font->get_height()/2))),`
`41`		`- ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());`
	`41`	`+ ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`int`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ ItemFloatField::draw(DrawingContext& context, const Vector& pos, int menu_width,`
`57`	`57`	`context.color().draw_text(Resources::normal_font, get_text(),`
`58`	`58`	`Vector(pos.x + 16.0f,`
`59`	`59`	`pos.y - Resources::normal_font->get_height() / 2.0f),`
`60`		`- ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());`
	`60`	`+ ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`int`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ ItemIntField::draw(DrawingContext& context, const Vector& pos, int menu_width, b`
`44`	`44`	`context.color().draw_text(Resources::normal_font, get_text(),`
`45`	`45`	`Vector(pos.x + 16.0f,`
`46`	`46`	`pos.y - Resources::normal_font->get_height() / 2.0f),`
`47`		`- ALIGN_LEFT, LAYER_GUI, active ? Color(g_config->activetextcolor) : get_color());`
	`47`	`+ ALIGN_LEFT, LAYER_GUI, active ? g_config->activetextcolor : get_color());`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`int`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ ItemLabel::draw(DrawingContext& context, const Vector& pos, int menu_width, bool`
`37`	`37`
`38`	`38`	`Color`
`39`	`39`	`ItemLabel::get_color() const {`
`40`		`- return Color(g_config->labeltextcolor);`
	`40`	`+ return g_config->labeltextcolor;`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`int`