fix(lint): resolve golangci-lint errors found during QA verification

- Fix errcheck errors in pkg/controller/storage.go for unmarshalJSON calls
- Fix ineffassign in pkg/exporters/http/report.go
- Fix ineffassign in test/integration/config/config_reload_test.go
- Add nolint directive for gosec G404 in pinger.go (ping ID doesn't need crypto/rand)
- Run gofmt on multiple files to fix formatting issues

QA Verification Status:
- Build: PASSED
- Lint: PASSED
- Tests: ALL PASSING (unit + integration)
- QA Agent Review: PASSED (all 5 phases verified)
- Devils Advocate: PASSED (implementation confirmed legitimate)

Author: mattmattox

pkg/controller/events.go

@@ -18,27 +18,27 @@ import (
 // Event reasons for different scenarios
 const (
 	// Cluster health events
-	EventReasonClusterDegraded       = "ClusterDegraded"
-	EventReasonClusterCritical       = "ClusterCritical"
-	EventReasonClusterRecovered      = "ClusterRecovered"
-	EventReasonNodeHealthChanged     = "NodeHealthChanged"
+	EventReasonClusterDegraded   = "ClusterDegraded"
+	EventReasonClusterCritical   = "ClusterCritical"
+	EventReasonClusterRecovered  = "ClusterRecovered"
+	EventReasonNodeHealthChanged = "NodeHealthChanged"
 
 	// Problem events
-	EventReasonProblemDetected       = "ProblemDetected"
-	EventReasonProblemResolved       = "ProblemResolved"
-	EventReasonClusterWideProblem    = "ClusterWideProblem"
+	EventReasonProblemDetected    = "ProblemDetected"
+	EventReasonProblemResolved    = "ProblemResolved"
+	EventReasonClusterWideProblem = "ClusterWideProblem"
 
 	// Correlation events
-	EventReasonCorrelationDetected   = "CorrelationDetected"
-	EventReasonCorrelationResolved   = "CorrelationResolved"
+	EventReasonCorrelationDetected = "CorrelationDetected"
+	EventReasonCorrelationResolved = "CorrelationResolved"
 
 	// Remediation events
-	EventReasonLeaseGranted          = "RemediationLeaseGranted"
-	EventReasonLeaseDenied           = "RemediationLeaseDenied"
-	EventReasonLeaseExpired          = "RemediationLeaseExpired"
-	EventReasonRemediationStarted    = "RemediationStarted"
-	EventReasonRemediationCompleted  = "RemediationCompleted"
-	EventReasonRemediationFailed     = "RemediationFailed"
+	EventReasonLeaseGranted         = "RemediationLeaseGranted"
+	EventReasonLeaseDenied          = "RemediationLeaseDenied"
+	EventReasonLeaseExpired         = "RemediationLeaseExpired"
+	EventReasonRemediationStarted   = "RemediationStarted"
+	EventReasonRemediationCompleted = "RemediationCompleted"
+	EventReasonRemediationFailed    = "RemediationFailed"
 )
 
 // Event types
@@ -49,16 +49,16 @@ const (
 
 // EventRecorder creates Kubernetes Events for cluster-level issues
 type EventRecorder struct {
-	client           kubernetes.Interface
-	namespace        string
-	enabled          bool
-	controllerName   string
-	componentName    string
+	client         kubernetes.Interface
+	namespace      string
+	enabled        bool
+	controllerName string
+	componentName  string
 
 	// Rate limiting to prevent event spam
-	mu               sync.RWMutex
-	lastEventTime    map[string]time.Time
-	rateLimitPeriod  time.Duration
+	mu              sync.RWMutex
+	lastEventTime   map[string]time.Time
+	rateLimitPeriod time.Duration
 }
 
 // EventRecorderConfig holds configuration for the EventRecorder

pkg/controller/events_test.go

@@ -11,10 +11,10 @@ import (
 
 func TestNewEventRecorder(t *testing.T) {
 	tests := []struct {
-		name      string
-		config    *EventRecorderConfig
-		wantErr   bool
-		wantNil   bool
+		name        string
+		config      *EventRecorderConfig
+		wantErr     bool
+		wantNil     bool
 		wantEnabled bool
 	}{
 		{
@@ -159,19 +159,19 @@ func TestEventRecorder_RecordClusterHealthChange(t *testing.T) {
 	ctx := context.Background()
 
 	tests := []struct {
-		name            string
-		status          *ClusterStatus
-		previousHealth  HealthStatus
-		expectEvent     bool
-		expectedReason  string
+		name           string
+		status         *ClusterStatus
+		previousHealth HealthStatus
+		expectEvent    bool
+		expectedReason string
 	}{
 		{
 			name: "critical cluster creates event",
 			status: &ClusterStatus{
-				OverallHealth:  HealthStatusCritical,
-				TotalNodes:     10,
-				CriticalNodes:  3,
-				DegradedNodes:  2,
+				OverallHealth: HealthStatusCritical,
+				TotalNodes:    10,
+				CriticalNodes: 3,
+				DegradedNodes: 2,
 			},
 			previousHealth: HealthStatusDegraded,
 			expectEvent:    true,
@@ -180,10 +180,10 @@ func TestEventRecorder_RecordClusterHealthChange(t *testing.T) {
 		{
 			name: "degraded cluster creates event",
 			status: &ClusterStatus{
-				OverallHealth:  HealthStatusDegraded,
-				TotalNodes:     10,
-				DegradedNodes:  3,
-				HealthyNodes:   7,
+				OverallHealth: HealthStatusDegraded,
+				TotalNodes:    10,
+				DegradedNodes: 3,
+				HealthyNodes:  7,
 			},
 			previousHealth: HealthStatusHealthy,
 			expectEvent:    true,
@@ -192,9 +192,9 @@ func TestEventRecorder_RecordClusterHealthChange(t *testing.T) {
 		{
 			name: "recovery creates event",
 			status: &ClusterStatus{
-				OverallHealth:  HealthStatusHealthy,
-				TotalNodes:     10,
-				HealthyNodes:   10,
+				OverallHealth: HealthStatusHealthy,
+				TotalNodes:    10,
+				HealthyNodes:  10,
 			},
 			previousHealth: HealthStatusCritical,
 			expectEvent:    true,
@@ -203,9 +203,9 @@ func TestEventRecorder_RecordClusterHealthChange(t *testing.T) {
 		{
 			name: "healthy to healthy no event",
 			status: &ClusterStatus{
-				OverallHealth:  HealthStatusHealthy,
-				TotalNodes:     10,
-				HealthyNodes:   10,
+				OverallHealth: HealthStatusHealthy,
+				TotalNodes:    10,
+				HealthyNodes:  10,
 			},
 			previousHealth: HealthStatusHealthy,
 			expectEvent:    false,

pkg/controller/storage.go

@@ -526,9 +526,15 @@ func (s *SQLiteStorage) GetCorrelation(ctx context.Context, id string) (*Correla
 		return nil, fmt.Errorf("failed to get correlation: %w", err)
 	}
 
-	unmarshalJSON(affectedNodes, &correlation.AffectedNodes)
-	unmarshalJSON(problemTypes, &correlation.ProblemTypes)
-	unmarshalJSON(metadata, &correlation.Metadata)
+	if err := unmarshalJSON(affectedNodes, &correlation.AffectedNodes); err != nil {
+		return nil, fmt.Errorf("failed to unmarshal affected nodes: %w", err)
+	}
+	if err := unmarshalJSON(problemTypes, &correlation.ProblemTypes); err != nil {
+		return nil, fmt.Errorf("failed to unmarshal problem types: %w", err)
+	}
+	if err := unmarshalJSON(metadata, &correlation.Metadata); err != nil {
+		return nil, fmt.Errorf("failed to unmarshal metadata: %w", err)
+	}
 
 	return &correlation, nil
 }
@@ -560,9 +566,15 @@ func (s *SQLiteStorage) GetActiveCorrelations(ctx context.Context) ([]*Correlati
 			return nil, fmt.Errorf("failed to scan correlation: %w", err)
 		}
 
-		unmarshalJSON(affectedNodes, &correlation.AffectedNodes)
-		unmarshalJSON(problemTypes, &correlation.ProblemTypes)
-		unmarshalJSON(metadata, &correlation.Metadata)
+		if err := unmarshalJSON(affectedNodes, &correlation.AffectedNodes); err != nil {
+			return nil, fmt.Errorf("failed to unmarshal affected nodes: %w", err)
+		}
+		if err := unmarshalJSON(problemTypes, &correlation.ProblemTypes); err != nil {
+			return nil, fmt.Errorf("failed to unmarshal problem types: %w", err)
+		}
+		if err := unmarshalJSON(metadata, &correlation.Metadata); err != nil {
+			return nil, fmt.Errorf("failed to unmarshal metadata: %w", err)
+		}
 
 		correlations = append(correlations, &correlation)
 	}

pkg/controller/storage_test.go

@@ -406,7 +406,7 @@ func TestSQLiteStorage_Correlations(t *testing.T) {
 			Severity:      "critical", // Updated severity
 			Status:        "active",
 			Message:       "Multiple nodes experiencing DNS issues",
-			Confidence:    0.95, // Updated confidence
+			Confidence:    0.95,                                             // Updated confidence
 			AffectedNodes: []string{"node-1", "node-2", "node-3", "node-4"}, // Added node
 			DetectedAt:    time.Now(),
 			UpdatedAt:     time.Now(),

pkg/controller/types.go

@@ -96,38 +96,38 @@ type NodeStats struct {
 
 // ClusterStatus represents the overall cluster health status
 type ClusterStatus struct {
-	Timestamp       time.Time      `json:"timestamp"`
-	OverallHealth   HealthStatus   `json:"overallHealth"`
-	TotalNodes      int            `json:"totalNodes"`
-	HealthyNodes    int            `json:"healthyNodes"`
-	DegradedNodes   int            `json:"degradedNodes"`
-	CriticalNodes   int            `json:"criticalNodes"`
-	UnknownNodes    int            `json:"unknownNodes"`
-	ActiveProblems  int            `json:"activeProblems"`
-	Correlations    int            `json:"activeCorrelations"`
-	NodeSummaries   []NodeSummary  `json:"nodeSummaries,omitempty"`
-	RecentProblems  []ClusterProblem `json:"recentProblems,omitempty"`
+	Timestamp      time.Time        `json:"timestamp"`
+	OverallHealth  HealthStatus     `json:"overallHealth"`
+	TotalNodes     int              `json:"totalNodes"`
+	HealthyNodes   int              `json:"healthyNodes"`
+	DegradedNodes  int              `json:"degradedNodes"`
+	CriticalNodes  int              `json:"criticalNodes"`
+	UnknownNodes   int              `json:"unknownNodes"`
+	ActiveProblems int              `json:"activeProblems"`
+	Correlations   int              `json:"activeCorrelations"`
+	NodeSummaries  []NodeSummary    `json:"nodeSummaries,omitempty"`
+	RecentProblems []ClusterProblem `json:"recentProblems,omitempty"`
 }
 
 // NodeSummary provides a brief overview of a node's status
 type NodeSummary struct {
-	NodeName      string       `json:"nodeName"`
-	Health        HealthStatus `json:"health"`
-	LastReportAt  time.Time    `json:"lastReportAt"`
-	ProblemCount  int          `json:"problemCount"`
-	ConditionCount int         `json:"conditionCount"`
+	NodeName       string       `json:"nodeName"`
+	Health         HealthStatus `json:"health"`
+	LastReportAt   time.Time    `json:"lastReportAt"`
+	ProblemCount   int          `json:"problemCount"`
+	ConditionCount int          `json:"conditionCount"`
 }
 
 // ClusterProblem represents a problem affecting the cluster
 type ClusterProblem struct {
-	ID            string       `json:"id"`
-	Type          string       `json:"type"`
-	Severity      string       `json:"severity"`
-	AffectedNodes []string     `json:"affectedNodes"`
-	Message       string       `json:"message"`
-	DetectedAt    time.Time    `json:"detectedAt"`
-	IsCorrelated  bool         `json:"isCorrelated"`
-	CorrelationID string       `json:"correlationId,omitempty"`
+	ID            string    `json:"id"`
+	Type          string    `json:"type"`
+	Severity      string    `json:"severity"`
+	AffectedNodes []string  `json:"affectedNodes"`
+	Message       string    `json:"message"`
+	DetectedAt    time.Time `json:"detectedAt"`
+	IsCorrelated  bool      `json:"isCorrelated"`
+	CorrelationID string    `json:"correlationId,omitempty"`
 }
 
 // =====================
@@ -162,16 +162,16 @@ type ReportSummary struct {
 
 // Correlation represents a detected pattern across multiple nodes
 type Correlation struct {
-	ID            string       `json:"id"`
-	Type          string       `json:"type"` // infrastructure, common-cause, cascade
-	Severity      string       `json:"severity"`
-	AffectedNodes []string     `json:"affectedNodes"`
-	ProblemTypes  []string     `json:"problemTypes"`
-	Message       string       `json:"message"`
-	DetectedAt    time.Time    `json:"detectedAt"`
-	UpdatedAt     time.Time    `json:"updatedAt"`
-	Status        string       `json:"status"` // active, resolved, investigating
-	Confidence    float64      `json:"confidence"`
+	ID            string                 `json:"id"`
+	Type          string                 `json:"type"` // infrastructure, common-cause, cascade
+	Severity      string                 `json:"severity"`
+	AffectedNodes []string               `json:"affectedNodes"`
+	ProblemTypes  []string               `json:"problemTypes"`
+	Message       string                 `json:"message"`
+	DetectedAt    time.Time              `json:"detectedAt"`
+	UpdatedAt     time.Time              `json:"updatedAt"`
+	Status        string                 `json:"status"` // active, resolved, investigating
+	Confidence    float64                `json:"confidence"`
 	Metadata      map[string]interface{} `json:"metadata,omitempty"`
 }
 
@@ -194,7 +194,7 @@ type LeaseResponse struct {
 	Approved  bool      `json:"approved"`
 	ExpiresAt time.Time `json:"expiresAt,omitempty"`
 	Message   string    `json:"message,omitempty"`
-	RetryAt   time.Time `json:"retryAt,omitempty"` // when to retry if denied
+	RetryAt   time.Time `json:"retryAt,omitempty"`  // when to retry if denied
 	Position  int       `json:"position,omitempty"` // queue position if waiting
 }
 
@@ -279,34 +279,34 @@ type StorageConfig struct {
 
 // CorrelationConfig contains correlation engine settings
 type CorrelationConfig struct {
-	Enabled                 bool          `json:"enabled" yaml:"enabled"`
-	ClusterWideThreshold    float64       `json:"clusterWideThreshold" yaml:"clusterWideThreshold"`
-	EvaluationInterval      time.Duration `json:"evaluationInterval" yaml:"evaluationInterval"`
-	MinNodesForCorrelation  int           `json:"minNodesForCorrelation" yaml:"minNodesForCorrelation"`
+	Enabled                bool          `json:"enabled" yaml:"enabled"`
+	ClusterWideThreshold   float64       `json:"clusterWideThreshold" yaml:"clusterWideThreshold"`
+	EvaluationInterval     time.Duration `json:"evaluationInterval" yaml:"evaluationInterval"`
+	MinNodesForCorrelation int           `json:"minNodesForCorrelation" yaml:"minNodesForCorrelation"`
 }
 
 // CoordinationConfig contains remediation coordination settings
 type CoordinationConfig struct {
-	Enabled                    bool          `json:"enabled" yaml:"enabled"`
-	MaxConcurrentRemediations  int           `json:"maxConcurrentRemediations" yaml:"maxConcurrentRemediations"`
-	DefaultLeaseDuration       time.Duration `json:"defaultLeaseDuration" yaml:"defaultLeaseDuration"`
-	CooldownPeriod             time.Duration `json:"cooldownPeriod" yaml:"cooldownPeriod"`
+	Enabled                   bool          `json:"enabled" yaml:"enabled"`
+	MaxConcurrentRemediations int           `json:"maxConcurrentRemediations" yaml:"maxConcurrentRemediations"`
+	DefaultLeaseDuration      time.Duration `json:"defaultLeaseDuration" yaml:"defaultLeaseDuration"`
+	CooldownPeriod            time.Duration `json:"cooldownPeriod" yaml:"cooldownPeriod"`
 }
 
 // PrometheusConfig contains Prometheus metrics configuration
 type PrometheusConfig struct {
-	Enabled bool `json:"enabled" yaml:"enabled"`
-	Port    int  `json:"port" yaml:"port"`
+	Enabled bool   `json:"enabled" yaml:"enabled"`
+	Port    int    `json:"port" yaml:"port"`
 	Path    string `json:"path" yaml:"path"`
 }
 
 // KubernetesConfig contains Kubernetes integration settings
 type KubernetesConfig struct {
-	Enabled     bool   `json:"enabled" yaml:"enabled"`
-	Kubeconfig  string `json:"kubeconfig" yaml:"kubeconfig"`
-	InCluster   bool   `json:"inCluster" yaml:"inCluster"`
-	Namespace   string `json:"namespace" yaml:"namespace"`
-	CreateEvents bool  `json:"createEvents" yaml:"createEvents"`
+	Enabled      bool   `json:"enabled" yaml:"enabled"`
+	Kubeconfig   string `json:"kubeconfig" yaml:"kubeconfig"`
+	InCluster    bool   `json:"inCluster" yaml:"inCluster"`
+	Namespace    string `json:"namespace" yaml:"namespace"`
+	CreateEvents bool   `json:"createEvents" yaml:"createEvents"`
 }
 
 // DefaultControllerConfig returns a configuration with sensible defaults
@@ -324,10 +324,10 @@ func DefaultControllerConfig() *ControllerConfig {
 			Retention: 30 * 24 * time.Hour, // 30 days
 		},
 		Correlation: CorrelationConfig{
-			Enabled:                 true,
-			ClusterWideThreshold:    0.3, // 30% of nodes
-			EvaluationInterval:      30 * time.Second,
-			MinNodesForCorrelation:  2,
+			Enabled:                true,
+			ClusterWideThreshold:   0.3, // 30% of nodes
+			EvaluationInterval:     30 * time.Second,
+			MinNodesForCorrelation: 2,
 		},
 		Coordination: CoordinationConfig{
 			Enabled:                   true,

pkg/exporters/http/report.go

@@ -240,7 +240,7 @@ func (rb *ReportBuilder) convertMonitorStatus(status *types.Status) *controller.
 // convertCondition converts a types.Condition to a controller.NodeCondition.
 func (rb *ReportBuilder) convertCondition(cond types.Condition) *controller.NodeCondition {
 	// Convert condition status to string
-	statusStr := "Unknown"
+	var statusStr string
 	switch cond.Status {
 	case types.ConditionTrue:
 		statusStr = "True"

pkg/exporters/kubernetes/condition_manager.go

@@ -535,10 +535,10 @@ func (cm *ConditionManager) ClearManagedConditions() []string {
 
 	// Conditions managed by node-doctor (common patterns)
 	nodeDoctorConditionPrefixes := []string{
-		"NodeDoctor",       // e.g., NodeDoctorHealthy, NodeDoctorCPU
-		"CPUPressure",      // system-cpu monitor
-		"MemoryPressure",   // system-memory monitor (may conflict with k8s built-in)
-		"DiskPressure",     // system-disk monitor (may conflict with k8s built-in)
+		"NodeDoctor",     // e.g., NodeDoctorHealthy, NodeDoctorCPU
+		"CPUPressure",    // system-cpu monitor
+		"MemoryPressure", // system-memory monitor (may conflict with k8s built-in)
+		"DiskPressure",   // system-disk monitor (may conflict with k8s built-in)
 		"NetworkUnreachable",
 		"DNSResolutionFailed",
 		"GatewayUnreachable",

pkg/monitors/network/cni.go

@@ -111,8 +111,8 @@ type CNIMonitor struct {
 	started        bool
 
 	// State tracking for delta-based event emission (issue #8)
-	lastHighLatencyPeers         []string // Previous high latency peer list
-	lastPersistentlyUnreachable  []string // Previous persistently unreachable peer list
+	lastHighLatencyPeers        []string // Previous high latency peer list
+	lastPersistentlyUnreachable []string // Previous persistently unreachable peer list
 
 	*monitors.BaseMonitor
 }