Skip to content

🐞 Misleading error message when times are filled in as a string #393

@Izerous

Description

@Izerous

What happened?

Moved timeout and promptBeforeIdle to environment variables after having it working and values were getting injected as strings instead of numbers. Very much my fault and an easy fix however the reported error message in the console is misleading to the actual error that is happening. It reports prompt must be larger than timeout.

I would have expected

  • The error to report that a non-numeric value had been received "Timeout must be an interger", "promptBeforeIdle must be an integer" etc
    or
  • The library to do a parseInt or similar internally and convert the strings to numbers or throw an error on a failed conversion

Reproduction Steps

1. Set timeout to "1000000" (string not number)
2. Set prompt to "10000" (string not number)
3. Run

Relevant log output

The value for the promptBeforeIdle property must be less than the timeout property 1000000

Screenshots or Additional Context

No response

Module Version

5.7.2

What browsers are you seeing the problem on? Select all that apply.

Chrome

What devices are you seeing the problem on?

Desktop

Verification

  • I have checked for existing closed issues and discussions.

Metadata

Metadata

Labels

bugA verified and reproducible bug.triageHas not been reviewed yet and should not be worked on.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions