Skip to content

Commit 420fdf1

Browse files
authored
If there is not any result, server will return 404 error. #23 (#63)
1 parent 19d0c0a commit 420fdf1

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

functions/src/data/place/get/places/GetPlacesRepository.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,7 @@ async function _GetPlacesFromGoogle(
129129

130130
}
131131

132-
const data = await response.json()
133-
134-
throw new Error(data)
132+
throw new Error(response.statusText)
135133

136134
} catch (error) {
137135
throw error

functions/src/domain/place/get/places/GetPlacesUsecase.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@ export async function GetPlacesUsecase(request: GetPlacesUsecaseRequest | string
7878

7979
try {
8080

81-
const resultSurcharges = await GetSurchargesRepository(resultPlaceIds)
82-
const franchisesNames = await GetFranchiseRepository()
81+
const [resultSurcharges, franchisesNames] = await Promise.all(
82+
[GetSurchargesRepository(resultPlaceIds), GetFranchiseRepository()]
83+
)
8384

8485
const placesWithSurcharges = resultPlaces.places.map((place) => {
8586

functions/src/interface/place/get/places/getPlacesInterface.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,15 @@ export const getPlacesInterface = async (request: express.Request, response: Res
5252
})
5353

5454
} catch (error: unknown) {
55+
5556
if (error instanceof Error) {
5657
if (error.message === "User location is out of New Zealand") {
5758
response.status(403).send({ message: error.message })
5859
return
5960
}
6061
}
61-
response.status(500).send({ message: error })
62+
63+
response.status(404).send()
64+
6265
}
6366
}

0 commit comments

Comments
 (0)