Early-return if SDL icon surface is null

Susko3 · Susko3 · commit d4a050fd54dd · 2025-12-18T00:57:11.000+01:00
diff --git a/osu.Framework/Platform/SDL3/SDL3Window.cs b/osu.Framework/Platform/SDL3/SDL3Window.cs
@@ -467,6 +467,8 @@ private void setSDLIcon(Image<Rgba32> image)
                 {
                     var pixelFormat = SDL_GetPixelFormatForMasks(32, 0xff, 0xff00, 0xff0000, 0xff000000);
                     surface = SDL3Extensions.LogErrorIfFailed(SDL_CreateSurfaceFrom(imageSize.Width, imageSize.Height, pixelFormat, new IntPtr(ptr), imageSize.Width * 4));
+                    if (surface == null)
+                        return;
                 }
 
                 SDL_SetWindowIcon(SDLWindowHandle, surface).LogErrorIfFailed();

Original file line number	Diff line number	Diff line change
`@@ -467,6 +467,8 @@ private void setSDLIcon(Image<Rgba32> image)`
`467`	`467`	`{`
`468`	`468`	`var pixelFormat = SDL_GetPixelFormatForMasks(32, 0xff, 0xff00, 0xff0000, 0xff000000);`
`469`	`469`	`surface = SDL3Extensions.LogErrorIfFailed(SDL_CreateSurfaceFrom(imageSize.Width, imageSize.Height, pixelFormat, new IntPtr(ptr), imageSize.Width * 4));`
	`470`	`+ if (surface == null)`
	`471`	`+ return;`
`470`	`472`	`}`
`471`	`473`
`472`	`474`	`SDL_SetWindowIcon(SDLWindowHandle, surface).LogErrorIfFailed();`