Skip to content

Login endpoint uses GET method and contains redundant null checks #34

@PIyush1Thakur

Description

@PIyush1Thakur

The /admin/login endpoint has a design and security issue related to how request parameters are handled and how authentication is performed.

         if (email == null || password == null || security_key == null) {
                throw new ResponseStatusException(HttpStatus.BAD_REQUEST);
            }

@RequestParam String parameters are required by default.
Remove unnecessary null checks and rely on Spring’s parameter validation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions